Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 12:59:02 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>, iommu@lists.linux.dev,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] iommu/s390: Fix incorrect pgsize_bitmap
Message-ID: <YzXAxmtajuK5fevj@nvidia.com>
References: <20220929153302.3195115-1-schnelle@linux.ibm.com>
 <20220929153302.3195115-6-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220929153302.3195115-6-schnelle@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Qsda0IyMxEJVYDXAg9AQKJajuydL3l2WCKvEAIR7Nbx5yc3GycEA9JXb+r3H?=
 =?us-ascii?Q?GmJ373qqhkaDPlRyrSb5HC6RBJVaBWFLosGsY23EA14plWynSFLyAaTeG+Bz?=
 =?us-ascii?Q?Ax66GVgrjsjapKf/irNTa19oZf18w26J8TtP4jgdBrkDJTy1nDOxMvrsE2kV?=
 =?us-ascii?Q?J1nj/22cy/itSYbKbmiAsaDPJRX9XT67fPwuNZM2VXaLkGZm9mcTxNXiISJF?=
 =?us-ascii?Q?SenwveaivqRR4WG6nnbJm8FLug34QCCnjFVpqxd2UtzMmC7wgcntfz9EdFEC?=
 =?us-ascii?Q?BvRcTlSDztrRLlKz+XCOoWrV9S6khnczab7bsjLo5/Lqq6HR7x3/RYobPqed?=
 =?us-ascii?Q?3MLaGmJ/oDqIRn6NvTwFSnBDsptFHEp6uaOM3CIkO21OQqXK8uBaNiPG2Dlp?=
 =?us-ascii?Q?9Xh0OnbbO25vRvU7EPBiNYYcnGV3BvJLCFpQOXbClNI/mbhmNGkxzHFdSq5v?=
 =?us-ascii?Q?NxtFrt8FZ+hh5d29v8d0CUq7fYU5jJ4mGU5zbX3nu1VlK8i7F8gR9Ph5SLbT?=
 =?us-ascii?Q?u5SVkzfag7xyV67YGt2ECMnL7zLP1Xi4xpSbnvVZtVkrjd6nGUeFVlhlfPus?=
 =?us-ascii?Q?WChSh+36X6yosWnnZhBcdq+z7kF/ILT3tWCtdXoBEm9Vuhwms1GKpM5VmKRN?=
 =?us-ascii?Q?C8AGVtV0QDkatkgsDXP/Fa2+mv6iLM+vHsYB1YZPi8wulnDbmk6LLHqGIdg0?=
 =?us-ascii?Q?umnXCbv8lcwym/n3q9RkfxHsh21n0b5DPw+la4zJuKGg6y7WtGR9piplIfUt?=
 =?us-ascii?Q?8A8dHnkbQNdk7h57WMdvvyKMdmMdqjoHU8jVQjGOxowe1oktK8WWQ5SC8BdN?=
 =?us-ascii?Q?bo4uwPykK7e3wzHraSzI3nZ4ZkcitWLFnkvaeBA8/5dxxbT9GgOGUZ2NCf1+?=
 =?us-ascii?Q?wuh8Tt8KQNSRCTb6CU2J4F04pD09eKRoOdd79UpII7UmWksVScyQTOGurXzc?=
 =?us-ascii?Q?TSTAwWm099JXWD18ADPOdsj1mvX9R8gVlNQDBpWW7vdvCO42dR37eV5FlC2u?=
 =?us-ascii?Q?vV1Lj8NOW1Wl5qQiFHv8feZZw25Y5CRVZEqO0yg5pCJZ0Hvz2OZwjiTH7Zvf?=
 =?us-ascii?Q?VZ+Nwgq7BINwxKYUo9pZGDRFR7UXA4gYt0u7yloKemgqPwfL6G2s0riuY92K?=
 =?us-ascii?Q?fk8LI5TY5QmNJ68YAnTIGV+aFVnaUkUkMqEEgDpWV8cxB550F+amYs43ZQS4?=
 =?us-ascii?Q?S7VtTYLikTFEhv+s8q9LvooDUv4pRjCwKxLlUn8DhzkdZjFftVyKVt1o3Eu1?=
 =?us-ascii?Q?iC284qumclpkrp6F/qaQqL+LccP8pVKO0ERsh6XQHR1EuMELBNCXPmpbchin?=
 =?us-ascii?Q?0IQQE1W3IJgXIUXWOmHPWjevXUvxh9ZivmDrhp5aCGIxB1P/Z5FsGRKCJiDe?=
 =?us-ascii?Q?Uf7z2aXFBwdzWG2BLur8HhhWIPyDIgc0HIh2hFEXXfXRohMwr7lCsksla0Hg?=
 =?us-ascii?Q?i+x85MG+4FtfBbh5Pvq8ep0DnKCErmabASdIiEnSIqy5aUqucnhRid10NddV?=
 =?us-ascii?Q?1T4HDqpK7nYu+A52M1Kw44se803LtGphU1TOEWHtSZEjWbhqnw+Bzlz60lio?=
 =?us-ascii?Q?U+oA0D2DjZqxgkqSBYQ=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6b112ac-0af5-462c-c6c9-08daa23387c2
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 15:59:03.2647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9W3Npq92w4zKig6P6XOFOX0W5D748eqnBBS4faxQMfUaQspp+EP1S5Yaj+lJT1ah
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5664
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 29, 2022 at 05:33:02PM +0200, Niklas Schnelle wrote:
> The .pgsize_bitmap property of struct iommu_ops is not a page mask but
> rather has a bit set for each size of pages the IOMMU supports. As the
> comment correctly pointed out at this moment the code only support 4K
> pages so simply use SZ_4K here.
> 
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
>  drivers/iommu/s390-iommu.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)

Yep!

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason