Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2453172rwb; Thu, 29 Sep 2022 10:20:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM616nNx4NS6zzD5Cjieg6T4VGM0ZP+tKWfe/XvNUTHaIwwD/tWbHQfGh+t5ghkzrL9qv+cV X-Received: by 2002:a17:907:7210:b0:783:37b0:b5ca with SMTP id dr16-20020a170907721000b0078337b0b5camr3407814ejc.689.1664472013212; Thu, 29 Sep 2022 10:20:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664472013; cv=none; d=google.com; s=arc-20160816; b=bh7xOFbYof/dWpB0Ua1+ipDpF1OkzaSJtPreL4lREZd4V3ytvGvh9Hgfph/LD2zGJL F97sF4yQQjQCV1tjK1c+s9Ln4PpcE+EVWoXzIw+FJhOklByl1QLk7btjeoMpoTruFpPQ u16R0GCZyMjZPyZJYAm3JBK9Xgwys+ON7hkg7UQI2G/53lDhw0sUEQV6tPyKQARfbsYK 7XVMuq0a6zKigoScIM+Av5fpzJ0rnYnaSHCKZvniAg0b9WykTwPAjvo/2pGnbwcPpFg3 48IJSA5SP/bPzsmREhTSPvlixVWj1fJAGVJZ1gHDSr3RmStJ/1BxQX5yvVBKn8doywm1 hv8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=O4oWAJ+oPDlKWbEGPAN9ukYz5qB9dE1KyGQCYQEDq0k=; b=BnTeti5+XD5SMRWLabp71xFK4VDXqd0yCZKqtnautnmZSdIjXBftyQjJHM8smz/c61 y6Wk8ToiSECfpldKFqZ1y7jm7J3yQQKzj9BSRwCeoTW9CPUykHARofRrcxLUQ1vAVyg9 yGqb4CIu8kjq7/JkhWDAhTMvZkk2Ru8fVdm/qlgkucQ4A8QONXp03is+kRGULnPhAO1o qQu+aaWGiEUM9r6k42dnbZrfHbf+lYFAK8cmRNQMHXAhVyu+kOO6zZwlao6wsMdm6SVB C0PlfiGzoQ0I/mDaDJwLXIN+TTA60n2lp3ZQFeJzISe/qbePwVvSdycKSV1t+W9zez2n pHBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Fy/5mJKD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y13-20020a170906518d00b007813b1924ccsi7707845ejk.934.2022.09.29.10.19.47; Thu, 29 Sep 2022 10:20:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Fy/5mJKD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235905AbiI2QSt (ORCPT + 99 others); Thu, 29 Sep 2022 12:18:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236142AbiI2QSn (ORCPT ); Thu, 29 Sep 2022 12:18:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1E1A1E05C8; Thu, 29 Sep 2022 09:18:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 45B6F618F2; Thu, 29 Sep 2022 16:18:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D132C433C1; Thu, 29 Sep 2022 16:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664468321; bh=J88gvTONrgsvrQzQWXVVY5JzTHd2WXT/mWs0AYnntww=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fy/5mJKDsXp7Lg5YsP7PwQXhwGe/SBAHWjWlPGB/gVN6ppi8VxNzWWatDyKvH4yff rjw6DY0YRohla5KF92i7r5F0OhVvq2aIIrxCsz0Hn7bSBTDpZHE4djizhtS1+epoxg qg+A/XazNHjGbWzowBcUfzqAnrtcXP8+J2ydd/d7Dan2uEPmSStv7FCygefinDrlqL tJIc5yXTorlhzP8AILMxvAl0zUpTsN/AvlYGDz3pAA+Qsx5+rtaDMvoRh3Y+l3VEJm 4Y3m3b97OhWi0IrjCsN7KO3LS1nxmM8m2P6jKhQ8MRXBIaw9c8uEGWQKMA+Wsu+zMa EYqgNyCnlcU9A== Date: Thu, 29 Sep 2022 09:18:40 -0700 From: Jakub Kicinski To: Peilin Ye Cc: Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Paolo Abeni , Peilin Ye , Cong Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net/sock: Introduce trace_sk_data_ready() Message-ID: <20220929091840.33126dc6@kernel.org> In-Reply-To: <20220928221514.27350-1-yepeilin.cs@gmail.com> References: <20220928221514.27350-1-yepeilin.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Sep 2022 15:15:14 -0700 Peilin Ye wrote: > From: Peilin Ye > > As suggested by Cong, introduce a tracepoint for all ->sk_data_ready() > and ->saved_data_ready() call sites. For example: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] const void (*data_ready)(struct sock *)), Please double check W=1 build before reposting