Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 17:22:38 +0100
Message-ID: <86czbe6tgx.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     broonie@kernel.org, Joerg Roedel <jroedel@suse.de>,
        Frank Li <Frank.Li@nxp.com>, Will Deacon <will@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev
Subject: Re: linux-next: build failure after merge of the irqchip tree
In-Reply-To: <7f9d35bf-282f-68cf-b857-3d7e66dbaf63@arm.com>
References: <20220929143149.126145-1-broonie@kernel.org>
        <7f9d35bf-282f-68cf-b857-3d7e66dbaf63@arm.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 29 Sep 2022 15:40:56 +0100,
Robin Murphy <robin.murphy@arm.com> wrote:
> 
> On 2022-09-29 15:31, broonie@kernel.org wrote:
> > Hi all,
> > 
> > After merging the irqchip tree, today's linux-next build (arm64
> > defconfig) failed like this:
> > 
> > /tmp/next/build/drivers/irqchip/irq-imx-mu-msi.c:14:10: fatal error: linux/dma-iommu.h: No such file or directory
> >     14 | #include <linux/dma-iommu.h>
> >        |          ^~~~~~~~~~~~~~~~~~~
> > 
> > Caused by commit
> > 
> >    841e6e9f2bc95baff ("irqchip: Add IMX MU MSI controller driver")
> > 
> > interacting with
> > 
> >    f2042ed21da7f8886 ("iommu/dma: Make header private")
> > 
> > I have reverted the driver for today.
> 
> Once again it looks like an unused include which could just be
> removed... illustrating a large part of why I took the header away :)

Thanks both. I've now fixed the driver by dropping this include (and
another one) and pushed the -next branch out again.

	M.

-- 
Without deviation from the norm, progress is not possible.