Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 13:20:01 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>, iommu@lists.linux.dev,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] iommu/s390: Get rid of s390_domain_device
Message-ID: <YzXFseFbiwZFSx9N@nvidia.com>
References: <20220929153302.3195115-1-schnelle@linux.ibm.com>
 <20220929153302.3195115-3-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220929153302.3195115-3-schnelle@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+MwHehKyyQptup/t9IL7RCbD7VuSd4c/lYBXrjwacCfyQRIcBw5XhOToCiy1?=
 =?us-ascii?Q?5C/HVZQz9ZQBWdf+wBExRKZYoHUxAh+XGCcs1LFkaRWLeE0MNshmgMEMhgWB?=
 =?us-ascii?Q?e28CXwRvC8FTcxOMsvoZeeB16Zw9pA4CG2tQX3UeSsI6s+4hLWCd9x/2goEI?=
 =?us-ascii?Q?tdJivQPjLarUxjp27WJiVcc5hovmmCtaagm4oDmwkSR8OQF1PH7nAuCyHBjG?=
 =?us-ascii?Q?UipEPDTvfRt4ANt2FX7u/+IHlRjnQ8QslUJvOguzEaEPJKwD6wuMIgKpru57?=
 =?us-ascii?Q?721JQ49R9ttkyoL13S6UP8Df3qHJ6WDF6XyUJdM/nB/mztue7IP1cvDI9E5o?=
 =?us-ascii?Q?n22maRjXdG1Y92Qb4OgP1X3XwIDMvx7vrfZtYsFp6g1A7WD98WRsXvmRdhTN?=
 =?us-ascii?Q?5mL72Niuzlr5DkOjE0tfogd0lzW6CZrVcfethWR16bYvXHV2SanpFOjrxbUS?=
 =?us-ascii?Q?aLFMZQTusT+p7rmYwn3298n4vgA2eIGdDcnNAHenNiUSrhKSksPwhvGnbLZ8?=
 =?us-ascii?Q?q6OSuq+71G7Wa4XhvjRzZepaiBPvCDWqaOcmxTKklaYwUPuTqqEtF1JbfFC8?=
 =?us-ascii?Q?wLb8SiEVDR65kjPH5k4H9mQtWno3P50fwSm2yhG2W9bNMeRlrIiw0u6aYWql?=
 =?us-ascii?Q?BhVfRySCmROYUafxbdqv/FlPEDBOa/PixW8itdSg2AU/JFbSoT4G/m6edC6G?=
 =?us-ascii?Q?cEtxOG0rxde4zoFjRgMFlqgndFThRNi9aDHlEp/Pm6Av3K3JgPrPfmGVCjnm?=
 =?us-ascii?Q?w7sPr9k+zrF8t0iW5i0pQ0HIO6UD7necQXhVEgFp+L5Vp8M6OFJC8wos+eWN?=
 =?us-ascii?Q?TMVePN0UPNzgWHLOWhO+OcPw2cxOl5JTHTLrZ44GAfCVGBfVsod2k2fcYhTF?=
 =?us-ascii?Q?OAL4Dfelv+3/g/2MtLYNn2fAxTNFjxTGvV2cbWhGPiS3eVTnCZjnQfi9FqpI?=
 =?us-ascii?Q?g3oyH1Vt3lWSkTu9IT8iLnaFUNa4qWgL9KtypGwZal1lgT8FoE0hCfZW96X6?=
 =?us-ascii?Q?EdUcOqbAMI7iC7PaZK/kHoDbl/87pTD7uN7pmf5yDPWC/WVQAIo7vsMuOTp4?=
 =?us-ascii?Q?Jnmy+yaqU2W6SfbyvN+z5RaxwtMFseg0lWLvf6ctmEJ/QpiBM3GPekdx8ocq?=
 =?us-ascii?Q?3afsm3kGCBme9bOS/FgOkepBQIjovESXICUqRfdPXJmJm9F2ms+bKtT8nfgZ?=
 =?us-ascii?Q?pcxuexQDfh56jGmr/lHFzRoQiN1vSfT0yWrC2Up3ZOgkUB7tCVqDfCoysFzS?=
 =?us-ascii?Q?DOgZLDt5iD+vfTnWLfmpSmIR4ImodbAZUH5KlG48lU3bjX8Rf4pxOm5PkttC?=
 =?us-ascii?Q?vV/haTeuxSuEDUTTzZc0Ze3TsNSbXgjhHER3agaQsmff/aaJfYScp8m2Q4+/?=
 =?us-ascii?Q?f9MJT5w8tctWCoNB10S2hfMVW/uwIbKp3nDmFqVMb3mQZTgz6BZhwVcFXUyS?=
 =?us-ascii?Q?27pfrkljkOzSlHOYYVGcwXyLQ05jMF1/jmE+gEGZducT98STLnoZGU61uLcj?=
 =?us-ascii?Q?l/ha3vqqp3qxRMhst0fNk/8oRaAQ0RmyzmA2AZqc2ujSGMohs6M6+wOhK6VU?=
 =?us-ascii?Q?mxJtFgHAkyqTmNLfE/E=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db197d5c-5bb0-4257-ed11-08daa2367617
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 16:20:02.1278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h6ucap6nOFEqgjhjaVhi+WLaO/9u05WsqJhkpfspCrbI6XgvIXDaQpT02FgNXUnf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6091
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 29, 2022 at 05:32:59PM +0200, Niklas Schnelle wrote:
> The struct s390_domain_device serves the sole purpose as list entry for
> the devices list of a struct s390_domain. As it contains no additional
> information besides a list_head and a pointer to the struct zpci_dev we
> can simplify things and just thread the device list through struct
> zpci_dev directly. This removes the need to allocate during domain
> attach and gets rid of one level of indirection during mapping
> operations.
> 
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> v2->v3:
> - Remove search in devices list when we have the pointer to the
>   list item (Jason)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason