Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2457283rwb; Thu, 29 Sep 2022 10:23:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4vjWVdowRm5cYINeZuyXEZOJ6jaQj5xLumk9UmdGJB4dMmt/0ldt5PvDuYeoSXpEhZyW26 X-Received: by 2002:a50:cc07:0:b0:453:4427:a918 with SMTP id m7-20020a50cc07000000b004534427a918mr4342472edi.121.1664472210107; Thu, 29 Sep 2022 10:23:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664472210; cv=none; d=google.com; s=arc-20160816; b=SgX/rBCwCUaEj5s3SFTGdMzgfZYjEbPZXYDllNYJWMEGEmi7OGdcxDUHdTy/1rCrSP VpTa556VR8m8Z5y+deHnIbrqJ55rLXXLn/tkxfjDgWQOM2zNXTIw7fbFlO9XZEpVTfax QgxW9qDRbVyNmJNrxFimQLa+WM6uGOQrPXMycJI6ae4j6LJ7OH1fpvIx9exF2Vna51Ij 3Gz7z2BZn1fVoLKxE+oiOc7rPo4plgoYUPzqAkCNJ1qbm+XeYslkoTGgwog2RkSCXerJ mACgXEEFz0GSiOHjJs/tn7l3WiTG7hVemzKe6O2huDqVg9d/NHRoTJc/n59y+pwJ3f+o WvkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/DBk14twR/2CT7Anrh9xMiSi1jU2TYOloMn3YYhosEo=; b=niBie9UdcWbXjnR/mBzDh0lQXGgRRamCc7aQOJjiTTc476VJTuG3IwErFU4czVeb8S 4VbPlJihUEJjrmGUWhhhuoQanV6yrAI8+hQgMOtZ5UkQIj4VfRQ3W88cS2bhk9Xsl5dh SGfp8C4T/c2zUfwKv4oRfyAMDAYxSJ8I7FpmGHh2QV9Sz9HFlT9rv0pwq7BYmjOoKQ8i szcaAmqRlDpzJO5LlU4euFXaSeis2hL01P0z0vMwPtQbDM0HsGsUu90Y42OSw4dgnn90 fYIU6XxHwj0vdmDas+mq/RybRk+m/Tx7mTZ2AqkN7MkEfLNGTCfFZ93Xb3d2jpjP9dra LaLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hh8-20020a170906a94800b007307c26f6ddsi7453436ejb.995.2022.09.29.10.22.59; Thu, 29 Sep 2022 10:23:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235620AbiI2Qjo (ORCPT + 99 others); Thu, 29 Sep 2022 12:39:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbiI2Qjm (ORCPT ); Thu, 29 Sep 2022 12:39:42 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DF3C2DDE; Thu, 29 Sep 2022 09:39:35 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id CA81468BFE; Thu, 29 Sep 2022 18:39:31 +0200 (CEST) Date: Thu, 29 Sep 2022 18:39:31 +0200 From: Christoph Hellwig To: Keith Busch Cc: Maxim Levitsky , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , qemu-devel@nongnu.org, kvm@vger.kernel.org, Kevin Wolf Subject: Re: Commit 'iomap: add support for dma aligned direct-io' causes qemu/KVM boot failures Message-ID: <20220929163931.GA10232@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 10:37:22AM -0600, Keith Busch wrote: > I don't think so. Memory alignment and length granularity are two completely > different concepts. If anything, the kernel's ABI had been that the length > requirement was also required for the memory alignment, not the other way > around. That usage will continue working with this kernel patch. Well, Linus does treat anything that breaks significant userspace as a regression. Qemu certainly is significant, but that might depend on bit how common configurations hitting this issue are.