Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2479947rwb; Thu, 29 Sep 2022 10:41:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7QAPJqh9L3fudApuwN+y07hgTM+UalZETD/mFjF80lUKFIp6/iBzTwl7QhwYdaCZ538uUX X-Received: by 2002:a63:1001:0:b0:43c:c4cf:470c with SMTP id f1-20020a631001000000b0043cc4cf470cmr3770511pgl.609.1664473289356; Thu, 29 Sep 2022 10:41:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664473289; cv=none; d=google.com; s=arc-20160816; b=VyyAyTsClpWkivKfSPaO2WAVMRwTKMTpEozXfIZOh2trX+hjv5mlzwKXZnwqum+6Up GWgO15Pd6Frs+KQ4UUTitjZkVZi9iZgjtkBWvjj0SWSMrJmNXp9r1hDsAPUOkjLQXAys rMmAEYso1mBXR8qJrBCjoyfqv7eN5KfsryEbeLThgUKV2leW5U9WeLfc4eM33WB4cYGd /nPG97bS8CiDnvoL8UB+f4COoQjUi021Ot+o52LJIcSE2AIFyjIhsG+RR6S279QIFFmd qUbpUb9izfIvxPSNzIrvYZyGYGrEItavSQ7meB0Rk7aYopLCo+RxQqzfB+4WbfsgInO5 aNoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Tlw1fMrUL0eLQi9t3IJWRrT4tpDUm8fy19QhjQRWfJE=; b=VJamlP8a0eHcHmim91kKFfqDi30jRgqXy31HpMHy05TsCEPV/YlvXh9rlg9sZ1c+7I mFSoVVZNFAU1CM2Kjhjs6+jlVNKeTdZIqbN8OQ7G2lFuE9bFp4PPRZPoiue08KLckIqS CS58Pf49i/qKG9EfjD/gm38ajYQEzogwG+rT6L/su42UevPiJgoKwztWsWajSUe8tzqR WtdVavrOYX+t76JSkclVlf80ZoBTVUrOrt+el6eWUCqPpPQNhyNVkDFuR1EB2Q4uV2zS 3ETtgeGPcGY2TKfCVipliY+CJXthJb2yc0B9BA2ED2COn59S4ov35qI+7ALwp/72Bwch Bpnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NZXT8wbR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c15-20020a056a000acf00b00537e88da121si7368614pfl.35.2022.09.29.10.41.14; Thu, 29 Sep 2022 10:41:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NZXT8wbR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236002AbiI2QuI (ORCPT + 99 others); Thu, 29 Sep 2022 12:50:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235966AbiI2QuF (ORCPT ); Thu, 29 Sep 2022 12:50:05 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFBA832EF0; Thu, 29 Sep 2022 09:50:03 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id sb3so4001713ejb.9; Thu, 29 Sep 2022 09:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Tlw1fMrUL0eLQi9t3IJWRrT4tpDUm8fy19QhjQRWfJE=; b=NZXT8wbROqUZOWF0Xo9m/345CXRRkMG0teIqYMN/TTcFggcm2Sxmac+HV2TUlKBxa7 s7xBYiZ5RcbllhvckCgGBurAZ0sAYIMdhbhXsTtBBPSjxu0QdEELKnKCbSj3wYYEmYLB rzOK8oWMIbomgNTEPbm2J04NSLbnWf3TFgg8Uk20rW93q8GZChThm0m4p0982etvcdTW crohcJa7RChMoKs+9Dt2Fcrc/Jl9ZdYUlSprPZyU0VE2F+2gffJo/Z0EzdbpPuh5L6Z1 nVA2Tc7MMWySH5ooJjaZHfpDb0wDeP0jMGqIuJZQQRASaaEgPt7zIPo7FFT/nvhmBahO Qd0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Tlw1fMrUL0eLQi9t3IJWRrT4tpDUm8fy19QhjQRWfJE=; b=FZVymzMLaB3xZ/A6f0lY+2KG9d38UNEc0c7rk2Zg0MP7g0Q2FJjQUFVCYVbkQllOyn C6fv7FUD9Q6pyIEvD5n1HTu5MP1JhhchfzCoATUba+kGO5eQR5jVmv4IHuzVRWJpaay/ 14fFgHGuxAuRCEl3cWNIZ3nXSHsBuHwf/bkpwn0L7Vr06IgRHMgB7nIYT46vs8uGGTgW 5EMFJ0kZGoDmJXrSt16mZQvOTaBCmjmmBW7xvLj6PXHi94MHLsSf/CVgZOAgoixmwDcj RDMffxqCkYwsuVBwccO1n4moN5ZXpc1/aNgxypCk4KShCCkaBoBVq2B9F87uCbCCMZ9y MC0Q== X-Gm-Message-State: ACrzQf0lnEyvOr3yxMR5dfqaPC5HqK+tOtF1lXwsC/VGTNU0hp+SvkF+ M5pjfPO1v5wv+KnRLg+tq1vLcsFLQBfCMuGQncI= X-Received: by 2002:a17:907:270b:b0:77b:17b3:f446 with SMTP id w11-20020a170907270b00b0077b17b3f446mr3358000ejk.415.1664470201687; Thu, 29 Sep 2022 09:50:01 -0700 (PDT) MIME-Version: 1.0 References: <20220919143123.28250-1-vidyas@nvidia.com> <20220926111923.22487-1-vidyas@nvidia.com> <09c23fbd-0319-5e06-6c10-dc73352131f8@nvidia.com> In-Reply-To: <09c23fbd-0319-5e06-6c10-dc73352131f8@nvidia.com> From: Han Jingoo Date: Thu, 29 Sep 2022 09:49:50 -0700 Message-ID: Subject: Re: [PATCH V2] PCI: dwc: Fix n_fts[] array overrun To: Vidya Sagar Cc: gustavo.pimentel@synopsys.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2022 Vidya Sagar wrote: > On 9/29/2022 7:34 AM, Han Jingoo wrote: > > External email: Use caution opening links or attachments > > > > > > On Mon, Sep 26, 2022, Vidya Sagar wrote: > >> > >> commit aeaa0bfe89654 ("PCI: dwc: Move N_FTS setup to common setup") > >> incorrectly uses pci->link_gen in deriving the index to the > >> n_fts[] array also introducing the issue of accessing beyond the > >> boundaries of array for greater than Gen-2 speeds. This change fixes > >> that issue. > > > > Dear Vidya, > > > > I am just ok with this patch. By the way, do we need another patch to generalize > > this setting? Currently, this code targets only Gen1 and Gen2. But, in > > my opinion, > > it is possible that this driver can be used for more than Gen2, > > later. PCIe Gen6 > > standard is available and Synopsys has their solution for Gen6. So, would you > > send a new patch to generalize this thing, later? > > Thank you. > > As I mentioned in the commit message, current code is incorrectly using > 'gen' in the index and ideally n_fts programming has nothing to do with > the speed and hence I tried to remove the 'gen' reference in the current > patch. So, the same code (after applying this patch) should work for any > future Synopsys IP versions supporting higher speeds. I see. Thank you for your confirmation. Best regards, Jingoo Han > > Thanks, > Vidya Sagar > > > > > Best regards, > > Jingoo Han > > > >> > >> Fixes: aeaa0bfe8965 ("PCI: dwc: Move N_FTS setup to common setup") > >> Signed-off-by: Vidya Sagar > >> Acked-by: Jingoo Han > >> --- > >> V2: > >> * Addressed review comments from Bjorn > >> * Added "Acked-by: Jingoo Han " > >> > >> drivers/pci/controller/dwc/pcie-designware.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > >> index 650a7f22f9d0..3df687667f27 100644 > >> --- a/drivers/pci/controller/dwc/pcie-designware.c > >> +++ b/drivers/pci/controller/dwc/pcie-designware.c > >> @@ -649,7 +649,7 @@ void dw_pcie_setup(struct dw_pcie *pci) > >> if (pci->n_fts[1]) { > >> val = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); > >> val &= ~PORT_LOGIC_N_FTS_MASK; > >> - val |= pci->n_fts[pci->link_gen - 1]; > >> + val |= pci->n_fts[1]; > >> dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val); > >> } > >> > >> -- > >> 2.17.1 > >>