Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c50baa4-beef-54b9-74fe-1cbf6e8f8dbd@amd.com>
Date:   Thu, 29 Sep 2022 23:04:50 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [RFC PATCH] sched/fair: Choose the CPU where short task is
 running during wake up
Content-Language: en-US
To:     Honglei Wang <wanghonglei@didichuxing.com>,
        Chen Yu <yu.c.chen@intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Tim Chen <tim.c.chen@intel.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Juri Lelli <juri.lelli@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        Yicong Yang <yangyicong@hisilicon.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Ingo Molnar <mingo@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        linux-kernel@vger.kernel.org
References: <a6e38a33-0003-d3ea-de9b-cf805aef647f@didichuxing.com>
From:   K Prateek Nayak <kprateek.nayak@amd.com>
In-Reply-To: <a6e38a33-0003-d3ea-de9b-cf805aef647f@didichuxing.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TThwb1lidXo5VFNJNlZSbENSb2Nma2Y5ckdwSVhWV0RwVHppdG94c1BVZU1m?=
 =?utf-8?B?WFhYRlVsbGNrYWJJU3pMTGtJSDNxYjE5d1pXYXZQWWIrUTBoUXpSaUIrT0hp?=
 =?utf-8?B?M21nMlVJeWt0WFdaalRONlpjVW5pVk04dW4xcWVRZUV0R0xjZEJjdlcyTzJ6?=
 =?utf-8?B?OXNPNkJ6NnlXMG9pN29rNHBicjV0ZEdEYXJnNkhMblBNbitURTlpNlkxSTJk?=
 =?utf-8?B?YnhyeTB1K0dLR3d1ZlNHSWxTTjZFd0NsdDBtL1RYTnkrbUZIV2o1TSs0aVcz?=
 =?utf-8?B?Z2hoVFdYdkdDWTkwUnFPNTBWN0ZDRC90YnpER2ZCT2FubE04WDdzNmRObGhx?=
 =?utf-8?B?dmlaRG9LMVJEWXp3cmx4b0lBcG0vUWZPZmlCVzVPOVoyck9QU0lRWmF5U0NR?=
 =?utf-8?B?Mkxob0hscTkrb3ZNZHdaKzVsejJTVHRhUDNuc29UajMxdE5jazVBekRyUmk0?=
 =?utf-8?B?VkhLcTlieDFaUWgxWXRYWnhXSFh0aVhFdXlUWS80ZVN0R1E0ZzhxWWE3S0RQ?=
 =?utf-8?B?SjlDcHlCcUsxejllbXFURTdibmdMMDFZd0lVNEJwUDZJbFB5SnkwK0NjVzV4?=
 =?utf-8?B?OCt2MFBSMXhablJCZ1N0S09vZHZrZzlqUndOb25pMjI1UUxnRHdQcUxpOU9G?=
 =?utf-8?B?VDNyTWVkdkFoT0JhdkdHSHdOSUhEWnltNExWSXhnMU1DdldCS3ZFKzk1cTNB?=
 =?utf-8?B?bHZaSjBxVWtsaHExMGZuK1BVaFpCMWJLaVZKaUpLVmwyR2dWbnFyR2R3RjVm?=
 =?utf-8?B?b2xJbzgrcTE2Zy9yUE1OMVlPRTVldzByUmtSQm1zZ3lIajh2c2VwNmZDK2k5?=
 =?utf-8?B?Y3NZanhDSlZWaW9XTVJYTjFQNVJRcjU3RnN1TjB6S3g4YkJWTEQ0QVZyU3JS?=
 =?utf-8?B?NjVXazFvSXlJQk9ZMHBqcVlibGF5WTFLeHk4LytyQWx3azRjaURGdG5pYUpD?=
 =?utf-8?B?d05laW5kcXRyN0o5Yjlqcmd3dzNGMTZpMUtxRzFiZUdYQWZIVTRZWXlFbTVE?=
 =?utf-8?B?K0FXejdpNk9ZcHpYOEJzeVp1OWc1VEg1SktYYnRtNThhZjE2TG4xNHVrWHlk?=
 =?utf-8?B?bHgyNGpYalJGUGJMemFvdnIwVzhDcUkza0F2b3VGU2Q3TEVnRUFHUC9YWEJ6?=
 =?utf-8?B?cFV1TmtrYVROdE1OUW5NMEdvaWkyY1ZEZG9uMGZsVWNYK1RvT2ZMbjZQSktU?=
 =?utf-8?B?bVlaSythcnZBZFFZeDRGaTl5VTRZUlFGSmllRzZxdmJuQzJ2NFdYNXArWU5P?=
 =?utf-8?B?MEJyaGIwbzh0VExBUGlsclFhQUNqcGV2T2dFZ0RjclpmYU9kUkk4VXFsV2V1?=
 =?utf-8?B?UDllNFpCcVpFQlcwU0lLdU8yV2Q1M2RUZjVhWmx3SUhPVFlBMEsrQmNDN3RW?=
 =?utf-8?B?ODhENUV1V05NbkNDMjF6emMzWjBIZkY4ZnRzVkx2TUpHSTBkOW40MkY3VnlP?=
 =?utf-8?B?SGdDenJYUVNCZUtQdUp2cXQ0Q1VDNWh6MTVDamVwZms0WjJVWWZSeS9rdFor?=
 =?utf-8?B?MVVPSHlMQksyZE5Ua0VqU2k4bUdta2JnV21ydnJUUCtJNFJIcXFSVGlURjhJ?=
 =?utf-8?B?UEw4eUF6Uit2RCtOdmVXUk1Vd1ZXaDhUWWhRSHJWZ3RsK0h5NFUxaEpQSjgv?=
 =?utf-8?B?c0o2dDBjZVZFeHhZSnAycFh2VjRMSnBFcnRVWXRDbFBpbUY0TzhLNW5lOGZl?=
 =?utf-8?B?UGVOSTZhYlVhV3k0UTVmSDF2eVNUTU5SREVoU1BvZVBLZHMxZkdSVUNSMmxH?=
 =?utf-8?B?VnR6bWNMWTNXMkx0OVkwVnJQa3NDbnJFdno3U1dhUm9TQ292ZjlUU3NjTk9x?=
 =?utf-8?B?eFhEUm1QUjZTck4xdUtRV3FXZXcxMHpEZUJzVVFuclNBZW4rWVJYampSdjVF?=
 =?utf-8?B?R3ZXb2tlMkRUNkRJcWVtcmsvRHJHc01zQmVmMUJJbkF0em0zQk1QbGpNcys3?=
 =?utf-8?B?UGo0VlhBdytGT213bWN4OUlOWkN4NFExdUNzRXFhaThIa1pFRUpUMzFBSzI3?=
 =?utf-8?B?SGhzU3pWSWYvcGE1VUdtbjU4M2NwWkxlTndnd25leUdZYytqbnZlbmZuc25X?=
 =?utf-8?B?UUtOVUhrWDRZYTlkam9JMkRPWWphVGVIc2tKd2NHbmpoaVJkUEJwUlkzNXVM?=
 =?utf-8?Q?wePZL32Z6IICsNwYudgCfPcmh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed6d679-f5f0-435c-9158-08daa240f526
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2379.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 17:35:10.5273
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e822spZMd1VWuiCM723314xxXU4hlONFRQjhpRv8HHFDnuajcqTQVvh8DF0++EoT1VxbDALyzP9YBYGzNxS1pA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5374
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Honglei,

Thank you for looking into this.

On 9/29/2022 12:29 PM, Honglei Wang wrote:
> 
> [..snip..]
> 
>>>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>>>> index 914096c5b1ae..7519ab5b911c 100644
>>>> --- a/kernel/sched/fair.c
>>>> +++ b/kernel/sched/fair.c
>>>> @@ -6020,6 +6020,19 @@ static int wake_wide(struct task_struct *p)
>>>>       return 1;
>>>>   }
>>>>   +/*
>>>> + * If a task switches in and then voluntarily relinquishes the
>>>> + * CPU quickly, it is regarded as a short running task.
>>>> + * sysctl_sched_min_granularity is chosen as the threshold,
>>>> + * as this value is the minimal slice if there are too many
>>>> + * runnable tasks, see __sched_period().
>>>> + */
>>>> +static int is_short_task(struct task_struct *p)
>>>> +{
>>>> +    return (p->se.sum_exec_runtime <=
>>>> +        (p->nvcsw * sysctl_sched_min_granularity));
>>>> +}
>>>> +
>>>>   /*
>>>>    * The purpose of wake_affine() is to quickly determine on which CPU we can run
>>>>    * soonest. For the purpose of speed we only consider the waking and previous
>>>> @@ -6050,7 +6063,8 @@ wake_affine_idle(int this_cpu, int prev_cpu, int sync)
>>>>       if (available_idle_cpu(this_cpu) && cpus_share_cache(this_cpu, prev_cpu))
>>>>           return available_idle_cpu(prev_cpu) ? prev_cpu : this_cpu;
>>>>   -    if (sync && cpu_rq(this_cpu)->nr_running == 1)
>>>> +    if ((sync && cpu_rq(this_cpu)->nr_running == 1) ||
>>>> +        is_short_task(cpu_curr(this_cpu)))
> 
> Seems it a bit breaks idle (or will be idle) purpose of wake_affine_idle() here. Maybe we can do it something like this?
> 
> if ((sync || is_short_task(cpu_curr(this_cpu))) && cpu_rq(this_cpu)->nr_running == 1)

I believe this will still cause performance degradation on split-LLC
system for Stream like workloads. Based on the logs below, we can
have a situation as follows:

	stream-4135    [029] d..2.   353.580957: select_task_rq_fair: wake_affine_idle: Select this_cpu: sync(0) rq->nr_running(1) is_short_task(1)

Where sync is 0 but is_short_task() may return 1 and the
current_rq->nr_running is 1. This will lead to two Stream threads
getting placed on same LLC during wakeup which will cause cache
contention and performance degradation.

> 
> Thanks,
> Honglei
> 
>>>
>>> This change seems to optimize for affine wakeup which benefits
>>> tasks with producer-consumer pattern but is not ideal for Stream.
>>> Currently the logic ends will do an affine wakeup even if sync
>>> flag is not set:
>>>
>>>            stream-4135    [029] d..2.   353.580953: sched_waking: comm=stream pid=4129 prio=120 target_cpu=082
>>>            stream-4135    [029] d..2.   353.580957: select_task_rq_fair: wake_affine_idle: Select this_cpu: sync(0) rq->nr_running(1) is_short_task(1)
>>>            stream-4135    [029] d..2.   353.580960: sched_migrate_task: comm=stream pid=4129 prio=120 orig_cpu=82 dest_cpu=30
>>>            <idle>-0       [030] dNh2.   353.580993: sched_wakeup: comm=stream pid=4129 prio=120 target_cpu=030

This is the exact situation observed during our testing.

>>>
>>> [..snip..]
>>>  
--
Thanks and Regards,
Prateek