Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <97e4b580-68c4-84bd-1cca-1467a134ae7a@amd.com>
Date:   Thu, 29 Sep 2022 20:14:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/3] dma-buf: Remove the signaled bit status check
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220927172409.484061-1-Arvind.Yadav@amd.com>
 <20220927172409.484061-2-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220927172409.484061-2-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OCttNTFCdS9QRm91TVBKemtBSUpHUktuQnY3Nm16WjdPdUJCWU0xeDk0UlBE?=
 =?utf-8?B?Z0lXYWdBUGM1cVBGMXBteHl0aFVXdnhMcG1qK0lOSWR1WGFNTnptOCtycDJV?=
 =?utf-8?B?T3FSUm0wNlJsM3FHUjlMR1ZpZlBCVE9pRERQbEJidTYvL2FYNlVQTE9QaUJl?=
 =?utf-8?B?NVpXL212dy92b25qeGE1SkdlMGw2VFc1a25sN25JUFo0Vk0xZkdHYlk4cUl0?=
 =?utf-8?B?ZDF3QkFCTHZBb3NhQXFLY3JpU2ppNHRzZEpwaGtxSENLUVBDQjNTVXZsMzJG?=
 =?utf-8?B?cEk1ZThCUWtGM2krUzU0V0V1aS92Q3ZLQVd1bS9ZaXdqRURDQ0hnaGtzdUhh?=
 =?utf-8?B?VlVZeTVvQ0V2WlpjMFhEenRrdE9PQ1V0cFNTY0hzWFBmOTF2OHJ2V1FSR1RK?=
 =?utf-8?B?WTUxeUErZkpWY01reDlxVUtXZllzZk9NT2VTREtDNDN6ZGhzNnRUOGxjanJl?=
 =?utf-8?B?Zm9rbXl5ZEQ4bHFKZTVJMU9FMkk2aVNjNWVCN1lJMmtaQ0s1VHlPT242dGFY?=
 =?utf-8?B?QUlwTkluaTk4c083SEpYaXNxQlpNOWo3MjRESEU2Qll0dDF3YXdIaGNYVHh4?=
 =?utf-8?B?TEpqK1hCdEVabUFRUjRGMllqcFdEbFN4WUFETmVHOTVSb3J4WDJjVTJrQTVE?=
 =?utf-8?B?QzVNc3VSMVFPRTNPczBwSnpTeHFhazVRWk4wZ0FlWFJJUkpMZytoQkQrTWlG?=
 =?utf-8?B?b0xrdHY1NTRGOC9qVjFmSUlPaFF5cTVqb1pHbzJCOHI1SDN1TFVENW5vK1M1?=
 =?utf-8?B?cU9pVWFVUTZCOCtDMHpaWXp1SzN3cDNqcHRkdERjSHZpc2VObVpqRGhzVnhW?=
 =?utf-8?B?cS9Db1dtQkxISXhFZ2w1OXU5aXphQVdsVzljSjBYejVLMEJxMVE5T1BXQTBF?=
 =?utf-8?B?d0JHK3ZtVmpnbHg3RHJNeEtiMkNPZE80VThXZnJjMTMzcUFrN01RMnVYY3N3?=
 =?utf-8?B?Yi9yWG9NV1NmM0xweEFVSGJGa1lEMldlSC9na1UyZWVIejgvY2VUblJOOG4r?=
 =?utf-8?B?Q2Y2eGw3YlM5YXJMdVVTYzhYVlpYYldScUhRMEJUT2FUWnhZZkZ1SzNETDAy?=
 =?utf-8?B?TS9QUHpCaFZpSE9xeVVLZjhmeGZnb1hBTzhlbVZMZkIvSklNQTRJZlplc3JF?=
 =?utf-8?B?ZFVkcEpJQUZGc3NhM2pPYXpsNjhrWTlRRTlQNzBEbEl5WGU2MVhiNGF5dXd2?=
 =?utf-8?B?Ny9XOGJHK1VDODQvWFI5bHQ4eDZwQldueHRjMzdtMlZjMFRiWERZdUxWNy9a?=
 =?utf-8?B?czdHUVR5dHNYMzFKUkFrUkFNRVFOdnU2Y1ZzMjk1T1lWNXR5MkdIeXRMUEY4?=
 =?utf-8?B?ekpDTEVHa0RIVjNSQzJPWTNqVW41bjFKUDAwcjdwYzZVUE92ejIydDNtUmhV?=
 =?utf-8?B?TGNtSGV2dzNEdlo2YWw2SStFUjFJNmNyUERTVWtOMEZkZXFyS3dSL0laZ0RO?=
 =?utf-8?B?VEhrbU1vbTlVSXBCWE1ncWgxUUIyTFAvcHlBR1dHVStEOHJXa01lU1FQdjVv?=
 =?utf-8?B?dUxRcmJrMWF6UlU1azNxMmVtSG9vVHBjU0JYaEpia0dYcTc2UjB4bnRFMld4?=
 =?utf-8?B?TTJidStrekZMWjE5cmJWYldPYXFsTjdOQXhvcWpKNUdiZUpqb3V1dVZ4S3Y4?=
 =?utf-8?B?WTdDWVZtanoyNDBUZnpDa2w0UFZJZGNWaVQ0N3FSZHY0OXo3RjcvSkhyOVl4?=
 =?utf-8?B?MUQ1aFI0YmlkSnBmVVpFRFpyQmdsdGpZWVB5cVNKNTU5NEFINlBaZWo4WGdx?=
 =?utf-8?B?ZWNMMGJqMjFSUVpiTFRSdGVQeHF5U1ZWcHdIeGhpbzZ1VW50VU9YMS9MVDVv?=
 =?utf-8?B?UGYwMjVUc0dsTGh5K2tCWGJjaGJ2VE9kMkRBL2FOMDJ3VVdKK1FJOGw5Sk5S?=
 =?utf-8?B?QllnakVtUWNWZmlrYVVodVBhMkcxeFRvRnhlWXVFRm9BbFRXb0Z6Q21VMDE3?=
 =?utf-8?B?VDRpYmRCdjR5QTk2U3UwMmRnRUZ3dHh5N3hoRW9SYnNIYzgzWGlQM1BxM1Bh?=
 =?utf-8?B?eERmODlWakJxcEJaSnF4MjIwaEoySUpRZGlST2t2Mms3RXlIT3BVMWRUbjdT?=
 =?utf-8?B?c3JQemtZYVJkRm85bmFJSW9ROEhZZWRtR2VEM0EyeXQyMzJrblJwb3RiazBB?=
 =?utf-8?B?dEQ0SWJadWgwMnhMWkY5V3BzZEdOclArR1YvcWRmWkxTbnV4Z1Y5cVlsRWRF?=
 =?utf-8?Q?OtP6+JYUZCL95FjZjz8gWH4Hm3L5XdKRjIk0kkyu4KAN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52cc1c87-608b-475a-5862-08daa246867c
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 18:15:01.7333
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NkJj04hqv4WMmUbTSMobJ8qYhrJsjzCFv2h8hlDPIYYY9q3Ve3b71x2fvr3dxC+1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5057
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 27.09.22 um 19:24 schrieb Arvind Yadav:
> Remove the extra signaled bit status check because
> it is returning early when the fence is already signaled and
> __dma_fence_enable_signaling is checking the status of signaled
> bit again.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/dma-buf/dma-fence.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 406b4e26f538..11ef20f70ee0 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -648,11 +648,6 @@ int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,
>   	if (WARN_ON(!fence || !func))
>   		return -EINVAL;
>   
> -	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
> -		INIT_LIST_HEAD(&cb->node);
> -		return -ENOENT;
> -	}
> -
>   	spin_lock_irqsave(fence->lock, flags);
>   
>   	if (__dma_fence_enable_signaling(fence)) {