Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <efce6f23-135d-d946-6677-0668d83a7831@amd.com>
Date:   Thu, 29 Sep 2022 20:32:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 3/3] dma-buf: Check status of enable-signaling bit on
 debug
Content-Language: en-US
To:     "Yadav, Arvind" <arvyadav@amd.com>,
        Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220927172409.484061-1-Arvind.Yadav@amd.com>
 <20220927172409.484061-4-Arvind.Yadav@amd.com>
 <59d4d647-f451-061c-79b5-0ffc4e33fc58@amd.com>
 <52ed8ec2-bd90-ad40-fe85-83d60eda7e05@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <52ed8ec2-bd90-ad40-fe85-83d60eda7e05@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEc5a0k3Z21ybitrSWxIZldDZFRQYTk2SVgxOHBMVDlSdDJQSGJmbnFCWWNp?=
 =?utf-8?B?bTA1TWxGdElKOVFjV0FDUzV0VkdobGxIcWh5Rm9wYkZGQnRxQlluN3ZyQ2FL?=
 =?utf-8?B?Q25CQ2VGeWtPL2VHWFdYTDJtVlZZVUt1ZWczWjd3WUtxQWRPUUE3QktBd2RM?=
 =?utf-8?B?bjNFSlJZbVZvbVFtRTc4RE5XYWdCZktGL3VFRDhNbGQrU2UrTS9hTG5BS2J1?=
 =?utf-8?B?WlNFdm9UelZmb0VYekVsTWZVNjlDS0lNenBBUXJsQjZlVkdHNmI5V2dyeTVq?=
 =?utf-8?B?Vi9HSWRNZk9UTkRNYW5SdjRLb2lmRGtQYk03VzRZeFRkV016cFY0M1dyYld2?=
 =?utf-8?B?UEFneXIzS3FFN0Q3SlYzTVhGVFVwaU1JdHp6SzI5ZTR0RDNjWlNqZ0gvMm9L?=
 =?utf-8?B?bm1sVlBkWXdZZ1hyNDBVQk53SGZmaU1iMkVPNEVIZ3RPSGtYQkZIaUVzM0Uw?=
 =?utf-8?B?a1RrVEJHMDd5Nkt3VVh0Q2VOaThxT3dUUWhmbXJpNUYxdmJ1SGZZTkdIRS9E?=
 =?utf-8?B?YVd5R0NtdG5hem5jM1I3OWg0TW9ja3lsSWptSFg5NkJtampmcE5QSzlsNFc3?=
 =?utf-8?B?QldMYTZXY2FaWVhnOFZVdXdodFA2VnMvSHpYYStzaFlJUExSdll6UWVCTmNz?=
 =?utf-8?B?ZzFzd0krd0tOOWZPZ1dqRkRmRWFnWXFxMXVPbXZVbDNucVBhT2ZGSFYzSGtJ?=
 =?utf-8?B?Tmh4dGkveW5VTEI1d21oSlB3U05IZEU1N2dtV1VNQmJVME0vWCtYSTNrVjNO?=
 =?utf-8?B?WGM4NVM2dlpzNXdxdHQ3d3FRSHgyU2lObnpVRGF3OHEvV09KSlZvSXJDbks5?=
 =?utf-8?B?bXVKNE9aQUFXOVYzTWtnK2cxR3ptb2FrZi9tMUFlUnFldU56Tlk1TlRla1VJ?=
 =?utf-8?B?QXRLcm9ES3IrTVFsaW15akQzcWZzV0NZclFYMFdpR2g4RzQxbDZPOFIrZlYr?=
 =?utf-8?B?WlBVZ05pbmtZV0NPa09saUgvUVpjYTdwMGQ4eTdzb0xmcE1RczU5S3kxWW9k?=
 =?utf-8?B?RWhpYm81Vml2T0ZlQi9QWi9BUTM4VG5RYWNmWGVSNkpZc3ZvT1FUQVd0TVJk?=
 =?utf-8?B?VnFuTzl1VVNQVEEwRkVlSzdpM2x4clFGWUMwMC82S1pQc0tUdXc4enVDaEtx?=
 =?utf-8?B?WnI3ZDgrYy9FalhZOFE0UXJyL2NISDdQd2hlNDBrdlkxZW9LeHFWT2pNSWNQ?=
 =?utf-8?B?cG1vbVluUHNvRGVicE1qU1FoVThLN1JLRG9WTWthVWRZWHJMMW1xOSs0RmJD?=
 =?utf-8?B?UzByUi9Sa3lCdUtEdW91dDBYbmNUNUFncHlmRTdiVlhTNmViWDZCb0oxanNz?=
 =?utf-8?B?MldGcHZPMGlzdHlKenZkRTRSbUZLbHRLVzdTQ0tYL1VOWENBd2FPU2JlWHY5?=
 =?utf-8?B?aWdDK2paam9ub0FjRU5QNWV1OGJwZUpuUHlyVHZkcmRCR295bzRxc0JvU0t4?=
 =?utf-8?B?WXk3aTR5b0hJQlY4RjQ0QlJJOUtqSDByMXlnYkZzL3VIb3M2UzdYT0JDNFc1?=
 =?utf-8?B?V2xlaXhWYmlzd2RuSEVEdUNLT3IrNldranR3TWlqblZHblBDdzZhTm5aN0xj?=
 =?utf-8?B?S3FTZkdGd0l2TzZZb04wYXlxUjRoKzR3OHJOL0lUOUIrUGwzelZIODdOU2Ji?=
 =?utf-8?B?TFNCMVhVaU5yRTZOMVpSQ2pRQnM4SXZzMTI1dW9QeWpoaFZybTNxNUU5d3Bt?=
 =?utf-8?B?bkE2N0RTWkRpanhsQTBRN2NwQm9NZFlRd0FHalp4ZllCWHZUWTg5Z3UwOTJP?=
 =?utf-8?B?MVdNdTVRWUhuRE9xRVY0T2VFT3lYNE1VQ3JXN0NRN1hyc29KSkR6U2MwNUlS?=
 =?utf-8?B?Q2xpdkdMTDVLRlIrakQvL3M0M1hUd0w3NmFnanJvSWZVUzdDb2dHR0Zyb0c0?=
 =?utf-8?B?VWdHNXZIUG9TdFA1SzYyL0YxS3pKTG5ocm1oVHBxdzRnZDZMMWZOQVRVaHd6?=
 =?utf-8?B?ZEg2Z2NqajVEN2FzNEVhWTBONElFQVI1QjRVM0dxV3lJQlZYSERseXpnajRu?=
 =?utf-8?B?dHN0enVPUXVjSitkbXZ0KzVpeWMxTUo2UFBPZ0JmOUNDbFl2T0hjWXhNREpk?=
 =?utf-8?B?dUd5UWJqVzc1cVFuQm9wekxTUVNTK1FQMmlNYnFGY0ZhclRsZE9lS3VJZXU3?=
 =?utf-8?B?cEk5Nnlnd3hWeTFFbm1ZTU5Uck5CNUNJNkFRMVRqYnQ4L2JaUENmek1aVklq?=
 =?utf-8?Q?VL0BlNNJbPVKtQSyCuPuut5NMmBgH28LZ7qZhfNJyMzb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e2c0df7-b595-40b5-8955-08daa248ee4c
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 18:32:14.7403
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jBPYzyVLGhRD0qcMU3RNlFx8FhtKj42yVPIhNrl0VsFTZrAsl+kP6gtPHhylu1Lz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5069
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 29.09.22 um 20:30 schrieb Yadav, Arvind:
>
> On 9/29/2022 11:48 PM, Christian König wrote:
>> Am 27.09.22 um 19:24 schrieb Arvind Yadav:
>>> Fence signaling must be enabled to make sure that
>>> the dma_fence_is_signaled_locked() function ever returns true.
>>> Since drivers and implementations sometimes mess this up,
>>> this ensures correct behaviour when DMABUF_DEBUG_ENABLE_SIGNALING
>>> is used during debugging.
>>> This should make any implementation bugs resulting in not
>>> signaled fences much more obvious.
>>
>> Are all IGT tests now passing with this? That would be a bit 
>> unfortunate because it means we still have missed the bug in 
>> drm_syncobj.
>>
> IGT has these test cases related to syncobj (syncobj_basic, 
> syncobj_timeline and syncobj_wait)and all are passing.
>
> I will check syncobj and let you know.

Maybe CC the Intel list and let their CI systems take a look. That's 
usually rather valuable.

Thanks,
Christian.

>
> ~Arvind
>
>> Christian.
>>
>>>
>>> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
>>> ---
>>>   include/linux/dma-fence.h | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
>>> index 775cdc0b4f24..5156dc6be0a6 100644
>>> --- a/include/linux/dma-fence.h
>>> +++ b/include/linux/dma-fence.h
>>> @@ -398,6 +398,11 @@ void dma_fence_enable_sw_signaling(struct 
>>> dma_fence *fence);
>>>   static inline bool
>>>   dma_fence_is_signaled_locked(struct dma_fence *fence)
>>>   {
>>> +#ifdef CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING
>>> +    if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
>>> +        return false;
>>> +#endif
>>> +
>>>       if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>>>           return true;
>>