Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59d4d647-f451-061c-79b5-0ffc4e33fc58@amd.com>
Date:   Thu, 29 Sep 2022 20:18:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 3/3] dma-buf: Check status of enable-signaling bit on
 debug
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220927172409.484061-1-Arvind.Yadav@amd.com>
 <20220927172409.484061-4-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220927172409.484061-4-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1J2YzlOR3JVZFB4SEo1RlVBb0d3cVlFNjVuV1MvV0h3Rk1Zb0IwaFhKT3lR?=
 =?utf-8?B?STQrNXdmd0hCTnR3UG5jR2dVWWdhMVh2Z0ZWcjVxOGNmOU1uNVNGQkJmQ29j?=
 =?utf-8?B?dDBnZkxaRmhuQzhWRTBmT3cra3d6dG14a3l3TTRsUWNaRi9Kc1Z5S3R2ckRr?=
 =?utf-8?B?ZlM1THlsVzRjS0pNY1hHdjZOZi8vRUorRGY3UE1rSUJjcHNKSTlSSjZHZnRt?=
 =?utf-8?B?bTMvQWJPMWVwV1FGV0kvaXAyVGx5VC9mblpyNGJMbDdvRzZvbWZUZnQ3LzZZ?=
 =?utf-8?B?OGJHQWFhOENhZHV0K1RyckVoMCt5K1VCVEdaYnVmekJGc1J3QlpDWnhlWHRn?=
 =?utf-8?B?bUx6L000NjkwVm1NN004TjdaQUtUWmM4ZElqODkxaGVmTkxibEJPcW9SbC85?=
 =?utf-8?B?YjRyYkVQbzhiRUk0QnZxMlZTUW9sZGNhMG5jc2NPajYwRDlFZHJ0cHRYVHJM?=
 =?utf-8?B?a1ZaMnpoMktKQjRwWVdzTTlnNStmKzBXa0p5UnRDV3BHdnhJeWpxd0MrYXJ4?=
 =?utf-8?B?Z0ljbFpmUkdRY1JUSW8wa3ZrZ2l5cVg0bTJNalYzVWVZUGZDblZGZGw0clI3?=
 =?utf-8?B?Y29ncGd4bzZiVSs5WHRoMEt3WEs4Q01zOXNnNDdSM2lQazcxUE4vdlhSTGF3?=
 =?utf-8?B?Mkt2dHVNcGVFTEpreWdSM09QQjJyRUc3K05GdkY2Y0FDckxaVVpTV3RjUEVU?=
 =?utf-8?B?UjR1cWszM0Fua1dXZGRiZDViTVIxVSsvUFJyMGQxR0pFU3ZZWTBYMlJVeDdo?=
 =?utf-8?B?eXBuTW1TNFdlQWVUZnJtRE4zMzZ5RHlEUVdGVmFUbGRjS01BcE9mMFNEU3Vt?=
 =?utf-8?B?SUl5QTdyYTZjVWxidUVaWFhwa1RpY1lRSlFTbjVqTEhxOWFpMDBjOUhqaEZE?=
 =?utf-8?B?V2o2cXZ6dWMrcDUraUVjZ0RDdk54cC9GSE93dklWSWJ6OEU3cjFVUDduT1d0?=
 =?utf-8?B?dnNFNlgwRUVsaS96THkvV0NwWkxOcnNRNVRUQkZrQTNZLzd5MEp6QnlSL3RJ?=
 =?utf-8?B?Rjh3UTN0M2pwdDhCdkFaWkVvU25QNHFoc28rRVdCTWczZEc4bVI4dHc4NXM0?=
 =?utf-8?B?Zzc3L0ZnTUFFcmlDNkVpYmpVbXljMzNwZTJ1bGlIZTdDWmdvRWtnQ3gxaDdv?=
 =?utf-8?B?VDAyS2ZwOHJsMEdLQlRLSmRUL0lEdkhwc0FFWFMyaHNsUWpnRllSU01vL0VF?=
 =?utf-8?B?RHBXODZDcnBiRHBYZXd2ajcvdHd4ZzV6QzhLRFkzVVB4cEgrbFZjUHlmMzd4?=
 =?utf-8?B?Vzc1VmRFVmYyWUwxTy80dDJxSHhwT1JINnNnNFBMNEl3aU9MR2ZvMnNsYmVL?=
 =?utf-8?B?QlIwQTd1WjdLbUVydjBNNE9qRE1yaDdhRm53WVRrK05mOTRvNnZxcXc0OERk?=
 =?utf-8?B?MnliVTdqOGQ3emRWOWxUekFYbXErbkhrUWRpUG5QRmtFTlZiYU1SOVRNSGFX?=
 =?utf-8?B?a1VwZDFJMmFHcTQ0dXNJQUtTZnVtNzJ1US9teStTTjA0UmU2V29nRUcyUFdv?=
 =?utf-8?B?V09KZjBDbk92Ym9mVmhpdzFHZnBWaTRuMmZMb0tjNnY1OUd6YTNLbWEycWlj?=
 =?utf-8?B?djBacS83b1N1aDNpdU84L0xZSXZHWmtmdlBMYjdDQ1IzaU91UWF0M0ZwbkJt?=
 =?utf-8?B?SVhwRm1QeTBWZnZwcTBoWk0yN1E3YTZCazZIQ1hZczV1UDJ3VVhacWtwVUhr?=
 =?utf-8?B?VkJhbzJwaTcxV29CMzRKUUd4Q3JDTEFUQTFoQ2lVRTNKNTlldmZ0d0xPdmlS?=
 =?utf-8?B?ZVVlekFaWks3MEdCV3N2YThrR3ZNUE1sTTRkaVlJWlFHcG9zUHkrN00xTjZp?=
 =?utf-8?B?dmlzOHBhTVpOVlRRaDFkU0Nzdkh5RlJ4YVZhaEhNbmIwbGFReEVrOEYwcnBT?=
 =?utf-8?B?enM1RzZrWmkwQXVhdCtjV3I3MmN5VXRqdkZaak45dW9iRXA1OUtZZ1hJYTBx?=
 =?utf-8?B?TW9DRXpaeThGQ01Jc24yWi91WUZpWW1Sb1djTS8vRjZmTEU5MmwwS0V5S2gw?=
 =?utf-8?B?UGpSZDNyUUx4OHBHajJGTlI5VDA0VzNUWnFGUHozaHdRTWZHdkRkOXU5Z0hx?=
 =?utf-8?B?b0tUcXdteTFaUGxYY2drbmdrQ2ZuVnBVTW9YZ3RVMEM5YWxPY1AzenczR0hm?=
 =?utf-8?B?ckdQa0xuelVxVko2V1VIRGN6c2RwM0NTZGh4RVFUMFhoTTAwcEMvVVQwbEVN?=
 =?utf-8?Q?m/BbkvdDHheV1gAtmqgJDhE4wwEbfsPY5uioZ21AzzBL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 732636f9-3cfb-4825-9040-08daa2470907
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 18:18:41.2026
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BLPgZRYhPcnNm3/UMIZs9dPD17e0WYCHQdcS3pt12CYaokOkaTctfVPsMiH7BTUz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5433
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 27.09.22 um 19:24 schrieb Arvind Yadav:
> Fence signaling must be enabled to make sure that
> the dma_fence_is_signaled_locked() function ever returns true.
> Since drivers and implementations sometimes mess this up,
> this ensures correct behaviour when DMABUF_DEBUG_ENABLE_SIGNALING
> is used during debugging.
> This should make any implementation bugs resulting in not
> signaled fences much more obvious.

Are all IGT tests now passing with this? That would be a bit unfortunate 
because it means we still have missed the bug in drm_syncobj.

Christian.

>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
> ---
>   include/linux/dma-fence.h | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index 775cdc0b4f24..5156dc6be0a6 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -398,6 +398,11 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence);
>   static inline bool
>   dma_fence_is_signaled_locked(struct dma_fence *fence)
>   {
> +#ifdef CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING
> +	if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
> +		return false;
> +#endif
> +
>   	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>   		return true;
>