Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52ed8ec2-bd90-ad40-fe85-83d60eda7e05@amd.com>
Date:   Fri, 30 Sep 2022 00:00:22 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH 3/3] dma-buf: Check status of enable-signaling bit on
 debug
Content-Language: en-US
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220927172409.484061-1-Arvind.Yadav@amd.com>
 <20220927172409.484061-4-Arvind.Yadav@amd.com>
 <59d4d647-f451-061c-79b5-0ffc4e33fc58@amd.com>
From:   "Yadav, Arvind" <arvyadav@amd.com>
In-Reply-To: <59d4d647-f451-061c-79b5-0ffc4e33fc58@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2pZZWtQWkFtWDhMOXpQeHBYWHIrRkJSelkyT2hiZUc0ZmVIUmFvZXpYVTFB?=
 =?utf-8?B?bDdIUHBKRkJ0U0krRy9VcjhCMXNKREhPbXF5WGhOdFgya0FxNWdoa3JTelVP?=
 =?utf-8?B?T2NkOWlBQ0FCYTFPSFAxZ0dHY05BZ2tJeWZLTUVHMFRJRks3cEJYdG5LMGZh?=
 =?utf-8?B?aS8wSytFUTdhd1BXQTU1K0NMMHhWQkZXbWJuZlJjS3dYK25pRlp6QVFkTHJG?=
 =?utf-8?B?OGtwLzFXMGtDZ3M2dzNJZ2RWR0hJQk9oMWkzL2NKd1lSZ1JkcnRBRS94TXZa?=
 =?utf-8?B?UzdPeGV0MjcwODhORlkvaWE0ak5DM3kyRkYzWGovS3hGbUhOQVV2aXlpanJP?=
 =?utf-8?B?YTZtMmtHSnBLY2x1Vmo2VkVpeVBtMzJBOUd4UXZzdHc2OWdrSEQ2N01MNVNi?=
 =?utf-8?B?bjdSL3J1Nk9jQ0ZlNHdIc1hLdHYwYXZEeGtnOWZaczFERWJ2TStmRURIZk53?=
 =?utf-8?B?b0xITUdFODlHQ0VHeGRhVmwvMDJXRnpGZEo4OCtUcno2bnF3VFh1UXZ3c25I?=
 =?utf-8?B?czhQdDJUdWplOGJUbzJRVnIyaUcvTzNnWXhVSlpIbVVGdUg3OEs2cEFYaVpR?=
 =?utf-8?B?cXV0S1M4c3BkZUFuUERtblFVbmtMRTJNNFZnR1JxY3JZOWpsYWpmZncyekRw?=
 =?utf-8?B?Z2hnQjB2TUdzRzNIUjNoOUFTZFN0MVJPamVRNVA4ZjJtejdQcU1TZVNNek91?=
 =?utf-8?B?STM4NzQ5RkdTVHlqSXRvaHhjbFFsQkNVblJ4eUl1Ky9HNktsbkRkWkV0VEhl?=
 =?utf-8?B?YXM3N3NqalFBcm54RnlPelVFVitxYkxjV2Q5SXdnc1NLTUxCTnpXc2QvcGhR?=
 =?utf-8?B?WkY3amNFMGl4dE9YQmo1ZEw5MDRVQ2M2MFM5OVIzYWM0MDh6NThrWUtPL25j?=
 =?utf-8?B?RHJVNzVQL0ZXbkM1SG9UOU1oUUtnYVZaNCtwbWhvL3lsVWsyZzBlUjgxVzJt?=
 =?utf-8?B?YXJaeEtnWmxRYVJBVnRCQVpHTE9Qd2lrRVhHWDBLNkU3dksvR3Q3RSt2aFZJ?=
 =?utf-8?B?Z2dMWGVnT005cktrLzhkbllUVXdVTFJwY2gxQVkzMU5zZHZkQ1ZxK3ZZTVkw?=
 =?utf-8?B?akpLSkpEaWxLd1czaldNQVZmVXRHTU5FREJKTVBvSWVIbVI5QkxyMzZwN2hj?=
 =?utf-8?B?VHl3eGt3d2RzM2hlcUczc2w3dklSUE5JVjhlaTRYWktuZkhtcm1FUWlvWVRx?=
 =?utf-8?B?STNqN1JBMGRwSXRqZ0F6ME1SZG10b2xKQ1c4eHgreks4ZkVCRlQzOGEvRERm?=
 =?utf-8?B?Nkt4TlZ0ZFRKZUg0a2dVbzBzMWFvd0ZieWZPUFJZdnIxWUtKYlZaS1hRMHhH?=
 =?utf-8?B?cjJaWVo0YmwwNkNiZm1YZ0ZtYWx0RlNGSVR1Z0ZlRk5UZGg3aU13S1BTb3FZ?=
 =?utf-8?B?RXg4Z2ZCWFdCSXpjODU0MXhUZE9FSXZmeW9NL0RybzV5MHVtY0R2cEVMYU85?=
 =?utf-8?B?ZTBpS0gxVlNCcUNMUmN4ekFoZTVrQ1hsem4xUlk3WGs2Tlh0K1A3QnBsYU1z?=
 =?utf-8?B?V3I4cTZTSXZ4TVhrQVRPMFkvWVF2cmFRSmlVd1BQYTVINndqZjlMWDMxa3Rz?=
 =?utf-8?B?WllvcEVyaW1UenVpaDVMWng0c05OMWpJWDY2OHROUzVSRWFDMWVQNmpYSDhv?=
 =?utf-8?B?UmFHZjBqRjlzL0tmZHY2ay9zcEg4U0xNL2lhVmdSWUN6N0hCZG5GbTVMQzNl?=
 =?utf-8?B?SmJyY3V1QjVUSVg1N2dpZjJqdmZRZXliTWZVMDZUOThJQ0tMOENIT2lBaHZQ?=
 =?utf-8?B?K3IrbUIxMlF4L2pCOVJnWkNQNkFDMFFoWENLbi93dEVCNkk3MGk5TlR4OThN?=
 =?utf-8?B?SEFXd0JCdHByam81TFliRXROUXM2dXhveitGMHoxN2hlM0NHOS9xemQrS1p1?=
 =?utf-8?B?UEVJcVY3RitmRHU5TmxCZGtQalE0eW1aR1V4ZU85Mkd3NUVZdHBOSTVJeXZt?=
 =?utf-8?B?Yk9tcnpqWTJqMElPeThjblZTZE94Y1I3dUpLSXhlVDVmdnljay9UOUtiRDN1?=
 =?utf-8?B?MCtpd055QllUazlxZ0x6S3dyN0V1WWFOOWVIbDNkMElvbC9WSFZLM0dUSXlH?=
 =?utf-8?B?SXlZcmE3QWpDL0tKMHlncGVOTkhnWXV4NW5nTTNZR2xYU2M0WEJOSDRiSmE1?=
 =?utf-8?Q?S2ESUV8ZeFTk5UKpCz+vnG0iA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b3e95d1-d180-4187-baff-08daa248b2ce
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5993.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 18:30:34.9146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uWPvjhRyII4YJcA9d+covSsXQ8vjUkOapF1lkmNkNkaSi3rDjov8ozXch/urleoYWHarqDYBBOuz4J9a1KOr2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4581
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/29/2022 11:48 PM, Christian König wrote:
> Am 27.09.22 um 19:24 schrieb Arvind Yadav:
>> Fence signaling must be enabled to make sure that
>> the dma_fence_is_signaled_locked() function ever returns true.
>> Since drivers and implementations sometimes mess this up,
>> this ensures correct behaviour when DMABUF_DEBUG_ENABLE_SIGNALING
>> is used during debugging.
>> This should make any implementation bugs resulting in not
>> signaled fences much more obvious.
>
> Are all IGT tests now passing with this? That would be a bit 
> unfortunate because it means we still have missed the bug in drm_syncobj.
>
IGT has these test cases related to syncobj (syncobj_basic, 
syncobj_timeline and syncobj_wait)and all are passing.

I will check syncobj and let you know.

~Arvind

> Christian.
>
>>
>> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
>> ---
>>   include/linux/dma-fence.h | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
>> index 775cdc0b4f24..5156dc6be0a6 100644
>> --- a/include/linux/dma-fence.h
>> +++ b/include/linux/dma-fence.h
>> @@ -398,6 +398,11 @@ void dma_fence_enable_sw_signaling(struct 
>> dma_fence *fence);
>>   static inline bool
>>   dma_fence_is_signaled_locked(struct dma_fence *fence)
>>   {
>> +#ifdef CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING
>> +    if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
>> +        return false;
>> +#endif
>> +
>>       if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>>           return true;
>