Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Sep 2022 16:16:39 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Will Chandler <wfc@wfchandler.org>
Cc:     John Garry <john.garry@huawei.com>, peterz@infradead.org,
        mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix empty version number when building
 outside of a git repo
Message-ID: <YzXvF1eIzJvAfe3U@kernel.org>
References: <20220927195228.47304-1-wfc@wfchandler.org>
 <c5181877-2998-b952-abe6-26d733ae2aeb@huawei.com>
 <87A1F5B6-3F60-4988-8BA6-A993E5789C80@wfchandler.org>
 <2a4a15a4-55cd-f98b-4b14-474f24e2c308@huawei.com>
 <B89DF3DD-B07E-427F-8D4B-1F8251345A4C@wfchandler.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B89DF3DD-B07E-427F-8D4B-1F8251345A4C@wfchandler.org>
Precedence: bulk

Em Thu, Sep 29, 2022 at 03:06:06PM -0400, Will Chandler escreveu:
> On 29 Sep 2022, at 6:09, John Garry wrote:
> 
> > Hmmm... maybe someone would want to customise PERF-VERSION-FILE for their own distro. Not sure. But then fiddling with PERF-VERSION-FILE might break the parsing so...I guess not.
> 
> Yeah, seems like a bad idea. Doing a quick search, Void Linux does seem to be
> trying to set a custom version string in their build script[0], but I don't
> think passing PERF_VERSION as an argument to make has worked since 2013 with
> 3cecaa200227 ("perf tools: Do not include PERF-VERSION-FILE to Makefile, 2013-01-16").
> 
> [0] https://github.com/void-linux/void-packages/blob/fdb3515c33f2bb997392ea6992e6bbb82c4376c5/srcpkgs/linux-tools/template#L56
> 
> > BTW, is there any other method of building the perf code not considered? So far I know:
> > a. in git tree
> > b. perf-tar-src-pkg
> > c. tarball
> 
> Those are all that come to mind for me as well.
> 
> Let me know if you'd like me to re-roll the patch using the pre-7572733b8499
> approach.

Discussion is going well, proceed, reach a conclusion and from what I'm
seeing, I'll just have to apply it 8-)

- Arnaldo