Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2635179rwb; Thu, 29 Sep 2022 12:51:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6PDBdm3YatpeuIL6enc/lWUkgN0qoRxWwi3ukW9lLRfwGnIirMVypYZ/t4O4PMpnKl3Y/p X-Received: by 2002:a05:6402:51cc:b0:454:c988:48f0 with SMTP id r12-20020a05640251cc00b00454c98848f0mr4736689edd.74.1664481104267; Thu, 29 Sep 2022 12:51:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664481104; cv=none; d=google.com; s=arc-20160816; b=a5hIIGl68f0QRy0rEaYHGmObNaOl5L0zSSOqEw3RW8e4P7yMBT7AKi/9pOmixcAC3h L73K9UyCvJklDH08pJoDJgOfAVz90FiEFls9m6T89lj0njNTpaDO0bMbGIWAC+VYHVeM 1T6mYgFS0wGAvD4neAKeNcL/MKNhMIHsBU5H4u99VyRhaXEOsu+i1pCMmgSCYiE0JuYo DtDZVs/fE3kK1rNSkO5i9sNw6Fp9mVQ+qFzQ+KejrcesvBxUoTobjeLLMBOQx2SYESwF XgVfu8qsZ7YtYaAnSKpK2GeclSZHYQSfhUHKeWpK6b7uxDa5mZUkwcUcgyVxaC6mLxb4 nhXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=5iKGShl7bHTQjRCpR3Rp6BaSwCatu+rb0Y5UgnU1eOI=; b=bqJKhM43vNkYBxtB3ru7O3iDQnKLwl2Oy6TIG3xiuhKCjKAwGj/17JrdrZzoZWo8Cl ybJSxP/bX7YzZHpK6AOH3dRMFRMACA5TXIxvG9m5fVnsKUBpUi+LUwVBlqtdQwXvbzBR aNo1ntA9+2KDJUucYyg60WedMIYmN7iBxCkVWzkeWlnXQx/z8lHQYirh1MPlqQ3vwTOl T3uexh0Gm6ZbHvI5mwo4ZF7l9v435jIxlWFwmoU7TK28LanDhcJhrS0wzU+n4GsY4QX/ ugsqkPJPBFsOtIJ0y77KTOQclq0JLyhvBkCoHQyWjFd2dQycFheEriWL+cpnDVTI0gw6 vbxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wfchandler.org header.s=fm2 header.b=bjrvUMZD; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=gCE1erlx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc32-20020a1709078a2000b007823edcf3dbsi104268ejc.19.2022.09.29.12.51.18; Thu, 29 Sep 2022 12:51:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@wfchandler.org header.s=fm2 header.b=bjrvUMZD; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=gCE1erlx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbiI2TGR (ORCPT + 99 others); Thu, 29 Sep 2022 15:06:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbiI2TGM (ORCPT ); Thu, 29 Sep 2022 15:06:12 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4EE54DB19; Thu, 29 Sep 2022 12:06:11 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CE9625C00DC; Thu, 29 Sep 2022 15:06:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 29 Sep 2022 15:06:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wfchandler.org; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664478368; x= 1664564768; bh=5iKGShl7bHTQjRCpR3Rp6BaSwCatu+rb0Y5UgnU1eOI=; b=b jrvUMZDt1YwJthfV0Qdg1pP8nZ4FmTK4O2Kgie1W59wAZQUOwbnInXX6+yDOV4Wi 320UZAirBa3MqnVZ2aE6Cb02FuoVzav5HWwTjLISFdgS40eKjTjc3Sh8n+0BgaNN oHTucHpyqZd8tjiYo79F+uUZiMXZM1xLELwLc1VstcU03zdUNydkMNd768X7F/F9 ZbBcSnVnb4zgeJFM5lbLDu56wCzeZjirQZlTa4fFfMwk1CCGPU9lOfinGWV6/ftZ fj0EpExYXPSN23eF+hvGiQEJulQX4h4ARbKPntyxJ3/Syz8vrRb4rygpv6M1OimM Nlmjowi7XwG0uUKgu0hqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664478368; x= 1664564768; bh=5iKGShl7bHTQjRCpR3Rp6BaSwCatu+rb0Y5UgnU1eOI=; b=g CE1erlxOgz9e/8NSesIGMjsGGtZKUSnx1P+eMftneMNUoN1Qy/4wFNdxptmx1A2e 3eCegl44ve78g7uqOtsr8qyd7VnuNPK521x6Ns1cgNZp9AKfqqNyx1/UBoQVZ3xT pnXXMAYzzyjflS/hw5GQWjAstMl/fSLYe2hTsrOkUXYgd7BRoavZ1WAWHkIrfpfV yLB2gU/No/AjG68I2RHg8wTaLevQmiiCeWWBbCf6SsyoZGzby+I32TjQfP2boxJY azykm7zKS2k0ivVqTvT5bKXvZT946ygpBd0jSAgvQgBrEps5m2NXcmxNMYakSaTo KkR+Ee9CKCs17F5HlxNcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehtddgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffoffkjghfgggtgfesthhqmhdtredttdenucfhrhhomhephghi lhhlucevhhgrnhgulhgvrhcuoeiffhgtseiffhgthhgrnhgulhgvrhdrohhrgheqnecugg ftrfgrthhtvghrnhepgfeuvdduudfftdfgkedtffehkeeuhefhtdehtdfgkefhveehkeej geeuhfeugffhnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiffhgtseiffhgthhgrnhgulhgv rhdrohhrgh X-ME-Proxy: Feedback-ID: ica594744:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 15:06:07 -0400 (EDT) From: Will Chandler To: John Garry Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix empty version number when building outside of a git repo Date: Thu, 29 Sep 2022 15:06:06 -0400 X-Mailer: MailMate (1.14r5852) Message-ID: In-Reply-To: <2a4a15a4-55cd-f98b-4b14-474f24e2c308@huawei.com> References: <20220927195228.47304-1-wfc@wfchandler.org> <87A1F5B6-3F60-4988-8BA6-A993E5789C80@wfchandler.org> <2a4a15a4-55cd-f98b-4b14-474f24e2c308@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29 Sep 2022, at 6:09, John Garry wrote: > Hmmm... maybe someone would want to customise PERF-VERSION-FILE for the= ir own distro. Not sure. But then fiddling with PERF-VERSION-FILE might b= reak the parsing so...I guess not. Yeah, seems like a bad idea. Doing a quick search, Void Linux does seem t= o be trying to set a custom version string in their build script[0], but I don= 't think passing PERF_VERSION as an argument to make has worked since 2013 w= ith 3cecaa200227 ("perf tools: Do not include PERF-VERSION-FILE to Makefile, = 2013-01-16"). [0] https://github.com/void-linux/void-packages/blob/fdb3515c33f2bb997392= ea6992e6bbb82c4376c5/srcpkgs/linux-tools/template#L56 > BTW, is there any other method of building the perf code not considered= ? So far I know: > a. in git tree > b. perf-tar-src-pkg > c. tarball Those are all that come to mind for me as well. Let me know if you'd like me to re-roll the patch using the pre-7572733b8= 499 approach.