Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c6a4363f-efa5-febe-a38c-c172019c1903@gmail.com>
Date:   Thu, 29 Sep 2022 22:30:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC PATCH v2 0/4] staging: vt6655: Implement allocation failure
 handling
Content-Language: en-US
To:     Nam Cao <namcaov@gmail.com>, forest@alittletooquiet.net,
        gregkh@linuxfoundation.org, dan.carpenter@oracle.com
Cc:     linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
References: <cover.1664384503.git.namcaov@gmail.com>
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <cover.1664384503.git.namcaov@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/28/22 19:21, Nam Cao wrote:
> This driver does not handle allocation failure when receiving data very
> well. This patchset implements better handling in the case of allocation
> failure.
> 
> Also do some necessary clean-up to implement this.
> 
> v2:
>    - squash 3 commits that were doing a single thing
>    - add new commit which removes a redundant assignment
>    - take device_init_rx_desc() out of unnecessary else condition.
>    - remove return statement at the end of void function
>    - add a missing rd = rd->next statement in device_rx_srv(): because
>      we already drop the current buffer, we should move on to the next
>      buffer in the ring where new data will be written to.
> 
> Nam Cao (4):
>    staging: vt6655: remove redundant if condition
>    staging: vt6655: change vnt_receive_frame return type to void
>    staging: vt6655: remove redundant assignment
>    staging: vt6655: implement allocation failure handling
> 
>   drivers/staging/vt6655/device_main.c | 40 +++++++++++++++++-----------
>   drivers/staging/vt6655/dpc.c         |  8 +++---
>   drivers/staging/vt6655/dpc.h         |  2 +-
>   3 files changed, 28 insertions(+), 22 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>