Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754052AbXFWUF4 (ORCPT ); Sat, 23 Jun 2007 16:05:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751412AbXFWUFs (ORCPT ); Sat, 23 Jun 2007 16:05:48 -0400 Received: from relay.2ka.mipt.ru ([194.85.82.65]:39445 "EHLO 2ka.mipt.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbXFWUFr (ORCPT ); Sat, 23 Jun 2007 16:05:47 -0400 Date: Sun, 24 Jun 2007 00:05:07 +0400 From: Evgeniy Polyakov To: Andrew Morton Cc: spock@gentoo.org, linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] fbdev: add connector entries for uvesafb Message-ID: <20070623200507.GA29496@2ka.mipt.ru> References: <20070623105146.GC12623@spock.one.pl> <20070623110627.c911373c.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20070623110627.c911373c.akpm@linux-foundation.org> User-Agent: Mutt/1.5.9i X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (2ka.mipt.ru [0.0.0.0]); Sun, 24 Jun 2007 00:05:12 +0400 (MSD) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1837 Lines: 58 On Sat, Jun 23, 2007 at 11:06:27AM -0700, Andrew Morton (akpm@linux-foundation.org) wrote: > On Sat, 23 Jun 2007 12:51:46 +0200 Michal Januszewski wrote: > > > Add connector's idx and val constants for v86d and uvesafb. > > > > Also change the maximum message size to 4k to allow transfers of VBE > > data blocks from userspace. > > > > Signed-off-by: Michal Januszewski > > --- > > include/linux/connector.h | 7 ++++--- > > 1 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/connector.h b/include/linux/connector.h > > index 10eb56b..46b2aba 100644 > > --- a/include/linux/connector.h > > +++ b/include/linux/connector.h > > @@ -36,14 +36,15 @@ > > #define CN_VAL_CIFS 0x1 > > #define CN_W1_IDX 0x3 /* w1 communication */ > > #define CN_W1_VAL 0x1 > > +#define CN_IDX_V86D 0x4 > > +#define CN_VAL_V86D_UVESAFB 0x1 > > > > - > > -#define CN_NETLINK_USERS 4 > > +#define CN_NETLINK_USERS 5 > > > > /* > > * Maximum connector's message size. > > */ > > -#define CONNECTOR_MAX_MSG_SIZE 1024 > > +#define CONNECTOR_MAX_MSG_SIZE 4096 > > > > /* > > * idx and val are unique identifiers which > > > > > > Evgeniy, could you please review this? > > The need to add these enumerations for unrelated subsystems to connector.h > may get a bit ugly as time passes, but I guess it's OK for now. Hi. I have no problem with the patch, although it could be possible to split patch to two - add id and increase the size, but it is too minor nit. Ack. -- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/