Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <651530a9-2dc1-c781-a1b5-1e712684f94d@infradead.org>
Date:   Thu, 29 Sep 2022 14:36:34 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'
Content-Language: en-US
To:     Xin Hao <xhao@linux.alibaba.com>, namit@vmware.com
Cc:     tglx@linutronix.de, peterz@infradead.org, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20220929091040.45390-1-xhao@linux.alibaba.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220929091040.45390-1-xhao@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

I would say let's fix the sentence grammar, but I don't know
what "cleared set" means.


On 9/29/22 02:10, Xin Hao wrote:
> Just correct the wrong word 'clleared' to 'cleared'
> 
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
> ---
>  arch/x86/include/asm/tlbflush.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index cda3118f3b27..c80a15ef0cbc 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
>  		diff &= ~_PAGE_ACCESSED;
> 
>  	/*
> -	 * Did any of the 'flush_on_clear' flags was clleared set from between
> +	 * Did any of the 'flush_on_clear' flags was cleared set from between

It should be more like:

	 * Were any of the 'flush_on_clear' flags changed between

X86 people, does that make sense to you?


>  	 * 'oldflags' and 'newflags'?
>  	 */
>  	if (diff & oldflags & flush_on_clear)
> --
> 2.31.0

-- 
~Randy