Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f2778291-38a8-457f-d61e-0f9f7d401075@oracle.com>
Date:   Thu, 29 Sep 2022 16:15:26 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH] locking/rwsem: Prevent non-first waiter from spinning in
 down_write() slowpath
Content-Language: en-US
To:     Waiman Long <longman@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Boqun Feng <boqun.feng@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Hillf Danton <hdanton@sina.com>,
        Mukesh Ojha <quic_mojha@quicinc.com>,
        John Donnelly <john.p.donnelly@oracle.com>
References: <20220929180413.107374-1-longman@redhat.com>
From:   John Donnelly <john.p.donnelly@oracle.com>
In-Reply-To: <20220929180413.107374-1-longman@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2dHWUtTRGlOZWNMOC9hNnBDa3VXOWo4Tlo2OXJwakRjNUZVVUcvZ3YwNTky?=
 =?utf-8?B?V1NEVkE3NnlpR21HWU1vZEpQUERnKzI3TXpvWWUzb2RFdUp2WEZLaHZSS3hX?=
 =?utf-8?B?OEpkUjJPSVI3OXVIRkxEa1NqU3ZlNm92VEVnUCs3dFVxb0g1Kys0L1ZPREFs?=
 =?utf-8?B?NDJQTmJ4UUtlVm40SHkrMjdHSGdES0o0Rm9mTXg3K3lHWjBGQ0lCT3pYM3hQ?=
 =?utf-8?B?Z2tYTEJnK2d5TXdrK2JPUG1Xc1RRYm56b09kdVZkMDhOS1ZIcExLcGR3STFo?=
 =?utf-8?B?TzBxY3NDVzhYSXpkOHBwOGtlYTl6R1gzUDFaeGw1L1ZnWjJuTkpHbEVvUngr?=
 =?utf-8?B?SjBKK3VVQmN0MkovUGdNOVlJVlNsMS9nSzBxUWdheHlVb3hrSWFuZThLWXI2?=
 =?utf-8?B?ZkJNM0MxbWFjZmNoVHM2bGdBNHFBZlcvN29jQzNPdGZoYTRGaGwyZmpFTWtM?=
 =?utf-8?B?aHFkKy8xUE5sQ0tYaTBKeVZOQmh0OGtBODZTa1ZvTmJ4aDBHRFlpd1U4K09r?=
 =?utf-8?B?VFRGNTVSOUNIN2dFZS9IQWludDE4eHgyZGo0L0N0MUJ3NTFFcjFDN3B1QnVM?=
 =?utf-8?B?L0hUVzkrL3pLOFhVOEtsWlZTZlRQMjQ3dmlBVk9CWTJzSDNpbCtneU5qYlpl?=
 =?utf-8?B?QWMrbEl5SzdTVUZ5eXVGYzNlclp3dVNuVEV3UkN5OUNRT3lTV1NvNURuMGx1?=
 =?utf-8?B?UlNNclh1ZE8wajhDcERheml6Ti8wNTlDaFRNOHhCVlBicWlPV2dBN1p5TTVn?=
 =?utf-8?B?Y2RBT2lUQi9vZ05ZcjN2bDh3ZGh6Y1l0azAyRVVmckNtaWI3c05SajlodTFS?=
 =?utf-8?B?K0JWR01UK0dFVTI3VmNmZnkvZVZXVWNISHRlWXQ5TG12SVRKYXk2NUpuMTJh?=
 =?utf-8?B?bzZSSkRmL3MzSmw2TmZVYTFUa1lXNW0vbE1kUi9weGxiYWJySkx4SWhISDJo?=
 =?utf-8?B?cXFjWjAvREh3TUEvVVdkNXRoOHFPUk9Od09RVEozYWdYZkpNVGZpSTdiMkFi?=
 =?utf-8?B?S0NlSVd5aEVVTFphZWc5bWJEbjVmcE1BSS9VcTdyR281KzZwWTZiS1RSamFN?=
 =?utf-8?B?cFdqNGtySFlteXVzaU1NMWcvZkFMVDdnbWgrekZsL21PUHlHODMxYlJTN245?=
 =?utf-8?B?MEJMUFJFU1E1L0RIR1Urdys5UTBrbTlMOXp4WGFsNkFpazJQa2ZZaUxUaUpU?=
 =?utf-8?B?cnVTMVNiV0g1VHJsWDRoa1hQN0EvdlY5OVBJa3lpK0VYblNZdnMrdXN0NVMw?=
 =?utf-8?B?dHZIVFpCcVV0UnB4ZE96OGhSeXo2eUk2ZXM4eU9YRnRoVDl1ZzB5dVIyZTRG?=
 =?utf-8?B?K3hUUndieEJ0ZGpZeVdnS3dtRkFJNFJLbG1LcE9SN2doSzNuZkVHUWc5KzQ1?=
 =?utf-8?B?UDNtWWZiOTYvbDBER01qRmFGYjl5RGZwT0hHUkRNU3g0N0FYRVArY2Y1MFFr?=
 =?utf-8?B?Y3J0ZjBYM0taRzJvL291RSttVGVWYU9RU1FZYlJGZlpTb0FjK2hvRmV3bHBV?=
 =?utf-8?B?NUdpeEFqVys5MExHR09kaE00WTd6ZUh2S1BIcGlxODZIeW9mcURMMVRveEN4?=
 =?utf-8?B?MHdnVkVuQXBmUHcrWWE0YnJ2OFArQi9MVkQ0M2NBam43R0FpZUpXaHpuMFRB?=
 =?utf-8?B?b3hXZzBrV2F0bWVQWTlHeEsxUnVEbVRpbnR0NlU2Ui9PMTlKbnliMUF1ZzVV?=
 =?utf-8?B?L3lMTkFBMTVvVElmZS9FcU80TlFuVmhqbTV5N1lWUjBVSTJXb1o1T1F3SUdD?=
 =?utf-8?B?NGJkN1VGMWNVaC9MeStOa0FEdTNvd2VBWmtzbjJhVWMvdGVHckhWVjM4NU9Q?=
 =?utf-8?B?ZmEwbkt6WStaRlo3d1FpZGdxNkREMG4wZXBpeXJvTmd3QWhHM29leWlhNGJv?=
 =?utf-8?B?LzBXRzhSODExbmVWeDdiYzlySzVLcjFGUWFNcXgyUi9vQU80MThmQ2JJejMz?=
 =?utf-8?B?ZjErU1VPcnNzamlYaklVUlVwOWVoblREbERlUXNQQXJSU0hBRWZVU25sQ2cr?=
 =?utf-8?B?MXNSTFpDS0Z3dlM0U3JtdXFNOXJvQXNESXZJK2lRQ01oaGtVejRtMENaenZa?=
 =?utf-8?B?Z1dJZVZjMFNsU1RZZjJJN2tKZzB5b0piVmphYXk5c1V0T3dhaUZrZzBNNDVU?=
 =?utf-8?B?ZDI1bXhndWZ3Z1dTdVRHYUJSeGlicW5ERTg0WmNJSGM0YjU5WHhBQnoydmZT?=
 =?utf-8?B?d2c9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2547aa02-0223-46cf-c171-08daa25fbcc1
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 21:15:30.0316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1mzvOGbSiazAkDa8VeeHcOCB7zkRVb7wkRQcBdzUOUMxZFVlb1FEJ2QBtejT3eH3LrxWu01QTjz1FHyetmseyFCVgeFKjjt4v2jDP1SG3fE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5931
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-29_13,2022-09-29_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 mlxscore=0 mlxlogscore=990 adultscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209290134
X-Proofpoint-GUID: a_tElrLNLHcTX0E0Jt95BNCtfHaiirEL
X-Proofpoint-ORIG-GUID: a_tElrLNLHcTX0E0Jt95BNCtfHaiirEL
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/29/22 13:04, Waiman Long wrote:
> A non-first waiter can potentially spin in the for loop of
> rwsem_down_write_slowpath() without sleeping but fail to acquire the
> lock even if the rwsem is free if the following sequence happens:
> 
>    Non-first waiter       First waiter      Lock holder
>    ----------------       ------------      -----------
>    Acquire wait_lock
>    rwsem_try_write_lock():
>      Set handoff bit if RT or
>        wait too long
>      Set waiter->handoff_set
>    Release wait_lock
>                           Acquire wait_lock
>                           Inherit waiter->handoff_set
>                           Release wait_lock
> 					   Clear owner
>                                             Release lock
>    if (waiter.handoff_set) {
>      rwsem_spin_on_owner(();
>      if (OWNER_NULL)
>        goto trylock_again;
>    }
>    trylock_again:
>    Acquire wait_lock
>    rwsem_try_write_lock():
>       if (first->handoff_set && (waiter != first))
>       	return false;
>    Release wait_lock
> 
> It is especially problematic if the non-first waiter is an RT task and
> it is running on the same CPU as the first waiter as this can lead to
> live lock.
> 
> Fixes: d257cc8cb8d5 ("locking/rwsem: Make handoff bit handling more consistent")
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
>   kernel/locking/rwsem.c | 13 ++++++++++---
>   1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c
> index 65f0262f635e..ad676e99e0b3 100644
> --- a/kernel/locking/rwsem.c
> +++ b/kernel/locking/rwsem.c
> @@ -628,6 +628,11 @@ static inline bool rwsem_try_write_lock(struct rw_semaphore *sem,
>   		new = count;
>   
>   		if (count & RWSEM_LOCK_MASK) {
> +			/*
> +			 * A waiter (first or not) can set the handoff bit
> +			 * if it is an RT task or wait in the wait queue
> +			 * for too long.
> +			 */
>   			if (has_handoff || (!rt_task(waiter->task) &&
>   					    !time_after(jiffies, waiter->timeout)))
>   				return false;
> @@ -643,11 +648,13 @@ static inline bool rwsem_try_write_lock(struct rw_semaphore *sem,
>   	} while (!atomic_long_try_cmpxchg_acquire(&sem->count, &count, new));
>   
>   	/*
> -	 * We have either acquired the lock with handoff bit cleared or
> -	 * set the handoff bit.
> +	 * We have either acquired the lock with handoff bit cleared or set
> +	 * the handoff bit. Only the first waiter can have its handoff_set
> +	 * set here to enable optimistic spinning in slowpath loop.
>   	 */
>   	if (new & RWSEM_FLAG_HANDOFF) {
> -		waiter->handoff_set = true;
> +		if (waiter == first)
> +			waiter->handoff_set = true;
>   		lockevent_inc(rwsem_wlock_handoff);
>   		return false;
>   	}
Hi,.

Are you missing


[PATCH 5.18 87/88] locking/rwsem: Allow slowpath writer to ignore 
handoff bit if not set by first waiter


Fixes: d257cc8cb8d5 ("locking/rwsem: Make handoff bit handling more 
consistent")

Or is this another regression ?