Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71ca01ad-e563-3ac3-815d-0bbc3814ed6f@intel.com>
Date:   Thu, 29 Sep 2022 15:10:25 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.3.0
Subject: Re: [PATCH v5 12/12] Documentation/x86: Update resctrl_ui.rst for new
 features
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>
References: <166431016617.373387.1968875281081252467.stgit@bmoger-ubuntu>
 <166431042060.373387.8454967155095795574.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <166431042060.373387.8454967155095795574.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUFnR0l6MWJtc0xQUnFVZ3JYeUY3ODV0UTVnOEYyYjNoOU0wMG42bjI0TDJ1?=
 =?utf-8?B?NEJwYWhmTGx2Ny9VWWwwdkZPN1pNYWtkVnpyZForRmErQ0l2aWJmSjI3Mmwx?=
 =?utf-8?B?eGlTT3FMd1hoUXc4VnFTMXpvY01qRVJXaWVPS2VMSjF3RmJRbWl6dGN3SnMw?=
 =?utf-8?B?bFVCUDNEZTVjWkJ6d0oxT1lEU2VRTnRzcG4vQXNqMjk1OERrMTQ5cWJLajha?=
 =?utf-8?B?RXJWWEVjV2VjNW4xZGdEZ3BjaVJrNkNpZ3F6WG9hSzFLRXhubVEyQnNRdGxS?=
 =?utf-8?B?NzlTK1pFcWJDWHFURG1vMVFKV2pKcnpZVEI1VFlFYmhTM2VaYm1pcnd0WGF0?=
 =?utf-8?B?MExhZm5WdGEyaVZxVXZiYm9mOEJ1TVd5dXhVckw4Q2FGa1BtendWZjdMWE5p?=
 =?utf-8?B?MzBOV05tcS9MbFRseVV0WkF4UnV1M2lINU9vZzF0ZmQxWGwybEYzWVlvbDlQ?=
 =?utf-8?B?dUFCdkhYVmdqVkJHa1ZpYmUvVnFhNTFJTUVHNk1meHBmb3F0U3hMNmVyVmhM?=
 =?utf-8?B?ZEx5eXlKMHFEWlpFTHhIMGZjZktlYmlRcnlmci9nZkR3aHBmTTYycnFDbmY2?=
 =?utf-8?B?d2ZYNFpqUzU0ZW1kRzhEQWRMZW85SXNON2RxTmphYnV1L3p6aUZFU3orTHFv?=
 =?utf-8?B?alZtMWVZelFMNFBVZGtlam9SUDVra0VJeS9jUmlwbXdLUVRVOVdKWklkM0tF?=
 =?utf-8?B?TzBCa1BOa1NTSGtxVlRRVDR5Vmd6TEZLa2hDaVJrTnlvUjFjTS8rdnpqa0lJ?=
 =?utf-8?B?SElDYS94Q1hRK0c3ajRKc0VnS1ZpaTJVTmVRT2hlZDRXOTN1eG4yQ294QUJp?=
 =?utf-8?B?OHdac3YzTDdsN3BJVncwK2JRTmd5TFVvelkxVkE2MGlNSTZ5NWVPNHZIS281?=
 =?utf-8?B?UVY4U2p0cjk0UmR1ZG9tNnRsVEZZa3B2Z2tJODhyYTNPdzZocHpOUUsrekpJ?=
 =?utf-8?B?T1VUVlM4Tk9ORWlNcUNlcmV6a01NeUsvOVNVa2YxZFc2YzhpTlhSamd4cmJa?=
 =?utf-8?B?ZTdNbzY2MEJYclZIU2t4YVZvbmdjRm5GVExZc3NxWWJ0cmxQSG9JU0x5eTNi?=
 =?utf-8?B?eWJWRmh3SmQxNVpRbms3VzJ2VXVUTndFdy90THFCdFNZbHh3dVRMTEszWmVr?=
 =?utf-8?B?TmVMUUVLZENiZEliY0xxRWx4NzV3WEQrRENSSlRaZHFjYWNGcDlMVkE4K0Nw?=
 =?utf-8?B?S1NLa29pa2Q5YnNiREVOd09mOXBvRWdhNDhGaUgwVTFxeTZXbnVUbDU1UWtS?=
 =?utf-8?B?bzZUQWcxQjBhMkhRRlpsWnhpcHQrRkZXT2lvQXdTL0Rmbi9lbHZMQW43cXY0?=
 =?utf-8?B?eU5XZC9XZUZHVlU0NUFkakpuTWtWSjNHQjVJamp6S21YbGN0RXlsOExmRFhS?=
 =?utf-8?B?bDJYa2tZMnJQOUNlbWdocHk1cW9aU1g5SGJBTkpjNmpmajJ4bXJWZkp6YXpq?=
 =?utf-8?B?RXZKdkNyVHBXMFFvdGlrSHArdGNaQUFXZHFiNGE2QmtoWkFPUW5pR21URW9M?=
 =?utf-8?B?M2VESGFuTXVEeTFtZysrSTY4TUpiNTdFVFNDZytkN3N5ODJoT1RHMmpBdWlh?=
 =?utf-8?B?K3VIYWkyc0hhWUNKTVM2WmlPZzNYNVJhczgvNm9vUnUrdEhFZGp2Q1IvU01K?=
 =?utf-8?B?UVV4bjdNNk9BSW9YelZ6SkxsZUMxTEJySmVIdVBhUnF2L2pJclU0QnI3NjlS?=
 =?utf-8?B?eHdoSWtYLzN4ODFwUU40SWNkN3VZb29oWk9tQzZWdlhwY2tiYUwxQ093THQz?=
 =?utf-8?B?UER4UDZ2NVJDaGljdjFoU01zOXhZOWgrZW1IUnVsRW9waDQ0N0dlNnBOVXhi?=
 =?utf-8?B?V0NXaUw4Smx5b2YvbUg4di80RXU2YThmcEhBcjBId0YzTnkrRkJmY1pGVk95?=
 =?utf-8?B?RzNBYlFGNFFwNHczS0ZBOFY4T1NKa0Q3WWZ6ZmV5aXd6MzEvbnZMdDVSOHRP?=
 =?utf-8?B?K2xhSGdqUkFKcm9zaTFWMXAyU3VpVmZ6UVVzK1FWbzRIWjdrM3FMYXFESDda?=
 =?utf-8?B?N3ZZUGZrN1ZiamxWR0t6d296MkNRVTU2amJTSW14Y3hZdVVEeVM5VFYwYXNt?=
 =?utf-8?B?clBWRm1rY0VKMEZ4a2lScEpaaTIySjRvakRkVWFpUTZVNnpyV3B3UUJvclg5?=
 =?utf-8?B?U2JxcjNsSzBQMDdVNlcvdjErQnI4NmpXT1lqWlNQejBEdk9WMXpaeXdNWXJq?=
 =?utf-8?B?NWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3277aceb-d0c8-4be2-4c5e-08daa2676f42
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 22:10:36.1418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h/Ub8i4AlwUAohwdKPN8jYvJbyYpVlY9ABiF18u6EhNYHx7PmvT2WtNVMFtt+2O5whAW6xkoDOj1XdW6LMMtliQdvdHAKLzIkl74K9skfCM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6122
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

In subject: resctrl_ui.rst -> resctrl.rst

On 9/27/2022 1:27 PM, Babu Moger wrote:
> Update the documentation for the new features:
> 1. Slow Memory Bandwidth allocation (SMBA).
>    With this feature, the QOS  enforcement policies can be applied
>    to the external slow memory connected to the host. QOS enforcement
>    is accomplished by assigning a Class Of Service (COS) to a processor
>    and specifying allocations or limits for that COS for each resource
>    to be allocated.
> 
> 2. Bandwidth Monitoring Event Configuration (BMEC).
>    The bandwidth monitoring events mbm_total_bytes and mbm_local_bytes
>    are set to count all the total and local reads/writes respectively.
>    With the introduction of slow memory, the two counters are not
>    enough to count all the different types are memory events. With the

types are memory events -> types of memory events?

>    feature BMEC, the users have the option to configure mbm_total_bytes
>    and mbm_local_bytes to count the specific type of events.
> 
> Also add configuration instructions with examples.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

...

> +
> +"mbm_total_config", "mbm_local_config":
> +        These files contain the current event configuration for the events
> +        mbm_total_bytes and mbm_local_bytes, respectively, when the
> +        Bandwidth Monitoring Event Configuration (BMEC) feature is supported.
> +        The event configuration settings are domain specific. Changing the
> +        configuration on one CPU in a domain would affect the whole domain.

This contradicts the implementation done in this series where the
configuration is changed on every CPU in the domain.

Reinette