Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Eric W. Biederman" <ebiederm@xmission.com>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Kees Cook <keescook@chromium.org>, linux-mm@kvack.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220929203903.9475-1-lukas.bulwahn@gmail.com>
Date:   Thu, 29 Sep 2022 17:17:28 -0500
In-Reply-To: <20220929203903.9475-1-lukas.bulwahn@gmail.com> (Lukas Bulwahn's
        message of "Thu, 29 Sep 2022 22:39:03 +0200")
Message-ID: <87tu4p3jwn.fsf@email.froward.int.ebiederm.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct
Precedence: bulk

Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:

> With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
> use of the special taso flag for alpha architectures in the linux_binprm
> struct is gone.
>
> Remove the definition of taso in the linux_binprm struct.
>
> No functional change.

Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>

Alphas binfmt_loader is the only use I can find of that variable
so let's kill it as well.

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Kees, please pick this patch on top of the commit above.
>
>  include/linux/binfmts.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index 3dc20c4f394c..8d51f69f9f5e 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -43,9 +43,6 @@ struct linux_binprm {
>  		 * original userspace.
>  		 */
>  		point_of_no_return:1;
> -#ifdef __alpha__
> -	unsigned int taso:1;
> -#endif
>  	struct file *executable; /* Executable to pass to the interpreter */
>  	struct file *interpreter;
>  	struct file *file;