Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b744304-a1a2-f75e-dfc5-784961825a7a@infradead.org>
Date:   Thu, 29 Sep 2022 16:44:15 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'
Content-Language: en-US
To:     Nadav Amit <namit@vmware.com>
Cc:     Xin Hao <xhao@linux.alibaba.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220929091040.45390-1-xhao@linux.alibaba.com>
 <651530a9-2dc1-c781-a1b5-1e712684f94d@infradead.org>
 <FD6D2974-13DD-4FE6-B175-E0BBF5306BD8@vmware.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <FD6D2974-13DD-4FE6-B175-E0BBF5306BD8@vmware.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 9/29/22 15:58, Nadav Amit wrote:
> On Sep 29, 2022, at 2:36 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> ⚠ External Email
>>
>> Hi--
>>
>> I would say let's fix the sentence grammar, but I don't know
>> what "cleared set" means.
>>
>>
>> On 9/29/22 02:10, Xin Hao wrote:
>>> Just correct the wrong word 'clleared' to 'cleared'
>>>
>>> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
>>> ---
>>> arch/x86/include/asm/tlbflush.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
>>> index cda3118f3b27..c80a15ef0cbc 100644
>>> --- a/arch/x86/include/asm/tlbflush.h
>>> +++ b/arch/x86/include/asm/tlbflush.h
>>> @@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
>>>              diff &= ~_PAGE_ACCESSED;
>>>
>>>      /*
>>> -      * Did any of the 'flush_on_clear' flags was clleared set from between
>>> +      * Did any of the 'flush_on_clear' flags was cleared set from between
>>
>> It should be more like:
>>
>>         * Were any of the 'flush_on_clear' flags changed between
>>
>> X86 people, does that make sense to you?
> 
> It’s not a test whether the flags are changed, but whether they are cleared.
> 
> Let’s see if we can make it clearer with shorter sentences. How about:
> “Consider the ‘flush_on_clear’ flags that are set on ‘oldflags’; Flush if
> any of these flags is cleared on ’newflags’”.
> 

Sounds good. Thanks for your help.

-- 
~Randy