Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220903224125.2276690-1-floridsleeves@gmail.com>
References: <20220903224125.2276690-1-floridsleeves@gmail.com>
Subject: Re: [PATCH v2] drivers/clk/clk: check return value of clk_pm_runtime_get()
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     mturquette@baylibre.com, Li Zhong <floridsleeves@gmail.com>
To:     Li Zhong <floridsleeves@gmail.com>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 29 Sep 2022 17:27:26 -0700
User-Agent: alot/0.10
Message-Id: <20220930002728.3A3C0C433C1@smtp.kernel.org>
Precedence: bulk

Quoting Li Zhong (2022-09-03 15:41:25)
> clk_pm_runtime_get() could fail. Check the return status.
>=20
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
>  drivers/clk/clk.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 7fc191c15507..09353f7bf052 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2981,8 +2981,12 @@ static void clk_summary_show_subtree(struct seq_fi=
le *s, struct clk_core *c,
>                                      int level)
>  {
>         struct clk_core *child;
> +       int ret;
> +   =20
> +    ret =3D clk_pm_runtime_get(c);
> +    if (ret)
> +        return;
> =20
> -       clk_pm_runtime_get(c);

The patch is malformed. It can't be applied, sorry. Also, shouldn't we
print something if we can't runtime PM get?

>         clk_summary_show_one(s, c, level);
>         clk_pm_runtime_put(c);
>