Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2936840rwb; Thu, 29 Sep 2022 17:51:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM48mrx5oQ9ayHyBrP0kjyllie433wZjJ2CS0J7QRfIbN/FNolnC+TLtmb+R3PY8pas3pJ8g X-Received: by 2002:a17:90b:3505:b0:203:b7b1:2bc3 with SMTP id ls5-20020a17090b350500b00203b7b12bc3mr19531651pjb.242.1664499116275; Thu, 29 Sep 2022 17:51:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664499116; cv=none; d=google.com; s=arc-20160816; b=NUHO6kJH6pkrhuNHWKbH2ALOuprHhSPACosqxJe2xasGsAzryYxlt0RiuK0G90IaI3 N8sB/1KHb6nx0kYNj+qfK5ZUZePB9QoMSO5B6UWbWzPcaEbl3RkNf/23AYp9TP+TARBl lXH/OkEL1Kr4CAkvCvdOg4pKwTrJRS7PYcp5qBzDsQjp3N2m3g+/3AdMK7b2BDXiB/jh HFYQTImXK85bvRRk+4gCSZla/ZcyHnQXYtmF2K2a/BQD2c3778T9O/ZNIsdIqnGDcCnW zjiOaQxeLVoAm6Eh8RCATLUZuYsZlZe4Zng9YVqligEfEq0r3Q6KRDi3WbUkQBrRloR5 yIZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9+rkXcFrseZHs03+4sVY/LTCCHr+aUxxVRKhIt6Ih5I=; b=q2sKPBo62m0oqVUmQbh4IBZtm29ANaAVlrmDDhnHzlIqG01R7DrjqJ11zOzrvbAkrn uajWtG75dH5SN5g6FreWmXqXHjDQfa74zn60Md0otsGSBN69dBW8yUzz13fahkxixKdS K2U/kn3sEuzZLp7IOLeMbMVIxfIUmvgo9GUi2OrYvrDiMaMWc0WShjrwWnR8OA32PjWP nqBQe3/jSeCLVnIkvANu135dAFCe3Y+ahum8zrGTlJ3PUo3NbvIeAkfQA/+4wYiESsRU 92P/lZhNbyu2jt7n8Jf4ZqU0g2QxtYnox2FKVTI8a6SZcyAIP3YF/6GgpSaef+NuO+ry ntYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vKf3xd2w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k13-20020a170902c40d00b001754bd1f7dasi1552337plk.194.2022.09.29.17.51.44; Thu, 29 Sep 2022 17:51:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vKf3xd2w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbiI3Aul (ORCPT + 99 others); Thu, 29 Sep 2022 20:50:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229906AbiI3Au1 (ORCPT ); Thu, 29 Sep 2022 20:50:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6DAB5AA0D for ; Thu, 29 Sep 2022 17:50:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D2E31B826C9 for ; Fri, 30 Sep 2022 00:50:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57F24C433C1; Fri, 30 Sep 2022 00:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664499020; bh=1iKgq57jI+UOl7K/jTlEvdXh17z6ctGT+qZUxoeVpCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vKf3xd2w/P/LVo7L9VmrzjR/2bRsBRK7UnDSKPe0DFKelXF48aoVFfbtakbChcB2F iOyxwhUd38n+DYMBUucONFy3PO0tGLEzcdyaCjIhtcPBPy4MvL+3QiEWUdKR+4CCQA nZMftVHc5+QXyEBY0ctX7sggU9qzkvyqdYQ6cezjS/E0KUFqbJ7c+PZs6XbnZIgucR 89lcLJ42cTplQFCwldpxhWMXBdZwAIGs83PspsiPgIktEHVC+Ek9L08czn+LlkHE+P +BBmbviUJtyWw9yJ18YMJBJ77GeEFjUZUrTOSvKuTPnW+b8DCh8hm8TzgDGJBZrS3Y 8m7TUwmveqNeQ== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Abhijeet Dharmapurikar , linux-kernel@vger.kernel.org, patches@lists.linux.dev, David Collins , Fenglin Wu Subject: [PATCH 2/9] spmi: pmic-arb: add a print in cleanup_irq Date: Thu, 29 Sep 2022 17:50:11 -0700 Message-Id: <20220930005019.2663064-3-sboyd@kernel.org> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog In-Reply-To: <20220930005019.2663064-1-sboyd@kernel.org> References: <20220930005019.2663064-1-sboyd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Abhijeet Dharmapurikar The cleanup_irq() was meant to clear and mask interrupts that were left enabled in the hardware but there was no interrupt handler registered for it. Add an error print when it gets invoked. Signed-off-by: Abhijeet Dharmapurikar Signed-off-by: David Collins Signed-off-by: Fenglin Wu Link: https://lore.kernel.org/r/1655004286-11493-2-git-send-email-quic_fenglinw@quicinc.com Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 2113be40b5a9..5a99723b3f32 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -590,6 +590,8 @@ static void cleanup_irq(struct spmi_pmic_arb *pmic_arb, u16 apid, int id) u8 per = ppid & 0xFF; u8 irq_mask = BIT(id); + dev_err_ratelimited(&pmic_arb->spmic->dev, "%s apid=%d sid=0x%x per=0x%x irq=%d\n", + __func__, apid, sid, per, id); writel_relaxed(irq_mask, pmic_arb->ver_ops->irq_clear(pmic_arb, apid)); if (pmic_arb_write_cmd(pmic_arb->spmic, SPMI_CMD_EXT_WRITEL, sid, -- https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git