Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xin Hao <xhao@linux.alibaba.com>
To:     namit@vmware.com
Cc:     rdunlap@infradead.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
        peterz@infradead.org, hpa@zytor.com, jroedel@suse.de,
        xhao@linux.alibaba.com, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v3] x86/mm/tlb: update some comments in pte_flags_need_flush
Date:   Fri, 30 Sep 2022 10:24:34 +0800
Message-Id: <20220930022434.51850-1-xhao@linux.alibaba.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

There just changed the comment about 'flush_on_clear' check, which make
the explanation more reasonable.

Suggested-by: Nadav Amit <namit@vmware.com>
Suggested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---

Changes from v2
(https://lore.kernel.org/lkml/20220929091040.45390-1-xhao@linux.alibaba.com/)
- fix some comments suggested-by Nadav Amit <namit@vmware.com> and
Randy Dunlap <rdunlap@infradead.org>

 arch/x86/include/asm/tlbflush.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
index cda3118f3b27..2a17698fb194 100644
--- a/arch/x86/include/asm/tlbflush.h
+++ b/arch/x86/include/asm/tlbflush.h
@@ -291,8 +291,8 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
 		diff &= ~_PAGE_ACCESSED;

 	/*
-	 * Did any of the 'flush_on_clear' flags was clleared set from between
-	 * 'oldflags' and 'newflags'?
+	 * Consider the 'flush_on_clear' flags that are set on 'oldflags',
+	 * Flush if any of these flags is cleared on 'newflags'.
 	 */
 	if (diff & oldflags & flush_on_clear)
 		return true;
--
2.31.0