Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5b329c5f-c4b6-5d58-422e-b90df66e13cb@infradead.org>
Date:   Thu, 29 Sep 2022 20:06:05 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v3] x86/mm/tlb: update some comments in
 pte_flags_need_flush
Content-Language: en-US
To:     Xin Hao <xhao@linux.alibaba.com>, namit@vmware.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, peterz@infradead.org,
        hpa@zytor.com, jroedel@suse.de, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20220930022434.51850-1-xhao@linux.alibaba.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220930022434.51850-1-xhao@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/29/22 19:24, Xin Hao wrote:
> There just changed the comment about 'flush_on_clear' check, which make
> the explanation more reasonable.
> 
> Suggested-by: Nadav Amit <namit@vmware.com>
> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> 
> Changes from v2
> (https://lore.kernel.org/lkml/20220929091040.45390-1-xhao@linux.alibaba.com/)
> - fix some comments suggested-by Nadav Amit <namit@vmware.com> and
> Randy Dunlap <rdunlap@infradead.org>
> 
>  arch/x86/include/asm/tlbflush.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index cda3118f3b27..2a17698fb194 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -291,8 +291,8 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
>  		diff &= ~_PAGE_ACCESSED;
> 
>  	/*
> -	 * Did any of the 'flush_on_clear' flags was clleared set from between
> -	 * 'oldflags' and 'newflags'?
> +	 * Consider the 'flush_on_clear' flags that are set on 'oldflags',
> +	 * Flush if any of these flags is cleared on 'newflags'.
>  	 */
>  	if (diff & oldflags & flush_on_clear)
>  		return true;
> --
> 2.31.0

-- 
~Randy