Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <09bbdae3-b0c3-c0bb-f276-b268a7bf6905@amd.com>
Date:   Fri, 30 Sep 2022 11:46:55 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v3 02/15] perf/x86/amd: Add IBS OP_DATA2 DataSrc bit
 definitions
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ian Rogers <irogers@google.com>, Joe Mario <jmario@redhat.com>,
        Leo Yan <leo.yan@linaro.org>, alisaidi@amazon.com,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        dave.hansen@linux.intel.com, "H. Peter Anvin" <hpa@zytor.com>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>, x86@kernel.org,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Sandipan Das <sandipan.das@amd.com>, ananth.narayan@amd.com,
        Kim Phillips <kim.phillips@amd.com>, santosh.shukla@amd.com,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220928095805.596-1-ravi.bangoria@amd.com>
 <20220928095805.596-3-ravi.bangoria@amd.com>
 <CAM9d7cjVcGLn+dmajox6ASxx=YQYv9Viv+wzSXdaqCEJrow56w@mail.gmail.com>
 <aa91fc2d-319c-bbb2-d011-e60f7c04d776@amd.com>
 <CAM9d7ch3gEn15g7zZOHNUcEJ0aO-Gu2+7nz9QD45+WeY0fcgyg@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAM9d7ch3gEn15g7zZOHNUcEJ0aO-Gu2+7nz9QD45+WeY0fcgyg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEUyTmxWVGhDZ2UzaUhmTldLM3VRbE9PZFhIY1YrZEc0dDNRelJSem5FUXVs?=
 =?utf-8?B?QmhBdWR5TzYrVVZNVTE5OXN6RllMMlRKSFNVajNFSDN6ZEsvWnBSZXJ1TnlG?=
 =?utf-8?B?WlVKMitpM0dudFdka3ZDcXJpSjNTak5WeGp2cVhNVzh6b1RYTkd5QVorcWRE?=
 =?utf-8?B?aU9VcnhROXZ6bWt1b3drTVZ6V2x6cS9jQTFUU0xaa0dXT240Z2JlMHdhOGgx?=
 =?utf-8?B?Q3JaaDdsblF0aXArb2pYb2k3cG9OWTltMHFocmJkTGRIZUEzd214RWNmc1Br?=
 =?utf-8?B?Rjk0ZW5XblhYUUFOdFdkUGhlaE5ZVHoyWFRRQTIyMjNRSmZQY1AvSEVMWEhX?=
 =?utf-8?B?SGdKMVcwTVlHQ1AzTnBzU2VSeVNIUWY0MXVYWUV1M09XMlY0RXZLbEV4OGRN?=
 =?utf-8?B?OFI0eHhacEZ4d0pVZ0JTWnNHSHN3ODhLLzB3Mk1DT1BEcElHSEFLbzVtdU5K?=
 =?utf-8?B?Y2lhSXhzMndmMmR1dWVwTEUxNElTaGJlbkVZbUczTUtVZDV3R21nK2RiZS9l?=
 =?utf-8?B?MTJjb1FTWnJsNUxPTG9NR00xRU45MWl6bmpwbUtBV2FmRURqQTVHeFExRWg5?=
 =?utf-8?B?UC9uL3d6WXd5M0dYSlJ5NWQraFdNMmVmNHpJcVNDMjJZTG1QWmJZcnQ1cG5R?=
 =?utf-8?B?TnBoVFZPUGJPSmFsb3hzeGFoM012QUw1UTBDSEExY0FyYjViR2Z6RlByZXVp?=
 =?utf-8?B?OXd3RFpTSmwwc0lsWi80OU1IYlE5SEMxdzdoL1B4NVdVQjRKQWNzVjFNTjdF?=
 =?utf-8?B?NTRleFhuVUlOcktQdmVoYzJtWVEvTDJ0bXpWWWZ0VWw3K1FLYnV1dDRRYjJQ?=
 =?utf-8?B?MjlrVEJ0dFNIZWszZEx5MXRINk12dUZaV1VPTkd2Wm5SY0NYbkJDL0FMYnZn?=
 =?utf-8?B?cjVNV3NrVEo5ZUQ5UmNlNTltU0NhSDY1bnlIVVlmLzVxaXZGK2NKNlJ1K3pB?=
 =?utf-8?B?VWpXcW0zZjFsejB1bVVhOGVkUjB2WlBVL1g5andXendPVVUvSGhUU2FuWGtl?=
 =?utf-8?B?S3hEUTk5SnRqNlpWVERYT2hzSUJwRVNCMTBuNU1ibWVEN1J6dkZiRS9pRURJ?=
 =?utf-8?B?c2RLTVZzdGxNOVJMcjBMeVFsekptdnRBT2lXY2FHczR3THJ2eGVxcUdXUXp3?=
 =?utf-8?B?cFAwMWpQcTBieXFMN0ZoSzB3UkZJQStOMlVBRjZ4U1B4UkRmWVcvb1lld3Q1?=
 =?utf-8?B?Y2R6RXZCaWl6Y29LSEFjcjN0QWJGQTZ2OFhIckNCTGZNbHVNWlBiTFo2ZVJB?=
 =?utf-8?B?WVdKaE94ZUhmY2Z1YXg2NC9QV0lxdTVleWJHTldSTGYrK1ovdXZvcDN2SnZ3?=
 =?utf-8?B?WCtpcXN5cVdlM1pwbjduamk1cVlpbzVHR1FLTmlDdlVmb2hiRzZ0eTN5UDg4?=
 =?utf-8?B?MXFPUDlhazZnRzVSZUtUVVhCNW5maTVVTjNUNHhKY3VQdDFYbVJqc3lVMlJn?=
 =?utf-8?B?cHVQVysvWEo4d3FuLzRCM0NLTWN3TXlCU2pES2lGSS9waFpxSjlWRnpMamRQ?=
 =?utf-8?B?cm5iRlYweWhKSm8vbjZFTnFieVM1TVpNeWd1cTVsVXVVdmszMXQ5TlRBbmwr?=
 =?utf-8?B?Mlc3emRwY1dBd2YyNmpYeThZTEN4QS84ODFVaG5vd1VVcGRJT25BdXFLM2tV?=
 =?utf-8?B?N29FSVpJZjFOMHAveEZVZ1UydmxPeDBiQlVIamlLTm92YkVyRURmQUV4cTQ5?=
 =?utf-8?B?R3Y1VElUWjdyVW1oUTQzQytIc1Zva3M0U1lHQXp0djdmNmdxV1ZKRVRlbFl5?=
 =?utf-8?B?bnVzYzlyY2lBM2V3dExqMTVuNVl0RHB6cHIwcllmcTc0MEZheUMrMkRrbkl1?=
 =?utf-8?B?ZkRZLysvZW9LdDNqNUlzSHJxNW82ZzR3WVFwOTU4M0gxZWVXRkcrZ0h2dUt1?=
 =?utf-8?B?UkdJd1BsL04xZWhWV0NJMDMzaXBOU0E5dUJEN1dNRDU5Z2V4cTcybTF3bnIv?=
 =?utf-8?B?UlBiNnZvc1ljMjN0eGRnZ2h4cWVpbUkxbXU2ZkNJMDQra29nbEtTZkdqMTB4?=
 =?utf-8?B?RGtWUTZXMFpUa1dUUFJGbW5oMnV1U2RqZ0l0VHViZVZDZld4K3RLQjRXYUoy?=
 =?utf-8?B?ckJ5SmJyVFlyZTF1RmZ2WVFpYlppR0NGN0FyN0dySFlZYXg2cUQ2RlZBVFhL?=
 =?utf-8?Q?W0D/TbpOe1aR9pyod/fCAt48c?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d423393-5d6c-414c-03fb-08daa2ab66cd
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 06:17:07.8383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SnCKIAUL7b/ba4ydPzjGEVtLYodqIBwdbpBAUT3RmNlMAP3uLawgDmm2tdCNTa6ku0yVowJuKHJCXm7wRW8utw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6575
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>>> +/* IBS_OP_DATA2 DataSrc */
>>>> +#define IBS_DATA_SRC_LOC_CACHE                  2
>>>> +#define IBS_DATA_SRC_DRAM                       3
>>>> +#define IBS_DATA_SRC_REM_CACHE                  4
>>>> +#define IBS_DATA_SRC_IO                                 7
>>>> +
>>>> +/* IBS_OP_DATA2 DataSrc Extension */
>>>> +#define IBS_DATA_SRC_EXT_LOC_CACHE              1
>>>> +#define IBS_DATA_SRC_EXT_NEAR_CCX_CACHE                 2
>>>> +#define IBS_DATA_SRC_EXT_DRAM                   3
>>>> +#define IBS_DATA_SRC_EXT_FAR_CCX_CACHE          5
>>>
>>> Is 4 undefined intentionally?
>>
>> Yes, Here is the snippet from PPR (Processor Programming Reference) doc:
>>
>>   Values | Description
>>   ---------------------------------------------------------------------
>>   0h     | No valid status.
>>   1h     | Local L3 or other L1/L2 in CCX.
>>   2h     | Another CCX cache in the same NUMA node.
>>   3h     | DRAM.
>>   4h     | Reserved.
>>   5h     | Another CCX cache in a different NUMA node.
>>   6h     | DRAM address map with "long latency" bit set.
>>   7h     | MMIO/Config/PCI/APIC.
>>   8h     | Extension Memory (S-Link, GenZ, etc - identified by the CS
>>          | target and/or address map at DF's choice).
>>   9h-Bh  | Reserved.
>>   Ch     | Peer Agent Memory.
>>   Dh-1Fh | Reserved.
> 
> Thanks for sharing it.  It's a bit confusing since it was available before.

Right, these bit definitions have changed in Zen4.

> 
> Anyway, is the PPR for Zen4 publicly available now?

Sadly, no. But it's in progress.

Thanks,
Ravi