Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f54b8720-2282-f4fe-fcb4-881562118eb5@amd.com>
Date:   Fri, 30 Sep 2022 12:27:22 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v3] perf test: Introduce script for data symbol testing
To:     Leo Yan <leo.yan@linaro.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, Ian Rogers <irogers@google.com>,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220924133408.1125903-1-leo.yan@linaro.org>
Content-Language: en-US
In-Reply-To: <20220924133408.1125903-1-leo.yan@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUpEWmpWb1BydERnK0gzLzk1TXBrRGVYZG56WG9vd003ZldaQWhYK01PMFY4?=
 =?utf-8?B?RjFUbGFtTlJ1bVpweFNLd2Y2cGxSTmxTVzloem1VM2tMKzdKRFVrK0hkc04z?=
 =?utf-8?B?NFRUT0c4bnRUekNjNGZoYVltWEQ5YTJIUC9oRE5tQzA3WUpXQmhtWHN4cU5V?=
 =?utf-8?B?d21SVGY1eWFpOWVGQkVnRktKSUk2b3BwQnFpN21hZDJiRGlvZWdCK1YrODU4?=
 =?utf-8?B?aU90MWw5SDRxR01wenlqWHo2WlFSNUpaMkJwb0Vka1lPYkhnbFlyZ090UTBm?=
 =?utf-8?B?dnAvL1R5UGJDYzVuZ05WMkNPaHZMZzdCOTZLZncrWTVodldPM0x5KzFMckJ3?=
 =?utf-8?B?Zzc5cThFeTZXRllWUnRwQUlTc25oTHAxUzlnS0JKOWI0b21rMWZ6UzEwNjZQ?=
 =?utf-8?B?cXg4aFdjODRCcjEwOXA0aUJvcnd0ZEp2cHN2MU1MTjFGWDAvSGIvRWRCb2N2?=
 =?utf-8?B?TnZWYmJSMWVjU0hhaE5FcGRaRHpNTDlTZ0RIc29kaHhWUi8wSnlzKzdVdC9j?=
 =?utf-8?B?aGNPL29oRzBZZUk0amJ2Yk1HSWJmK0NpNW5IaEExT092QlloenZnVHpMTVZy?=
 =?utf-8?B?NVRQOWNSUDFiS3lmTlJsYWx0eEhrMFJUU0l3Z052TFZvUU02cnhPdUpMOW5C?=
 =?utf-8?B?WXFYWXR3UnJmVmNzdzNzNVlpcm1jM0pJUFM2ckxJeVRIY1lISnlnNHlvb2JT?=
 =?utf-8?B?eW5mWFZXdWQxUXYxWkVHTE5BaEJvaEJjS1pjd09yaTUyamhuQnpaa3prcUFs?=
 =?utf-8?B?T0UrL0dETFh3SE5LS05KT0pxN2REVWJQeSs4c1hZdWIrWU5SaUdWRGFLTHNh?=
 =?utf-8?B?R2JRcitSa0N6dWZjWEhVMTYwbWhadHl1VWhyN3E2a3RzRGRlVGgvY3d0SkRX?=
 =?utf-8?B?NVhOaE5uTjVLS1pSdzFvMXMwNUVrYWZDMDBqUkY5R2J0S3VkbWFQb3RLM0FS?=
 =?utf-8?B?Q3B1TXdNZjBCdVk5UHh2RjhORmtubmdCRkM5R0NFbE5NYldlZHkyaHJRaGlO?=
 =?utf-8?B?MHpJdm9aa250RXF3MlQ3VVZJMVZFajEvSDd2VlhNdk9IZGlIay9EY1JvNzhh?=
 =?utf-8?B?RUtHVVo4cnZMN2FhTHBwYkdHY2RkNmF3MkdTRVNIOTM5MU1uVDFONElGVDNI?=
 =?utf-8?B?QjIyamJuRmw5Y0xSYzJHNUVYOUtKOHdnYUcvaEE1M2VDWVVXazVhNDhRNm1K?=
 =?utf-8?B?NStCbHMzY1B0YTN2VWMvTktGY2E5VTJkakZQTmlVbDZjRmYwc2tGQSsySWZw?=
 =?utf-8?B?c21MbHV1UWtEbzh4RnBMYm9YRTRncGVxeDRKT1U4UE5jNCtRK3hjKzM4V01k?=
 =?utf-8?B?YWptaDI0NUxkdDVmY1pnZ2RqUW12VXQzNjJKVlA2eHMvb1NZTTBJVWF5Ykgx?=
 =?utf-8?B?d3BselRZN0xjQk9PajZqVDVnODlGbGx0WHJxYk1nZUQ3ZEFibHNJMWx3blZ3?=
 =?utf-8?B?SUU4a2RaUExUc0VDa1V4QmF3UTgrUFN5bnU4WTMzMGpNellCa05GZURTRGtD?=
 =?utf-8?B?Ym1QdTNQYzUwdjNUMTdPUlBGRk0wNU9EaWFDbUZjbEF5aWdkRm5RV1A1MjYy?=
 =?utf-8?B?MFZwbEd3ZHlWYUtRM25jWXBqSERGT09FZmlmOWNyTW8vU08yWXhmVjVFTndV?=
 =?utf-8?B?UndDeVBtQzl2UjBMWUd6bTVMcGVLVklXNVUzNFZwNmNUOGZ1ZlFDL0MrVHlV?=
 =?utf-8?B?aVI5RzdpRkxha1RnQTljZ20veXRmT2NVV3lzZjZ1YzhPSStBUFRNZ1VLdkxy?=
 =?utf-8?B?Q012UVYraHpZSnBnd3JLaVpqa2ZJbXkwRldxNXdpS25pQTBwd1JaVXoybms3?=
 =?utf-8?B?dWlwOVdIbWJCL3B5RkpBSFNnM3ExYkdDWUszeitsZU41K1dtekFyK2NFQVcr?=
 =?utf-8?B?VEpkcHRkQ2xobjUzTjlrYkVnVTZrQzg5bWcrdzhCRWwzb1hPOVgzOWhJc1Vh?=
 =?utf-8?B?REpIVFlKNVM0eEhyUHBKejB0N1dUS2JmalFlejZ0TGVZYzFac21oM0IvZjdy?=
 =?utf-8?B?Mjc5ZUMvMDFPZ0ZNa1BOTmM5bzNKVGt1ZWM1RG80cTNKWWdSZGUremxtVDBu?=
 =?utf-8?B?ejc2bDFxcFdkck9HRDhWZHFuSjNPK2JVdHBCajU2UlQ1T2dPbi9QR1FoYkp2?=
 =?utf-8?Q?d2rApvYmCdrCaIx3k1XyXCCWx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 211303fe-b691-44bd-ade3-08daa2b10b45
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 06:57:31.1497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hj86qMzRqDLNPwJtbbgEEuEI8FIuppQGYluZbpmmxgWEBK+38SeRKQLdb26l+HnXUioV6o/mUmVI0D7fAhZuWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5165
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Leo,

On 24-Sep-22 7:04 PM, Leo Yan wrote:
> This commit introduces a shell script for data symbol testing.
> 
> The testing is designed a data structure with 64-byte alignment, it has
> two fields "data1" and "data2", and other fields are reserved.
> 
> Using "perf mem" command, we can record and report memory samples for a
> self-contained workload with 1 second duration.  If have no any memory
> sample for the data structure "buf1", it reports failure;  and by
> checking the offset in structure "buf1", if any memory accessing is not
> for "data1" and "data2" fields, it means wrong data symbol parsing and
> returns failure.

I'm working on adding support for perf mem/c2c on AMD:
https://lore.kernel.org/lkml/20220928095805.596-1-ravi.bangoria%40amd.com

And this test fails on AMD because perf mem/c2c internally use IBS pmu
which does not support user/kernel filtering and per-process monitoring.
Would it be possible for you to add below (ugly) hunk to this patch:

---
diff --git a/tools/perf/tests/shell/test_data_symbol.sh b/tools/perf/tests/shell/test_data_symbol.sh
index a153b0d84dc0..212082951b12 100755
--- a/tools/perf/tests/shell/test_data_symbol.sh
+++ b/tools/perf/tests/shell/test_data_symbol.sh
@@ -71,7 +71,12 @@ int main(void) {
 EOF
 
 echo "Recording workload..."
-perf mem record --all-user -o ${PERF_DATA} -- $TEST_PROGRAM &
+is_amd=$(egrep -c 'vendor_id.*AuthenticAMD' /proc/cpuinfo)
+if (($is_amd >= 1)); then
+	perf mem record -o ${PERF_DATA} -- -C 0 -- taskset -c 0 $TEST_PROGRAM &
+else
+	perf mem record --all-user -o ${PERF_DATA} -- $TEST_PROGRAM &
+fi
 PERFPID=$!
 
 sleep 1
---

Thanks,
Ravi