Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a4790844-825f-839d-ed9a-104d4b589290@amd.com>
Date:   Fri, 30 Sep 2022 13:02:44 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH 3/3] dma-buf: Check status of enable-signaling bit on
 debug
Content-Language: en-US
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220927172409.484061-1-Arvind.Yadav@amd.com>
 <20220927172409.484061-4-Arvind.Yadav@amd.com>
 <59d4d647-f451-061c-79b5-0ffc4e33fc58@amd.com>
 <52ed8ec2-bd90-ad40-fe85-83d60eda7e05@amd.com>
 <efce6f23-135d-d946-6677-0668d83a7831@amd.com>
From:   "Yadav, Arvind" <arvyadav@amd.com>
In-Reply-To: <efce6f23-135d-d946-6677-0668d83a7831@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czlEaTR5ajl4a3hkLysvMmh1ekRzQnI2bHFGUGhQMnN6ZFVBV1JBZHg5UG9V?=
 =?utf-8?B?cjdPK3FtK09YQWgrSFJ5d2RHOHJrbTExSXM2dTdEekZocEZjL0ZOeVVDc0pi?=
 =?utf-8?B?elNUQy9zSldkUU15MHdiQUlTOFo1aU5IbXpHdytPWlR1SDNwYk85c3N5NHVi?=
 =?utf-8?B?WWJmdjE1MDhnYVlRbkRHWmtnenRmb0l5NUtxbkQvSHRZNW43VnNlSFhwOTBL?=
 =?utf-8?B?OEhod2xxZkQ1NFpUS2JWcFF4TW9DODd3ZklFQ0ZhVzZyZXlPUEF1SEV0YU5K?=
 =?utf-8?B?SGdyYzBBVW9yaG0vSkp2cGszbkswaXBuTkxiWUFMVm0ybGxDOVpuWmJqbUh5?=
 =?utf-8?B?cXpoVk1jdldBM2swOGMvTTFuTlpIQWhqSGl0V01EcTVQaGxmQVBEQW5YeFdM?=
 =?utf-8?B?bTBISHRLWXIvbWJheGplUlg1Rjg1Qy9uMExId3dmais3aVNRZFpvdVRabFBH?=
 =?utf-8?B?L1VCVm5tYUU2TjdtbXhWL1JNSzlsNnNNQ1JPSU5WNE1DOXdWODNKNFBRRE9V?=
 =?utf-8?B?MUcveW5HTXAvM2xtczJSYTkyYURMb2ZlZDZBNXAwWDI2VDFWOVhBbkF2MUxQ?=
 =?utf-8?B?bkdXY1BCS01BL2RudkFCMW8rNHdYNE5HN0FmRlcraGFSRHF1ZXVqaThCSXpv?=
 =?utf-8?B?L0hCV1JWU3BOalMxNVNPYVFEdE9MR1ZrcVI3Q3cyaHZEaVY3bWxWSHkzNVFk?=
 =?utf-8?B?bWd1WUtDdkNwSk5GL2oxMWRDTk13Z3NpelU3d2ZxK0xuSGRsNWcwZjN3eTVi?=
 =?utf-8?B?RU5oelB6UXFlN0ZHM050S1h1d1dsV1lJZkJnRlAzYllLSlExRDJuTDNNVVJi?=
 =?utf-8?B?c1M2eTF2UDhwNlcvUlhiUnhjNCs2dERaR04xc25YUFl6V05MYjc5ZndxYkZR?=
 =?utf-8?B?MWluT2NJdXZVZ2hPQ1NBL3ZDVHdzTW5VbUg5VXRsM2FwcEcvRXJnaVdUK0s4?=
 =?utf-8?B?LzdDRG1LZjJHRE9mdE5QZzN4Q2Exb0xRdVZkTzIyS3grOUJxekw4eDdIbkIw?=
 =?utf-8?B?ZkU4LzljZUpZYW1aUDhPYk9RZ1FtbWFvT0U1VTVaK0M4QUxQbUc5TDV0RitQ?=
 =?utf-8?B?djd6bVdUSmxGSVZPVnovRFlCOUZqN0dQTE5YRXpZOVhKWUo3WEs1dWJVdDRj?=
 =?utf-8?B?NGhydWhJdUlzdXBjYk9Cd2EydGF2OGZSNUhsb1EwTytESUpmKzJsQXNxN0dN?=
 =?utf-8?B?SGt4eHlOQTZ1WXptQjBtaXFJYUZtdXhyMkpBb0M5QXVQK2pqeXFTanFTbVc4?=
 =?utf-8?B?TlMxRXl0ZDFGdTBScnRPQWYxTElPSzMxQ1k0S3lLc1daSVlRaXlsM0NNRktn?=
 =?utf-8?B?aWVNOXpybmxUY1M1T1NLSGVEYjVsM0NzZUdqOFZrb01jZTlqM2J5K1MvNlRI?=
 =?utf-8?B?RzFmUU5IMlo2YVErWXIzb3lEQW1Ka1Jkb3VnN0F5eUN1YzdsK24ycU10R1Vo?=
 =?utf-8?B?dUp1ekgzOExFU1EyQndmMVhyTnZTM3JWV0JoYkVYVUxuZ2p3ZFVpcTJ3Q3NE?=
 =?utf-8?B?Y29XYU1yZUIrdTJXY25FLy9IWGJnaWVkUHIzWm9CSkg3TGRGUHBPZTJHRENn?=
 =?utf-8?B?cU5sTUYrSnFTZllORktKQUdVcFg4Ym9hbGhhTkY2OWNLb2t0TTRBVTJxT2Y5?=
 =?utf-8?B?UE1idGNXcTBIeHVhSC9iTjR2QkpDcmRWUFZNWEZWQjE2bno2V3MxVHY3UUMy?=
 =?utf-8?B?cm1qKzJsTG9hOXZSNHRGb2ZLRmppQ1JLaGVrbjVVNnF3c24zbFhzalJBQzBQ?=
 =?utf-8?B?ZG1WTEF4VzJUYUJVN2ZWVjVKeERWRWQzZVRJczg0eGlWZjI0ZVp6dm56QXNy?=
 =?utf-8?B?a3FKZkszWFNHVUlUTXl5Qmk1a1VHNTlSWmR5bkk3N2NjYXFMeGtvdllYbTVh?=
 =?utf-8?B?U255eUU4Wk1Id214TGxZa2NpaEcwZnBzN0xBYmc3eXJic29UM3N0Ty9HSmtD?=
 =?utf-8?B?dklOVW9MZEtDY2NGdmZXYmN4eWZYd1MyR3QrTVBrcTZXZGlNUTVmWlBHRDE4?=
 =?utf-8?B?V3A5N2hVZUYvbmFkZnlkdHc2Tng5alJPOTZwZC83THdLbFJ2L0gzVndqUzdE?=
 =?utf-8?B?MlVvaGtSTVYxVEFyUXdubTF4cXRKY2xRN2Zvd1lrUnBpeUszdS83Ri83QVZT?=
 =?utf-8?Q?7z/OREFV7wzvKOf48w7Wd9Y9o?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 780b7422-4cff-48cf-9662-08daa2b5fddd
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6000.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 07:32:56.2346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EkcM0BJq+t3PwMTebb3yz27IqU0lLixbtxDahGIwo69qrVkANR9i4O5R+fysPBL2nYPb3PStS1ZneOyNCnRtLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6948
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/30/2022 12:02 AM, Christian König wrote:
> Am 29.09.22 um 20:30 schrieb Yadav, Arvind:
>>
>> On 9/29/2022 11:48 PM, Christian König wrote:
>>> Am 27.09.22 um 19:24 schrieb Arvind Yadav:
>>>> Fence signaling must be enabled to make sure that
>>>> the dma_fence_is_signaled_locked() function ever returns true.
>>>> Since drivers and implementations sometimes mess this up,
>>>> this ensures correct behaviour when DMABUF_DEBUG_ENABLE_SIGNALING
>>>> is used during debugging.
>>>> This should make any implementation bugs resulting in not
>>>> signaled fences much more obvious.
>>>
>>> Are all IGT tests now passing with this? That would be a bit 
>>> unfortunate because it means we still have missed the bug in 
>>> drm_syncobj.
>>>
>> IGT has these test cases related to syncobj (syncobj_basic, 
>> syncobj_timeline and syncobj_wait)and all are passing.
>>
>> I will check syncobj and let you know.
>
> Maybe CC the Intel list and let their CI systems take a look. That's 
> usually rather valuable.

There is one IGT subtest is failing which is related to syncobj. I will 
fix this and submit the patch.

  igt_subtest("host-signal-points")
                 test_host_signal_points(fd);

>
> Thanks,
> Christian.
>
>>
>> ~Arvind
>>
>>> Christian.
>>>
>>>>
>>>> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
>>>> ---
>>>>   include/linux/dma-fence.h | 5 +++++
>>>>   1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
>>>> index 775cdc0b4f24..5156dc6be0a6 100644
>>>> --- a/include/linux/dma-fence.h
>>>> +++ b/include/linux/dma-fence.h
>>>> @@ -398,6 +398,11 @@ void dma_fence_enable_sw_signaling(struct 
>>>> dma_fence *fence);
>>>>   static inline bool
>>>>   dma_fence_is_signaled_locked(struct dma_fence *fence)
>>>>   {
>>>> +#ifdef CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING
>>>> +    if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
>>>> +        return false;
>>>> +#endif
>>>> +
>>>>       if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>>>>           return true;
>>>
>