Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3e8b907d-413a-70be-d8bd-2ab8b53c3b9c@somainline.org>
Date:   Fri, 30 Sep 2022 11:43:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/2] slimbus: stream: handle unsupported bitrates for
 presence rate
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
References: <20220930092006.85982-1-krzysztof.kozlowski@linaro.org>
 <c3aafcdf-9e24-9fbb-b022-d7d1cf04b7b9@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@somainline.org>
In-Reply-To: <c3aafcdf-9e24-9fbb-b022-d7d1cf04b7b9@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 30.09.2022 11:42, Krzysztof Kozlowski wrote:
> On 30/09/2022 11:20, Krzysztof Kozlowski wrote:
>> Handle errors of getting presence rate for unsupported stream bitrate,
>> instead of sending -EINVAL in change content message.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  drivers/slimbus/stream.c | 11 +++++++++--
>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c
>> index f8eade1e0132..28fbecb3907d 100644
>> --- a/drivers/slimbus/stream.c
>> +++ b/drivers/slimbus/stream.c
>> @@ -204,7 +204,7 @@ int slim_stream_prepare(struct slim_stream_runtime *rt,
>>  {
>>  	struct slim_controller *ctrl = rt->dev->ctrl;
>>  	struct slim_port *port;
>> -	int num_ports, i, port_id;
>> +	int num_ports, i, port_id, prrate;
>>  
>>  	pr_err("%s:%d AAAA\n", __func__, __LINE__);
> 
> The context is from development tree. I'll rebase and send a v2.
I somehow didn't think it's out of the ordinary heh, my r-b still stands
for the changes.

Konrad
> 
> 
> Best regards,
> Krzysztof
>