Date: Sat, 23 Jun 2007 23:12:07 -0700 (PDT)
Message-Id: <20070623.231207.44965284.davem@davemloft.net>
To: okir@lst.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Make skb_seq_read unmap the last fragment
From: David Miller <davem@davemloft.net>
In-Reply-To: <200706190956.26252.okir@lst.de>
References: <200706190956.26252.okir@lst.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 913
Lines: 25

From: Olaf Kirch <okir@lst.de>
Date: Tue, 19 Jun 2007 09:56:24 +0200

> From: Olaf Kirch <olaf.kirch@oracle.com>
> 
> Make skb_seq_read unmap the last fragment
> 
> Having walked through the entire skbuff, skb_seq_read would leave the
> last fragment mapped.  As a consequence, the unwary caller would leak
> kmaps, and proceed with preempt_count off by one. The only (kind of
> non-intuitive) workaround is to use skb_seq_read_abort.
> 
> This patch makes sure skb_seq_read always unmaps frag_data after having
> cycled through the skb's paged part.
> 
> Signed-off-by: olaf.kirch@oracle.com

Thanks for finding and fixing this bug.

Patch applied, thanks again Olaf.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/