Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Sep 2022 13:37:25 +0200 (CEST)
From:   Miroslav Benes <mbenes@suse.cz>
To:     Chen Zhongjin <chenzhongjin@huawei.com>
cc:     linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
        mcgrof@kernel.org
Subject: Re: [PATCH -next] module: Remove unused macros module_addr_min/max
In-Reply-To: <20220924072216.103876-1-chenzhongjin@huawei.com>
Message-ID: <alpine.LSU.2.21.2209301329490.11771@pobox.suse.cz>
References: <20220924072216.103876-1-chenzhongjin@huawei.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

Hi,

On Sat, 24 Sep 2022, Chen Zhongjin wrote:

> Unused macros reported by [-Wunused-macros].
> 
> These macros are introduced to record the bound address of modules.
> 
> '80b8bf436990 ("module: Always have struct mod_tree_root")'
> This commit has made struct mod_tree_root always exist, which means
> we can always referencing mod_tree derectly rather than using this
> macro.
> 
> So they are useless, remove them for code cleaning.

a nit, but I would rephrase the changelog a bit...

"
Commit 80b8bf436990 ("module: Always have struct mod_tree_root") made 
"struct mod_tree_root" always present and its members addr_min and 
addr_max can be directly accessed.

Macros module_addr_min and module_addr_min are not used anymore, so remove 
them.
"

> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>

Anyway

Reviewed-by: Miroslav Benes <mbenes@suse.cz>

M