Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Sep 2022 19:36:39 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Ravi Bangoria <ravi.bangoria@amd.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, Ian Rogers <irogers@google.com>
Subject: Re: [PATCH v3] perf test: Introduce script for data symbol testing
Message-ID: <YzbTu/Dk/W+Ieycb@leoy-yangtze.lan>
References: <20220924133408.1125903-1-leo.yan@linaro.org>
 <f54b8720-2282-f4fe-fcb4-881562118eb5@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f54b8720-2282-f4fe-fcb4-881562118eb5@amd.com>
Precedence: bulk

Hi Ravi,

On Fri, Sep 30, 2022 at 12:27:22PM +0530, Ravi Bangoria wrote:
> Hi Leo,
> 
> On 24-Sep-22 7:04 PM, Leo Yan wrote:
> > This commit introduces a shell script for data symbol testing.
> > 
> > The testing is designed a data structure with 64-byte alignment, it has
> > two fields "data1" and "data2", and other fields are reserved.
> > 
> > Using "perf mem" command, we can record and report memory samples for a
> > self-contained workload with 1 second duration.  If have no any memory
> > sample for the data structure "buf1", it reports failure;  and by
> > checking the offset in structure "buf1", if any memory accessing is not
> > for "data1" and "data2" fields, it means wrong data symbol parsing and
> > returns failure.
> 
> I'm working on adding support for perf mem/c2c on AMD:
> https://lore.kernel.org/lkml/20220928095805.596-1-ravi.bangoria%40amd.com
> 
> And this test fails on AMD because perf mem/c2c internally use IBS pmu
> which does not support user/kernel filtering and per-process monitoring.
> Would it be possible for you to add below (ugly) hunk to this patch:

Sure, the change is fine for me, I will update patch and send out a new
version.

@Arnaldo, I saw you have merged this patch into the branch:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf/core

Could you pick up the new coming patch?  Please expect it would be soon.

Thanks,
Leo