Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f19fa481-334b-4145-d49e-1260d3fde810@microchip.com>
Date:   Fri, 30 Sep 2022 13:33:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] ARM: dts: lan966x: Add interrupt support for PHYs on
 pcb8290
Content-Language: en-US
To:     Horatiu Vultur <horatiu.vultur@microchip.com>,
        <devicetree@vger.kernel.org>, <claudiu.beznea@microchip.com>,
        <linux-kernel@vger.kernel.org>
CC:     <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <UNGLinuxDriver@microchip.com>
References: <20220915064112.1935051-1-horatiu.vultur@microchip.com>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
In-Reply-To: <20220915064112.1935051-1-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15/09/2022 at 08:41, Horatiu Vultur wrote:
> Add interrupt support for the PHYs found on pcb8290. They are all
> sharing the same interrupt line towards lan966x.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   arch/arm/boot/dts/lan966x-pcb8290.dts | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x-pcb8290.dts b/arch/arm/boot/dts/lan966x-pcb8290.dts
> index af92bb12bc6cd..2ed53da914acb 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8290.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8290.dts
> @@ -68,41 +68,57 @@ &mdio0 {
>   
>   	ext_phy0: ethernet-phy@7 {
>   		reg = <7>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy1: ethernet-phy@8 {
>   		reg = <8>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy2: ethernet-phy@9 {
>   		reg = <9>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy3: ethernet-phy@10 {
>   		reg = <10>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy4: ethernet-phy@15 {
>   		reg = <15>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy5: ethernet-phy@16 {
>   		reg = <16>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy6: ethernet-phy@17 {
>   		reg = <17>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   
>   	ext_phy7: ethernet-phy@18 {
>   		reg = <18>;
> +		interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-parent = <&gpio>;
>   		coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
>   	};
>   };


-- 
Nicolas Ferre