Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3564350rwb; Fri, 30 Sep 2022 05:29:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ELET6920FyGOzV9vv4S37aEKMK4Hca5YrDc+mRyEVOuqCErvkKQosmHsxb0SrT58NQdgT X-Received: by 2002:a17:906:db0d:b0:77b:a7cd:8396 with SMTP id xj13-20020a170906db0d00b0077ba7cd8396mr6632407ejb.264.1664540995651; Fri, 30 Sep 2022 05:29:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664540995; cv=none; d=google.com; s=arc-20160816; b=CYDmhudcX7RaYXA8jEjNjG3fXSfrTShVX+K/75Mc09wyk75n1Zrkajr3L37lDWHyO6 1qgpSH5tcuNWJd8spYpyquWrXzpgqD4S4nZ9GShI+30+BbK6iCXNaiubOCN7uhzTlRHE P3VBuHJbstrAMusoa1VDqVXCDRgmfJaLl/j3sawf0KHOCbSynz+blNeM/dpYoKnZAQpU oSgxWYpI1rhzuJQRgzsdm99QIryviFr3sZu5jBvrkxwVUvgMTibxqhasK+sZHm0hSwTI 2DnsNunVforOfspw9y2jNdPe7l9BTWe7qAc5bIC8szgT73tUBsnLe+LUZ/0EFt0Tqr1a z69Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=8ZV06C7I/F2scn4sgwAXK7R2wH3l+z+pnvJjlUEC0p8=; b=UPiGJLv+4VJisSzPLnhkxeROMiteGPEAe0Q6rXSU+vb+GgxnDwNG0RJ0Z0tdxDDJhW u+lv+jsz+azWBobcgGXh8Z3bOBwvKTr5a+AA1EN7/Mtj6E15zMn3U/n2d+jg7Qo8Gn/1 zpSiamsyzKgjVS/tPXw27nvPaBSlqkuRkS/qAuQpEpZT+2vOx0FFne7yl1/hb9NNeJDL 4/OeVfcrLzNAVlJ33ogPY/FANLvG7CPgyjJosU0HVfHxZmMzMzTSumkXTQr78T7kf20M XYtXu/TlLziDhz20hi6fWZTV50a4IF3R/n1CGmb90s7kTWDLqSMJmDBAlRZs0+M7LiZi /ItA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=LPSdUI4K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne24-20020a1709077b9800b00726d03899basi1724219ejc.344.2022.09.30.05.29.29; Fri, 30 Sep 2022 05:29:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=LPSdUI4K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231540AbiI3MO0 (ORCPT + 99 others); Fri, 30 Sep 2022 08:14:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbiI3MOW (ORCPT ); Fri, 30 Sep 2022 08:14:22 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA2B17A5FB; Fri, 30 Sep 2022 05:14:22 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 95B4066022CB; Fri, 30 Sep 2022 13:14:20 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664540061; bh=8tHGfCw+vp0FbI3nyOeiRtXInzXUqDHc4IFqsrunjAw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LPSdUI4KWdjHB68Y6tW7m60Moc8tHqLmw9cOcww6sglB9r43oXpRCPAVFDC175qBv 0lrXfjQhaywhC+anRphKC7hWmdVu7tD4ZeeoC/RCwnrtGcQK/h0FZudXwdLbkaA+ml pD3y9wXGiwDyQRgpCi34+Md6zAdSwAuxqgXnhiBHkn6bl4erLM4FB9RYfeBmTPAlLH FYm7Cx5JOsxJad+5NtqQDfVZEofK6OCQ6kCsRntBKFBBUCI8oqzBVUunaB3D28ipS/ VmSeCbv+0R+dIKVSzR/M0PIhn9/gohjqrPth9jwzPzdPGuH2vgpDokWzdtAjyRt9uo 3M/5r1lLCo1JA== Message-ID: <6eab4410-0284-0b09-e810-f979b8ad1d57@collabora.com> Date: Fri, 30 Sep 2022 14:14:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v1 1/2] media: platform: mtk-mdp3: fix error handling in mdp_cmdq_send() Content-Language: en-US To: Moudy Ho , Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220930102306.13201-1-moudy.ho@mediatek.com> <20220930102306.13201-2-moudy.ho@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220930102306.13201-2-moudy.ho@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 30/09/22 12:23, Moudy Ho ha scritto: > Increase and refine the goto label in mdp_cmdq_send() to avoid > double free and facilitate traceability. > Also, remove redundant work queue event in blocking function > mdp_cmdq_send(). > > Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver") > Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno