Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Sep 2022 17:01:03 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     viro@zeniv.linux.org.uk
Cc:     ebiederm@xmission.com, torvalds@linux-foundation.org,
        David.Laight@aculab.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, serge@hallyn.com
Subject: Re: [CFT][PATCH] proc: Update /proc/net to point at the accessing
 threads network namespace
Message-ID: <Yzb2nyYK94gcOKOR@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Precedence: bulk

Al wrote:

> Just to troll adobriyan a bit:
> 
> static const char *dynamic_get_link(struct delayed_call *done,
> 				    bool is_rcu,
> 				    const char *fmt, ...)
> {
> 	va_list args;
> 	char *body;
> 
> 	va_start(args, fmt);
> 	body = kvasprintf(is_rcu ? GFP_ATOMIC : GFP_KERNEL, fmt, args);
> 	va_end(args);

Ouch... Double pass over data. Who wrote this?

> 
> 	if (unlikely(!body))
> 		return is_rcu ? ERR_PTR(-ECHILD) : ERR_PTR(-ENOMEM);
> 	set_delayed_call(done, kfree_link, body);
> 	return body;
> }