Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <990c5782-2206-c012-d770-966887fd4515@foss.st.com>
Date:   Fri, 30 Sep 2022 16:18:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] usb: dwc3: st: Rely on child's compatible instead of
 name
Content-Language: en-US
From:   Patrice CHOTARD <patrice.chotard@foss.st.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Felipe Balbi <balbi@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Jerome Audu <jerome.audu@st.com>,
        Felipe Balbi <felipe@balbi.sh>
References: <20220930072707.516270-1-patrice.chotard@foss.st.com>
 <YzbXkDZnBqgbks1Z@kroah.com>
 <8a6122f8-6432-d160-5937-fa7df029c928@foss.st.com>
In-Reply-To: <8a6122f8-6432-d160-5937-fa7df029c928@foss.st.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/30/22 16:16, Patrice CHOTARD wrote:
> 
> 
> On 9/30/22 13:48, Greg Kroah-Hartman wrote:
>> On Fri, Sep 30, 2022 at 09:27:07AM +0200, patrice.chotard@foss.st.com wrote:
>>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>>
>>> To ensure that child node is found, don't rely on child's node name
>>> which can take different value, but on child's compatible name.
>>>
>>> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
>>>
>>> Cc: Jerome Audu <jerome.audu@st.com>
>>> Reported-by: Felipe Balbi <felipe@balbi.sh>
>>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>>> ---
>>>  drivers/usb/dwc3/dwc3-st.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
>>> index 166b5bde45cb..fea5290de83f 100644
>>> --- a/drivers/usb/dwc3/dwc3-st.c
>>> +++ b/drivers/usb/dwc3/dwc3-st.c
>>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>>>  	/* Manage SoftReset */
>>>  	reset_control_deassert(dwc3_data->rstc_rst);
>>>  
>>> -	child = of_get_child_by_name(node, "dwc3");
>>> +	child = of_get_compatible_child(node, "snps,dwc3");
>>>  	if (!child) {
>>>  		dev_err(&pdev->dev, "failed to find dwc3 core node\n");
>>>  		ret = -ENODEV;
>>> -- 
>>> 2.25.1
>>>
>>
>> This commit doesn't even apply to my tree.  What branch is it against?
>>
>> confused,
> 
> Sorry... a v3 will be send, rebased on correct branch.
> 
> Patrice
> 
>>
>> greg k-h