Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3876925rwb; Fri, 30 Sep 2022 09:28:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM66bcAvPpGKpCN6vfruF4Ll17m00BG1/f2yZOnUW/hL2sviNfodaWjC6yueVd6oO57aTqlO X-Received: by 2002:aa7:d397:0:b0:457:e4d5:c390 with SMTP id x23-20020aa7d397000000b00457e4d5c390mr8335209edq.7.1664555321714; Fri, 30 Sep 2022 09:28:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664555321; cv=none; d=google.com; s=arc-20160816; b=LnAel4P7JqBIYuCuW8Pe5FeLYLZ6G0KEgPi4+sowtLLvPWyaeQMYWAGn55h0H3YFBj QQLeZ+SYGNqJyEBPkxW3R0+LOMBMoxl2V7O12BmjGzNS7Ogg0U7vOXFxmTfZrbLeenIp zQkeL6KbnOaP/s3+quP8BwX/odK0B9zdmEsCad9wwJZBRHyTF99a4nMA8tJxuJBIQap3 aWhvAWlXY+axEKZP5oNjYUi5Lr/+0x4+t7WIU9OyWSTSaRlDrLsk+PeO1XYiSpPF4ugd oHZwu7642xIRPRP1okYETTSKXQPJfIrfHLLbV5BKtdm41hqguq36/ey5aOmNHff+WD4q S75w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RmD/few8vVZMC1rOPvBci3RyviR55HlRpa4UykCCmMc=; b=tu59N5TORZVVzMYj224xlp3/2UhuFZv4Frb/eG92Cj5AHXhZUQaWDVFta8lqwAY56S /N4fZTYKFMf75SIsfsThfAkI9aqXJWisjJ+oiQPo9BO1hT6y7N7D4VCIq4pMcqo3yy4V EuPVY3gaHJlTwqh6uGSqo1pk3Kcv6yL54tb789SlXpJ/1iVi5Mmzwx5mlFue6a80KLY+ Q41u1bN/zAYHpx3uARwmkmmHLWTI0aIVfW1SFK9SckhWM7f18p1AMCBsuhJjgpci5OTe dg9Bf7AY/ZdkuFaZNn1JCeT6Qmz1U5emIOr/ldCHndOCUoN8Hv8hzzjiyypAVxtqBRy1 vP5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b="T//csdDx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cy18-20020a0564021c9200b0045898894a73si628346edb.174.2022.09.30.09.28.15; Fri, 30 Sep 2022 09:28:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b="T//csdDx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231866AbiI3QHC (ORCPT + 99 others); Fri, 30 Sep 2022 12:07:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231771AbiI3QGx (ORCPT ); Fri, 30 Sep 2022 12:06:53 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D7618E6BC for ; Fri, 30 Sep 2022 09:06:49 -0700 (PDT) X-UUID: 3353579a0db54f039517fb1f23ec255e-20221001 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=RmD/few8vVZMC1rOPvBci3RyviR55HlRpa4UykCCmMc=; b=T//csdDxG4TbZVqEh7bOGLPwAg6h0BcEYpguZ+EXseknTE5g6LVNoomPkY6pJqAbLW9S80ByXT38ZWE6gGoCc6iVIARZgYsFuRtP2ORygVfBTzaW/T8GoBXmEfZmCVMrx0U0o9FIcAkEIZYrAg2ZzzoiaOdBPwMAQ553SQ0qvQ0=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:f7b4f9f4-35d8-4b1b-a641-aff6d06b2b43,IP:0,U RL:0,TC:0,Content:100,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:100 X-CID-META: VersionHash:39a5ff1,CLOUDID:e7b29907-1cee-4c38-b21b-a45f9682fdc0,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:801|102,TC:nil,Content:3,EDM:-3,IP:n il,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 3353579a0db54f039517fb1f23ec255e-20221001 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 896869728; Sat, 01 Oct 2022 00:06:43 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Sat, 1 Oct 2022 00:06:41 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Sat, 1 Oct 2022 00:06:41 +0800 From: Yongqiang Niu To: CK Hu , Chun-Kuang Hu CC: Jassi Brar , Matthias Brugger , , , , , Hsin-Yi Wang , Yongqiang Niu Subject: [PATCH v8, 2/4] mailbox: mtk-cmdq: instead magic number with GCE_CTRL_BY_SW Date: Sat, 1 Oct 2022 00:06:36 +0800 Message-ID: <20220930160638.7588-3-yongqiang.niu@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220930160638.7588-1-yongqiang.niu@mediatek.com> References: <20220930160638.7588-1-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY,URIBL_CSS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org instead magic number with GCE_CTRL_BY_SW Signed-off-by: Yongqiang Niu --- drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 88db6b4642db..04eb44d89119 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -133,7 +133,7 @@ static void cmdq_init(struct cmdq *cmdq) WARN_ON(clk_bulk_enable(cmdq->gce_num, cmdq->clocks)); if (cmdq->control_by_sw) - writel(0x7, cmdq->base + GCE_GCTL_VALUE); + writel(GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE); if (cmdq->sw_ddr_en) writel(GCE_DDR_EN | GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE); -- 2.25.1