Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Oct 2022 00:03:48 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Honglei Wang <wanghonglei@didichuxing.com>
CC:     K Prateek Nayak <kprateek.nayak@amd.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        "Tim Chen" <tim.c.chen@intel.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        "Juri Lelli" <juri.lelli@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        Yicong Yang <yangyicong@hisilicon.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Ingo Molnar <mingo@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] sched/fair: Choose the CPU where short task is
 running during wake up
Message-ID: <YzcTZBTF2H0udyk1@chenyu5-mobl1>
References: <YzUrITfUn96puCtv@chenyu5-mobl1>
 <a6e38a33-0003-d3ea-de9b-cf805aef647f@didichuxing.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <a6e38a33-0003-d3ea-de9b-cf805aef647f@didichuxing.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lVjWxiFG7Y5+O4hWFEcd2b0P8KXj87GnqqAD17ydl1BRUg4s+fKmsTAejCUb?=
 =?us-ascii?Q?J+h+7/oAk0/wltGXS6PDXRUWIrbGx1PS67GgyT5ghNnwS9sjEKk7L+iearGV?=
 =?us-ascii?Q?zzpakncRrtwPAXhFlBicN4iAU9pAaU6MtgdVw4u8b0PuDx7vuu5C+q02hzdY?=
 =?us-ascii?Q?w32G8LY+heV/2RBg4PlP4jaTBVbG1pebferraDrBlEiKVeoYfpn8e64BfD/b?=
 =?us-ascii?Q?hnSQ8YPADqvIHcR+ONWTD8RXzf+K3Gu+ewxfdjJh9qqN1vH3PgkkYbVJQO8n?=
 =?us-ascii?Q?03OEQ5zQWaBi5DFjt+3WEh8YtD/SIt/9pueT36HOoa1SUKSSiiDuctPOBHJr?=
 =?us-ascii?Q?y1kLoOjq/S8gN2VMktUfUDgjatQm6kM0LxqCCb78YgFuAzILb3KNc+nM80c5?=
 =?us-ascii?Q?GEXoXOs8UqDWfT54+/IdrFGhWiivuthdd4o8dX6HrrLiqXpp1XiQR8FFmLcU?=
 =?us-ascii?Q?L3eo1zJsW17XmxJMfGAAnBl6GbU7kfxaH5hL1XUU0cNI24alQMuox5uzVWuF?=
 =?us-ascii?Q?jaNmzLfb5xGDJcaMfSlL6HFHLcpGWrcP+T7LPXIGMzwx+wMbSUupZm91Y0qx?=
 =?us-ascii?Q?op6iGi7dYLddGKSkGjNTCdbMONzcI7s9cGotPLuU/pBiS5bivIjBiV+uqKjh?=
 =?us-ascii?Q?c5FfHuhwhXSzqxFwgVNyuoJgJTFAnYOBF+Eyrlk7ek7kTznemfjOVakj3YzE?=
 =?us-ascii?Q?fJ5DPY8DSUreYQ+HY/BNRfMp3magdksconGZpUUnSO/KKTdBUUGto2cN9kFN?=
 =?us-ascii?Q?W2zpTj7FD0nCk79Au5I7MbWZYQ5dRV9dNpQu2q9yu5SMX3tv40hy0eNfoGpG?=
 =?us-ascii?Q?fCAEZsBBngry2wiF4tCWrzwZEaOQkGfSqeLi0JZpn52xoIas0E+SBjZDoCY3?=
 =?us-ascii?Q?Js4x0EEWPZKOw0g9SA38Po1got04h5Gp8PNigyoF7dduDQifppHtG7n4nlPY?=
 =?us-ascii?Q?VLvf2anGbcKueRF3ooZlStOQd3bw019Q/FBGBwtWY8YpPg6nbT2WNYD0QxLZ?=
 =?us-ascii?Q?yuUlT7vw/LAxnMdoCSnx2IIHjLdY2H6eOz/sqFLhNJ2ysOM7ifGJoiBNn+qP?=
 =?us-ascii?Q?xLZg7UxgkiV0pTiPEmEO1Og0H6WcRgNfFpfJHCKWZJFCnwuwTijKz1iDb4/r?=
 =?us-ascii?Q?SxhNvIjOM7pxBmBiLiOcEE8OwlKKggXLiptaF4hA0WYhvRx6+N4gb+WxfE+H?=
 =?us-ascii?Q?c6E9TLJS4kT9aM95qpTg8P6CDYkH2PbUOXapKDgS14GSG/bQEuM5DKx1eY/a?=
 =?us-ascii?Q?V7ywDUkBfHPPnprh2l/Gra4HKk88JeiwliWJNwgZXboTIhfYu5o67D8ubkI3?=
 =?us-ascii?Q?Tn8xP1UAfzMNV+Ts8Yc1ioJD9daElJNId/8K5JulmRduVlKRXAhcEDGCoofv?=
 =?us-ascii?Q?+R5aw4iqhnM5o96BPyHZ/eszZrHzZjkFf53KhwiuOmASXcdq+n4Fp6m87OMJ?=
 =?us-ascii?Q?qb9u757oRIDccQ66Snq+qPz8vw+zw+dYh9cJdoP6ngMHL9JQuvR/V9uj2xbX?=
 =?us-ascii?Q?yisCS61PeaNr9zbgRz5pIsyjT+aIRK3+ecba8c45RWAQhqzr28rKNIXl2NSW?=
 =?us-ascii?Q?bHttL7IxbyvnL/KEm44VOGNWhsxtkBAZm9LgzoKv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2df38bba-e056-4a1a-51b5-08daa2fd692e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 16:04:10.3133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zg6LkgglbqeD1M03GUMHROuJr4VUFuwlpkA/zcDvVwdI3eF4/SWiF45lgRiOqdv3GI/Znz36tC0lachkM7BaKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6779
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-09-29 at 14:59:46 +0800, Honglei Wang wrote:
> > > > @@ -6050,7 +6063,8 @@ wake_affine_idle(int this_cpu, int prev_cpu, int sync)
> > > >   	if (available_idle_cpu(this_cpu) && cpus_share_cache(this_cpu, prev_cpu))
> > > >   		return available_idle_cpu(prev_cpu) ? prev_cpu : this_cpu;
> > > > -	if (sync && cpu_rq(this_cpu)->nr_running == 1)
> > > > +	if ((sync && cpu_rq(this_cpu)->nr_running == 1) ||
> > > > +	    is_short_task(cpu_curr(this_cpu)))
> 
> Seems it a bit breaks idle (or will be idle) purpose of wake_affine_idle()
> here.
Exactly, we should prefer previous idle CPU to 'potential idle' this_cpu to keep
it consistent.
> Maybe we can do it something like this?
> 
> if ((sync || is_short_task(cpu_curr(this_cpu))) &&
> cpu_rq(this_cpu)->nr_running == 1)
>
Yes, Prateek's experimental results has proven your suggestion.

thanks,
Chenyu
> Thanks,
> Honglei