Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220927225944.2254360-1-ankur.a.arora@oracle.com>
 <20220927225944.2254360-2-ankur.a.arora@oracle.com> <8171459.NyiUUSuA9g@x2>
In-Reply-To: <8171459.NyiUUSuA9g@x2>
From:   Paul Moore <paul@paul-moore.com>
Date:   Fri, 30 Sep 2022 14:22:53 -0400
Message-ID: <CAHC9VhR2AL9o6SKXW9xNJo5PW6T0CdTxbh8sy5OgE0ifY29RAg@mail.gmail.com>
Subject: Re: [PATCH 1/3] audit: cache ctx->major in audit_filter_syscall()
To:     Ankur Arora <ankur.a.arora@oracle.com>
Cc:     linux-audit@redhat.com, boris.ostrovsky@oracle.com,
        linux-kernel@vger.kernel.org, eparis@redhat.com,
        konrad.wilk@oracle.com, Steve Grubb <sgrubb@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Sep 30, 2022 at 1:45 PM Steve Grubb <sgrubb@redhat.com> wrote:
> Hello,
>
> Thanks for the detailed notes on this investigation. It really is  a lot of
> good information backing this up. However, there will come a day when someone
> sees this "major = ctx->major" and they will send a patch to "fix" this
> unnecessary assignment. If you are sending a V2 of this set, I would suggest
> adding some comment in the code that this is for a performance improvement
> and to see the commit message for additional info.

Please do not send a v2 with the changes Steve is suggesting, I think
this patch is fine as-is.

-- 
paul-moore.com