Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: multipart/mixed; boundary="------------FU96l4z8aYTBt923Pn9Octgz"
Message-ID: <101050d9-e3ec-8c21-5fb6-68442f51b39f@igalia.com>
Date:   Fri, 30 Sep 2022 15:31:17 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [REGRESSION][PATCH] Revert "pstore: migrate to crypto acomp
 interface"
Content-Language: en-US
To:     Ard Biesheuvel <ardb@kernel.org>, Kees Cook <keescook@chromium.org>
Cc:     linux-kernel@vger.kernel.org, regressions@lists.linux.dev,
        linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com,
        kernel@gpiccoli.net, Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        Thorsten Leemhuis <linux@leemhuis.info>
References: <20220929215515.276486-1-gpiccoli@igalia.com>
 <202209291951.134BE2409@keescook>
 <56d85c70-80f6-aa73-ab10-20474244c7d7@igalia.com>
 <CAMj1kXFnoqj+cn-0dT8fg0kgLvVx+Q2Ex-4CUjSnA9yRprmC-w@mail.gmail.com>
From:   "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <CAMj1kXFnoqj+cn-0dT8fg0kgLvVx+Q2Ex-4CUjSnA9yRprmC-w@mail.gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------FU96l4z8aYTBt923Pn9Octgz
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 30/09/2022 12:51, Ard Biesheuvel wrote:
> [...]
> 
> Does this help?
> 
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index b2fd3c20e7c2..c0b609d7d04e 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -292,7 +292,7 @@ static int pstore_compress(const void *in, void *out,
>                 return ret;
>         }
> 
> -       return outlen;
> +       return creq->dlen;
>  }
> 
>  static void allocate_buf_for_compression(void)
> 

Thanks a lot Ard, this seems to be the fix! Tested with lz4/zstd/deflate
in both ramoops/efi backends, and all worked fine. It makes sense,
outlen was modified in the previous API and not in the acomp thing, so
it was a good catch =)


>> Heheh you're right! But for something like this (pstore/dmesg
>> compression broke for the most backends), I'd be glad if we could fix it
>> before the release.
> 
> Yeah better to revert - this was not a critical change anyway. But I
> think the tweak above should fix things (it works for me here)

Agreed - in fact seems it was reverted already. More than that, I found
yet another small issue in the acomp refactor, a memory leak - attached
is a patch with the fix, feel free to integrate in your acomp refactor
when re-submitting (I mean, feel free to just integrate the code, don't
need to send it as a separate patch/fix).

I'm also working some fixes in implicit conversions in pstore that
aren't great (unsigned -> int in many places), I'll send some stuff next
week.

Cheers,


Guilherme
--------------FU96l4z8aYTBt923Pn9Octgz
Content-Type: text/x-patch; charset=UTF-8;
 name="pstore-Fix-memory-leak-after-the-recent-compression-.patch"
Content-Disposition: attachment;
 filename*0="pstore-Fix-memory-leak-after-the-recent-compression-.patch"
Content-Transfer-Encoding: base64

RnJvbSBjZjA1MTVkZWMxYTMzOWU3YjY0NGNiYWRhZjU4YmZiNTRjOWIyMGRmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiR3VpbGhlcm1lIEcuIFBpY2NvbGkiIDxncGljY29s
aUBpZ2FsaWEuY29tPgpEYXRlOiBGcmksIDMwIFNlcCAyMDIyIDEzOjQ1OjE4IC0wMzAwClN1
YmplY3Q6IFtQQVRDSF0gcHN0b3JlOiBGaXggbWVtb3J5IGxlYWsgYWZ0ZXIgdGhlIHJlY2Vu
dCBjb21wcmVzc2lvbiByZWZhY3RvcgoKRml4ZXM6IGU0ZjBhN2VjNTg2YiAoInBzdG9yZTog
bWlncmF0ZSB0byBjcnlwdG8gYWNvbXAgaW50ZXJmYWNlIikKQ2M6IEFyZCBCaWVzaGV1dmVs
IDxhcmRiQGtlcm5lbC5vcmc+ClNpZ25lZC1vZmYtYnk6IEd1aWxoZXJtZSBHLiBQaWNjb2xp
IDxncGljY29saUBpZ2FsaWEuY29tPgotLS0KIGZzL3BzdG9yZS9wbGF0Zm9ybS5jIHwgMSAr
CiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9mcy9wc3Rv
cmUvcGxhdGZvcm0uYyBiL2ZzL3BzdG9yZS9wbGF0Zm9ybS5jCmluZGV4IGQyNDRkYjhjODc5
ZC4uMTc2NWVhMTU3ZDM3IDEwMDY0NAotLS0gYS9mcy9wc3RvcmUvcGxhdGZvcm0uYworKysg
Yi9mcy9wc3RvcmUvcGxhdGZvcm0uYwpAQCAtNzQxLDYgKzc0MSw3IEBAIHN0YXRpYyB2b2lk
IGRlY29tcHJlc3NfcmVjb3JkKHN0cnVjdCBwc3RvcmVfcmVjb3JkICpyZWNvcmQpCiAJcmV0
ID0gY3J5cHRvX2Fjb21wX2RlY29tcHJlc3MoZHJlcSk7CiAJaWYgKHJldCkgewogCQlwcl9l
cnIoImNyeXB0b19hY29tcF9kZWNvbXByZXNzIGZhaWxlZCwgcmV0ID0gJWQhXG4iLCByZXQp
OworCQlhY29tcF9yZXF1ZXN0X2ZyZWUoZHJlcSk7CiAJCWtmcmVlKHdvcmtzcGFjZSk7CiAJ
CXJldHVybjsKIAl9Ci0tIAoyLjM3LjMKCg==

--------------FU96l4z8aYTBt923Pn9Octgz--