Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Sep 2022 22:01:35 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Shenwei Wang <shenwei.wang@nxp.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Wei Fang <wei.fang@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX
 buffers
Message-ID: <YzdLHx+N4SXaAkUe@lunn.ch>
References: <20220930193751.1249054-1-shenwei.wang@nxp.com>
 <YzdI4mDXCKuI/58N@lunn.ch>
 <PAXPR04MB9185E69829540686618987D289569@PAXPR04MB9185.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <PAXPR04MB9185E69829540686618987D289569@PAXPR04MB9185.eurprd04.prod.outlook.com>
Precedence: bulk

> The testing above was on the imx8 platform. The following are the testing result
> On the imx6sx board:
> 
> ######### Original implementation ######
> 
> shenwei@5810:~/pktgen$ iperf -c 10.81.16.245 -w 2m -i 1
> ------------------------------------------------------------
> Client connecting to 10.81.16.245, TCP port 5001
> TCP window size:  416 KByte (WARNING: requested 1.91 MByte)
> ------------------------------------------------------------
> [  1] local 10.81.17.20 port 36486 connected with 10.81.16.245 port 5001
> [ ID] Interval       Transfer     Bandwidth
> [  1] 0.0000-1.0000 sec  70.5 MBytes   591 Mbits/sec
> [  1] 1.0000-2.0000 sec  64.5 MBytes   541 Mbits/sec
> [  1] 2.0000-3.0000 sec  73.6 MBytes   618 Mbits/sec
> [  1] 3.0000-4.0000 sec  73.6 MBytes   618 Mbits/sec
> [  1] 4.0000-5.0000 sec  72.9 MBytes   611 Mbits/sec
> [  1] 5.0000-6.0000 sec  73.4 MBytes   616 Mbits/sec
> [  1] 6.0000-7.0000 sec  73.5 MBytes   617 Mbits/sec
> [  1] 7.0000-8.0000 sec  73.4 MBytes   616 Mbits/sec
> [  1] 8.0000-9.0000 sec  73.4 MBytes   616 Mbits/sec
> [  1] 9.0000-10.0000 sec  73.9 MBytes   620 Mbits/sec
> [  1] 0.0000-10.0174 sec   723 MBytes   605 Mbits/sec
> 
> 
>  ######  Page Pool impl?mentation ########
> 
> shenwei@5810:~/pktgen$ iperf -c 10.81.16.245 -w 2m -i 1
> ------------------------------------------------------------
> Client connecting to 10.81.16.245, TCP port 5001
> TCP window size:  416 KByte (WARNING: requested 1.91 MByte)
> ------------------------------------------------------------
> [  1] local 10.81.17.20 port 57288 connected with 10.81.16.245 port 5001
> [ ID] Interval       Transfer     Bandwidth
> [  1] 0.0000-1.0000 sec  78.8 MBytes   661 Mbits/sec
> [  1] 1.0000-2.0000 sec  82.5 MBytes   692 Mbits/sec
> [  1] 2.0000-3.0000 sec  82.4 MBytes   691 Mbits/sec
> [  1] 3.0000-4.0000 sec  82.4 MBytes   691 Mbits/sec
> [  1] 4.0000-5.0000 sec  82.5 MBytes   692 Mbits/sec
> [  1] 5.0000-6.0000 sec  82.4 MBytes   691 Mbits/sec
> [  1] 6.0000-7.0000 sec  82.5 MBytes   692 Mbits/sec
> [  1] 7.0000-8.0000 sec  82.4 MBytes   691 Mbits/sec
> [  1] 8.0000-9.0000 sec  82.4 MBytes   691 Mbits/sec
> ^C[  1] 9.0000-9.5506 sec  45.0 MBytes   686 Mbits/sec
> [  1] 0.0000-9.5506 sec   783 MBytes   688 Mbits/sec

Cool, so it helps there as well.

But you knew i was interested in these numbers. So you should of made
them part of the commit message so i didn't have to ask...

     Andrew