Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4117506rwb; Fri, 30 Sep 2022 13:08:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4raayLKj1T3y5YlWyPtPpi3whbUWvLPaTb06pOqTJ1BSpyHfqsHs/o95yHJppBol25qZPs X-Received: by 2002:a17:907:320c:b0:741:1e55:7a69 with SMTP id xg12-20020a170907320c00b007411e557a69mr7743577ejb.740.1664568510916; Fri, 30 Sep 2022 13:08:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664568510; cv=none; d=google.com; s=arc-20160816; b=nn1ny6muMCMjKww2MgKBBPN4vlmAps5FbCPsc0k70V/GMeArGK/65OE36EoNM7n+nd Czj1L925/uk9vhj8NXz8Mf+/AwH1FctpGKcNY2WqV2VoFK+ZHRRuaAJQYh8dAfgRTRoK Ad7RJ0v4kNaZ6jBHYJK5ZfkOEGq33P0+1evvrEBI436XLZLtHccqXseA//Kc+JtpNsAA m56Z0pxfeDq1waA8qLrZ6bywJAoV/Etih098bkHC0+dh9VcseXwf3DMeA0enKgWOXdKf fqFRKWWURvubaYIiizDo+rh1OqN2ymSIiY8cY9k+aJP7qwSziklHrO3AjUsN42DpXM4Y JotQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3wBAxhax4uWBF7eHB1eqflHZ4cetLSZp3Uc2jtSpOag=; b=OmylHBMtpJAZVdijBiSOAaCIJ9mzMvE8fsoFJGOBN32Pk+oy0Jkz+tSrTypX3XRdA/ calYdmjqspHE3A+kzViTlKns5PJj0Xtm3M21Q85qa/sWq/vwcLv3wbsTgs+GNeNU2jQs ANDSEgr4jZn+MCT9c3iHwlGJEMR8Bh5/oF6hZ2oFkKMa22vLXd2EV7Z/vr6rh61FIzVU c74xiz39Qf72C4srqrPySF52pqd4uBfmov3/hZrJ7oYFoygAzKBqI4Allc23OZxz3vwC y+Q9+v2Dx3Pl4DqybADAbaMoSVXGtM7rPvcNQg+MG1OXICn6lSIrh48IMZXwr9NnZtzP B8xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=x3x61AMx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id re7-20020a170906d8c700b0077076dec2cdsi2189298ejb.907.2022.09.30.13.07.35; Fri, 30 Sep 2022 13:08:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=x3x61AMx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232020AbiI3UFQ (ORCPT + 99 others); Fri, 30 Sep 2022 16:05:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbiI3UFN (ORCPT ); Fri, 30 Sep 2022 16:05:13 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73918DD369; Fri, 30 Sep 2022 13:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=3wBAxhax4uWBF7eHB1eqflHZ4cetLSZp3Uc2jtSpOag=; b=x3x61AMxA1kRtzrCpZ2242ZDAG 0WlkEYPLDNmJ5oVUPtsBT4y6Sls/ZFbxLwJtC0OM5XIL5EwVfzJQ77XxST6Be81BU7LxKvA45qVO/ KhE+SotUt+7uAZjOqQ8jM+9hPTMKqzDjS3EF5y0Bw1ch9s4ZH1mG7GFkP6784wM7YGcc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oeMFo-000jtR-Kq; Fri, 30 Sep 2022 22:05:00 +0200 Date: Fri, 30 Sep 2022 22:05:00 +0200 From: Andrew Lunn To: Shenwei Wang Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wei Fang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH 1/1] net: fec: using page pool to manage RX buffers Message-ID: References: <20220930193751.1249054-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220930193751.1249054-1-shenwei.wang@nxp.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -static bool fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb, > - struct bufdesc *bdp, u32 length, bool swap) > +static bool __maybe_unused > +fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb, > + struct bufdesc *bdp, u32 length, bool swap) > { Why add __maybe_unused? If its not used, remove it. We don't leave dead functions in the code. Andrew