Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Wei Fang <wei.fang@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX
 buffers
Thread-Topic: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX
 buffers
Thread-Index: AQHY1QQs3moef3i30kelaD3cHlhvbK34Zc4AgAAAZbA=
Date:   Fri, 30 Sep 2022 20:07:55 +0000
Message-ID: <PAXPR04MB91850A034871650CB6C4F86D89569@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20220930193751.1249054-1-shenwei.wang@nxp.com>
 <YzdL7EbnULEA75/s@lunn.ch>
In-Reply-To: <YzdL7EbnULEA75/s@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LHbYUp7h1an/JdLcgEDF9KGXWk/t+2w5AopwVejqy3xHHUn4QBzSNldWjk4L?=
 =?us-ascii?Q?Rj05NLbtvdUAFTljlGAFvUQ8EqpadyUlsaHIg3H39kHb+5eJrD5IQ5SUZhrU?=
 =?us-ascii?Q?26tBpyFM0UJjwNnYcNB+KVBQukfyMjohxONDJU0W2VPJeBBZWRctS8L2KV2V?=
 =?us-ascii?Q?Sj/k2HVMGehMxor392U4fX3MzPyrQbXjOgBYNqYlo85nYsoS1qMdazqyrxm4?=
 =?us-ascii?Q?gknHIHwXLAIHhOIn8S7BYL8sN5VjJ9npPWnaqH1Ek+JriB4CdRW83LpCJzq7?=
 =?us-ascii?Q?R1SBW6ayZvrdcdcb7gfa7Wq0mrBfytEI3EEouFfPsrULd9MJztMv+Co74xU1?=
 =?us-ascii?Q?LjI9bj7rIFFwkXLLkv9NGsLSRI9/Vcu5+JdmliO9zkg7XCbcSYimO4mYz2pS?=
 =?us-ascii?Q?YK2FjnLaC0N6aLPdGVX8KAT3dQv35z2aoGBu2ohU6g5IaO/MS2APAEjVVRU/?=
 =?us-ascii?Q?dHTw3sXKWOjS1hIfQWdMjW1znljwCsSWNfjWt1996xgbPFbdXk6PGBt0Lb8F?=
 =?us-ascii?Q?NnpPTSkUQfxHQqP0vltaEJczHc3Xm21mscYpIBJNZn2XUlJoIjgX3zTv+M4d?=
 =?us-ascii?Q?Di+Zv0K95cOLsM92/1VK33t269MIIV1DhhbzNLvEK6rbZMhreHVVp9wLWOsj?=
 =?us-ascii?Q?PA9lvOEi2+CcxCX6rX0tm/kaovhqSD3t+jFB1NpwxS2T5hLEgeXnG44TUYtQ?=
 =?us-ascii?Q?Rz/W9Y4jpfaxzwAzKTnt8RKK6V1tFp2PhRXYgF5MKh++ZuK2gYdeDWeyzylN?=
 =?us-ascii?Q?iavShQRUAzA9iCzU+WXyWN4V8+acbKFrmvChAosc0B9jgZ/05QiSY2ZEij9B?=
 =?us-ascii?Q?Nyj7s3yf9MUjxHQpPs880YiWHqqCBkKC6hh10uOGTDI0vsmN79g/3W7OUQUU?=
 =?us-ascii?Q?T2Mqnhg7WsE4HieUwVzUnK8VnZa4ubE6GB9JG1aD8w7REA87Gkt8AE/++e6m?=
 =?us-ascii?Q?khHmYplY6YRwR37BVRNwUcEsLZI8zLlcqNxI3dEWlfy/77v0vNiqAZ7gg5ff?=
 =?us-ascii?Q?70Liy2luNzxQBE1Y55RxWCw5UuHEc1LSM+jjjwpf1WebWiZi3JU4sLsj1p/8?=
 =?us-ascii?Q?nxu+0CBmBswA0Lwwb4IycoX4n4zoOOQ4BoDI43at7ZCma9DWYfJKaPN6YmBm?=
 =?us-ascii?Q?zczkDIDsekSypvEdyIM9zngW/bT4fWweYA0ZYq9+gV7Gvx+pZVsIO/A8ftnM?=
 =?us-ascii?Q?JQZw0XxaMbkZnLbuuHD+h1tmdPeaLw5XT4r0frMM443/Cui5TvKJ5yHGKmiE?=
 =?us-ascii?Q?rV+YSqkqyVDSVc4fvMIlLoRaWf6PEmvujFJNahZ1CIKNPI6Tp4id6tzyrxdW?=
 =?us-ascii?Q?231Ys4BmHepnArXUfRkYE6DH4AHWMGzPwP9GEZqUCEBRq5L4xDy+CqLkGZ6p?=
 =?us-ascii?Q?ZlSrpjpzefnUZ1zZyeR7lLkXWAFfAwpLjemIeTxNyMQ5+2oBkIww7vCjRGao?=
 =?us-ascii?Q?b35w/y3GNOzqXHrep9dxjyMk8EHr3LJ2/8E1eeuXm5PF5qfbsEKlzpp9eW5K?=
 =?us-ascii?Q?hUfOWz09IIdomPJxIsy40KCz9Dh3/XYSDbKjJ1iyeWJLFmqvMAmireiT8+WD?=
 =?us-ascii?Q?h9z6ctThB0gvTnuZwkzyhiKWd/WAvUE68RvB+JyG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ade864d7-cfd5-4a5f-7958-08daa31f765f
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 20:07:55.1003
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YjKCElEI6TXoEPYBdTK1fnlXOopfeHlNZkp5VRVWCI8VgdqTICmqNdTPR38MeQDXZXBDOJ/3x37J0SdmWVx91w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8064
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Friday, September 30, 2022 3:05 PM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: David S . Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Alexei Starovoitov <ast@kernel.org>; Daniel Borkmann
> <daniel@iogearbox.net>; Jesper Dangaard Brouer <hawk@kernel.org>; John
> Fastabend <john.fastabend@gmail.com>; Wei Fang <wei.fang@nxp.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX buf=
fers
>=20
> Caution: EXT Email
>=20
> > -static bool fec_enet_copybreak(struct net_device *ndev, struct sk_buff=
 **skb,
> > -                            struct bufdesc *bdp, u32 length, bool swap=
)
> > +static bool __maybe_unused
> > +fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> > +                struct bufdesc *bdp, u32 length, bool swap)
> >  {
>=20
> Why add __maybe_unused? If its not used, remove it. We don't leave dead
> functions in the code.
>=20

I was thinking to remove them by a separate patch once the page pool soluti=
on is accepted.

Regards,
Shenwei

>      Andrew