Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4136555rwb; Fri, 30 Sep 2022 13:27:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4XbGxD4RdgfPPdIp124eHsO7OsK2woGv/eP7CPOsP18NNZh6FZe/lrSajobysxPIbHryA2 X-Received: by 2002:a17:902:c403:b0:178:2c52:dacc with SMTP id k3-20020a170902c40300b001782c52daccmr10597548plk.84.1664569655563; Fri, 30 Sep 2022 13:27:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664569655; cv=none; d=google.com; s=arc-20160816; b=tZ26hR4nUyGonHqiwD+TiFusBd5eVTq2zFig/klf+dM/dpBRaIAIz2TPxjC4m0f/fd jeiMqKRUbLC0+X2q7Yq2LMrUNHWb8z6OvgsQWCCbMk98IXKnENZd5Pllc2TkOeWw6r4K 2HUq3FKbAfGRblHAquIUqMTUqTtHIecIr85WFMF8+z4EOJPGSdeyhDUPrpDSjRMOce+Q y6Ii8xB6b2Sv07gLi/pDSeu4XpUkxJWPUb2N419PkMpSbVDAxVhbjjZc64UuA/P/PCTl ZQE3Hzzc1F3YaRg0gY0vIN+7Gc4U5BnaXeXaLzebBKhiwYAdaRqiEeE/r4XMym6/L5A9 LaCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=2UOIDLCxXn8nlZS1RvhXbLtzKWNYWJRmQPCH/1+uI0k=; b=TCHgiK0FCjoW5caZnnz4vXXbiJu2be6vxEhQeQhfCUkOwqyykT6wsO4Svz/a9b2VUe AHwkYNuPaFd+sLW6yNisp9th9T9Q4rwj6x6Rc7Gq9YQPxXLj9Utv3CdUg5XRjs2ReDxe K+SlZBHO56idJfubTwqXbjXHl+q3axqHf+e1jUOj2XITVSREtJbEftMaseW3alY+4+CH 6sk/Bwma0Vs2IoihXP89e1KGb6H1HkpPrwfgo5qid7G4maVHlU6sFyxLhdyj2gwI5/3d 03p8+2kn1Sdnua8RbPpAWUZbyBMBdRfb79qVCzH9hl8QmdWHu4rgkYg6QlxS/QSN5Eg6 jk2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NqQSgJkK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k12-20020a170902c40c00b00177f7fe8ea9si3988371plk.188.2022.09.30.13.27.23; Fri, 30 Sep 2022 13:27:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NqQSgJkK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231673AbiI3UTM (ORCPT + 99 others); Fri, 30 Sep 2022 16:19:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232154AbiI3UTK (ORCPT ); Fri, 30 Sep 2022 16:19:10 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947ABD111 for ; Fri, 30 Sep 2022 13:19:08 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id f21so1563981lfm.9 for ; Fri, 30 Sep 2022 13:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=2UOIDLCxXn8nlZS1RvhXbLtzKWNYWJRmQPCH/1+uI0k=; b=NqQSgJkKwJmtckcOveuSVN8bGw1W5YcduOLF3v9AjNf6y9e3duZIF/Mmx4CtNLYuW/ X9adfRyjRILFCNQEsbY6vaRuY+N0i2RtD9AvfXOOPleem4LcsCObB7zNj9X5wmAq79/e vxpj7aoo+PGOib+uofCTcyzRVvgSQinCIaSjeQO1agdtSx62W0tLCtM2p/Sg2p5nXmiY bgI1/j9qDTBUO9AGnqfdH8gt4+XnEWEhx6moJySbI960MjjrNCvDs2MUZqoBaVDPKrJn upK6LHMlkqE299eP/SiQWSasCgUvhbDFPyXUJXNOjkulp41MaNSgpFl67KINHLQTggFh xTzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=2UOIDLCxXn8nlZS1RvhXbLtzKWNYWJRmQPCH/1+uI0k=; b=xQymhY2zhmyS2Fb43ERPZXYVdQbcVjDu541IF+qJlE9k597xbLf5Gh1/CD48geCqip bFUpHGloVheTk15eVsbCmSX/ci+W6V5NKYUIg+fwAAUTOt2eSa2updfgKUClcJT1WYcQ +l8u2fm05a6KhRqXnB3yx/VRExNtIlGaX9N+ecyB5/i/CCGkj1C52OMVsygN2NSN1IVt D069gQFdK3L5l92JpUQO61uEW4pC6dG/lEpQhXQPGRaCQVoiB822tc9w9wDx71gUrf2H lyNE2pWglbBwL7fGe6z8KB9xlIdCjYg2lQnMrtF3ukkl/R/R2WJkW2kxkze+dhVFLUtb yDTw== X-Gm-Message-State: ACrzQf0rQdePR7dv9KEMFx+InykaMYroWAEsM2ICJDuYnHHDbxfXNk4K ak6AOI3alK/M/+Y5dBdLe7JrxA== X-Received: by 2002:a05:6512:1152:b0:4a0:5555:15ee with SMTP id m18-20020a056512115200b004a0555515eemr4241751lfg.38.1664569147001; Fri, 30 Sep 2022 13:19:07 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q3-20020a0565123a8300b004972b0bb426sm407342lfu.257.2022.09.30.13.19.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 13:19:06 -0700 (PDT) Message-ID: <1dfd2858-cc30-5cc0-0b2a-209a8bf8bace@linaro.org> Date: Fri, 30 Sep 2022 22:19:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845: align TLMM pin configuration with DT schema Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220930200529.331223-1-krzysztof.kozlowski@linaro.org> <20220930200529.331223-2-krzysztof.kozlowski@linaro.org> <2b1a536f-fd84-831a-8b0a-9c0cce5e6421@somainline.org> From: Krzysztof Kozlowski In-Reply-To: <2b1a536f-fd84-831a-8b0a-9c0cce5e6421@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/09/2022 22:13, Konrad Dybcio wrote: > > > On 30.09.2022 22:05, Krzysztof Kozlowski wrote: >> DT schema expects TLMM pin configuration nodes to be named with >> '-state' suffix and their optional children with '-pins' suffix. >> >> The sdm854.dtsi file defined several pin configuration nodes which are > 845 > >> customized by the boards. Therefore keep a additional "default-pins" >> node inside so the boards can add more of configuration nodes. Such >> additional configuration nodes always need 'function' property now >> (required by DT schema). > Would it not make more sense to drop this and keep the properties in the > root node while at it? > > Konrad Not possible, because the boards set different bias/config for the pins: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845.dtsi?h=v6.0-rc7#n2988 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845-mtp.dts?h=v6.0-rc7#n729 Best regards, Krzysztof