Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4155290rwb; Fri, 30 Sep 2022 13:48:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4oYH2VYCwuw/6bm2Arg4Ad4HYh5weQfXvVFP55IIcWNHZFV5ceedf5N9CtZ2GU0KdXtzEx X-Received: by 2002:a05:6402:154f:b0:458:9e48:1650 with SMTP id p15-20020a056402154f00b004589e481650mr1650567edx.201.1664570907885; Fri, 30 Sep 2022 13:48:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664570907; cv=none; d=google.com; s=arc-20160816; b=WkM9E2/hV7DDUc2z5cHIJ/KS/fXxaXg96lBctkKvaULz+1FhwNcV2ITje7qLuZLjeD Cgl1cnkPyw3zHBfPvk80d3BgxWFnM5iSQbK1IUwy/eBm5bnNpxfxghi2A0vaakZS+Fe6 wgx1sbIhaTBkIn2yfLuEMoKLMTNz1/Etq1UDAVTniMHfTkFxDNwpNyCqRHHGSMUd88e8 pAB2UBe2z1KgsX9ysRcPmauAU7hVNA9LOkdAWcau3Ik2ABSUPiy1qXiqx4T+606l8V03 dWF3zGYyQEljfSVXeispdVbu9uaJTBilY1nw4VFonuMeOB2A9Lhii5MjStt7o1qavYou 3f/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=di00yE59xgGe3SfeGbzMrJCdN+peh8jRKr1uXPXXC/8=; b=yj0jItttztwmD70US5/CdOpkz1SqEIpe1epY8h4B9rAo3JkQhZ3U7wIfEc2qyKTCd3 5Z9t+mr618yFkNZebaCVrMVy1jTQRJkocqdEdWdk4G3i+0QTuDB15Pu3jGG0M7Kz0esc XcWL+Tmc46GBVElzBL5fY0vm3scEcUz+yRiJOynmALnKE5QnoUzVIMF08OTw+op+Hr78 niubYlF/GyTq8qHqdRkPIk0r0ezeTaHkwjDwwnJMDUtxpkmqTUguFuhSMAzFHQIb+2S7 60Gzl8FlXUwnE8DcSKjq4+MCNIWZtSYoaPCcaAATWa3eh2qGNCOCWZIVa/AHqL+VJZLL qrUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BQqZR+qJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hg7-20020a1709072cc700b00741559ff58dsi2522498ejc.787.2022.09.30.13.48.02; Fri, 30 Sep 2022 13:48:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BQqZR+qJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbiI3Uo2 (ORCPT + 99 others); Fri, 30 Sep 2022 16:44:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231540AbiI3UoZ (ORCPT ); Fri, 30 Sep 2022 16:44:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94D991F44D7; Fri, 30 Sep 2022 13:44:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32DB9624E1; Fri, 30 Sep 2022 20:44:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 423ABC433D7; Fri, 30 Sep 2022 20:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664570663; bh=lc2jy/ARQK6H8XqERFtcJ4MlYmpDmbHzUwDa9LqMQbc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BQqZR+qJCgmLawIXUz3YOw6zYW1uUaFuND3aFIOpRxsCfiZVyz1XsdfaNBZLMdzt2 1InS/vBL/EsNCcsEq35vvfCoQcCtzg/5O1DtH11kCA8QTvEDO6+5/8bCUsgSNdf2Hq rTg2OQCYasda2yzUM+Hg1EP+Kcx9zhAmBys1iQKRmPmkEJQ9QC4p4BdwkMKH/0imRE 6XhDISe2jy1m2qbSIfqLBqGKtto6RDAE3NbovB4Ddr4FVGCrQ8DQmfGE7iypZOT5EN 27+zdcIjsm5IE2/KsD32fFjYUfCTyAFh0JKViTwfD3bkQGNuenLq27uW965axxZeI5 bIW1ATvH/mcnA== Date: Fri, 30 Sep 2022 23:44:21 +0300 From: Jarkko Sakkinen To: Dmitry Torokhov Cc: Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe Message-ID: References: <20220926053958.1541912-1-dmitry.torokhov@gmail.com> <20220926053958.1541912-3-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926053958.1541912-3-dmitry.torokhov@gmail.com> X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 25, 2022 at 10:39:58PM -0700, Dmitry Torokhov wrote: > Driver core will never call driver's probe method without appropriate > device structure, so testing them for NULL is pointless. > > Signed-off-by: Dmitry Torokhov Missing a description what the patch does. Also instead of "driver's probe method" you could just use "st33zp24_i2c_probe()". It's even shorter. BR, Jarkko