Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4174509rwb; Fri, 30 Sep 2022 14:09:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6uRymP/rcm/QNllxYsaKLuJNS7Fo7i0Whf7nHEYqGi2zyangCR7HDZj7paikRcsFn/Z70/ X-Received: by 2002:a17:903:124c:b0:179:da2f:2463 with SMTP id u12-20020a170903124c00b00179da2f2463mr10554535plh.128.1664572143736; Fri, 30 Sep 2022 14:09:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664572143; cv=none; d=google.com; s=arc-20160816; b=YpBcCG1/uKVYNJQ47Fr8ntVK7MktpV2NN5cNlNNHFbJkaO2WfVbW1KHltiE3a0OhQw lWHa3x01l2lBz3uw4p6VZqBLuguDz7T4z8DuOZxnOPKQ+eB80HfaEw0pMyj7eH7BAqk8 HGmNucJJCIGbMMprAuU/CrutaTJEqLFgCyGUdISDWTxlYoR9iAQINnf7XG+bgSf55LCI mZC1RYm3tbFQ7NZn97MTUw22UbqsEY8QAQpwCd0U0UHV71Q+0Z4UGNrFlBnraA/VYQqn qXgyXDkuDhd0zxOGTBYmXsQILv8wo7sKnFiCDcmKr1jtR+jXeHtkKIgQTH4xn9JjGBfZ STEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EpUP/qbhlc6lK72+8vKV5oTpsI2G3aecCfJLJc2JTxQ=; b=vpB+il60jRCgjfv/4ijKaEWB21f6YjOOW4JD/7Ucfe5bope/jG+q18NuHcAwc7OYtn MDReA2CNi8SDfUWFMMjuECKMlgmtmugq6eWnc14ol6XMtqLhcN5S/WyM2b51MyZyegLD E2o+Ld//N77qGOSP/ZSwKOhjlZ6Powe+ZGvQckJJMxN42Q1bc9z2z027XtfTppLC6jiF dH0zMaHz7dXVziQxuQlMrocRc1YaQ+2n1C/2I6O4H3hloyytHGqUg5xk/k+lAhz55r6O Nnn+jG0WxbqqmE3jWGNq4gR5zZ09G+D98HukBUlLZe2l1xgENppFjhWIkRWgI5Lp7cmy 70+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k+7HWejQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e1-20020a636901000000b00439398fcb63si2353392pgc.24.2022.09.30.14.08.50; Fri, 30 Sep 2022 14:09:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k+7HWejQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbiI3UjQ (ORCPT + 99 others); Fri, 30 Sep 2022 16:39:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbiI3UjN (ORCPT ); Fri, 30 Sep 2022 16:39:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57D6A1A88E6; Fri, 30 Sep 2022 13:39:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1AF3FB82963; Fri, 30 Sep 2022 20:39:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73039C433C1; Fri, 30 Sep 2022 20:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664570349; bh=EpUP/qbhlc6lK72+8vKV5oTpsI2G3aecCfJLJc2JTxQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k+7HWejQzP92VOW9zyOwfw/A/3PLGzITW2ncVDLWc/QqwBPNeFy9+2uPWgKXpnq6l ElPvtZzqOgCutLKV9WK1ubn9/5K9F25Xa0G93sMj3wityeHNd2RoprEcLJNVJsW+RC iytHCZ0lpYdu+csoY1HX+zz2yB+aYQZx5NXZT7RL+gln26BCwW5rbJztdyzcSP//sn nbYdTkCJrgOhYLzuNhmap5WeeV7c6ClD2tDnlb1Be7+vH1FWptBGfuKjj1Nka/yjkZ focLPMkRtkUu9EbTnoosjOoBrec3/kYsguz+SPU3XSsu6Oq2s8arz9hs6Jdb6/rsbx I3yBV44Y30TUQ== Date: Fri, 30 Sep 2022 23:39:06 +0300 From: Jarkko Sakkinen To: Dmitry Torokhov Cc: Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] tpm: st33zp24: drop support for platform data Message-ID: References: <20220926053958.1541912-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926053958.1541912-1-dmitry.torokhov@gmail.com> X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 25, 2022 at 10:39:56PM -0700, Dmitry Torokhov wrote: > There are no users of st33zp24_platform_data in mainline, and new boards > should be using device tree or ACPI to describe resources, so let's drop > support for platform data from the driver. Nit: drop instead of let's drop (needs also different sentence structure obviously). Also, please leave predictions out, or back them up with data. It's good enough reason to remove code, if it is not used for anything. I really don't care about "should" part. It is is out-of-scope for a kernel patch. BR, Jarkko