Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220929225402.9696-4-Sergey.Semin@baikalelectronics.ru>
References: <20220929225402.9696-1-Sergey.Semin@baikalelectronics.ru> <20220929225402.9696-4-Sergey.Semin@baikalelectronics.ru>
Subject: Re: [PATCH RESEND v12 3/8] clk: baikal-t1: Add shared xGMAC ref/ptp clocks internal parent
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-clk@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     Michael Turquette <mturquette@baylibre.com>,
        Serge Semin <Sergey.Semin@baikalelectronics.ru>
Date:   Fri, 30 Sep 2022 14:25:27 -0700
User-Agent: alot/0.10
Message-Id: <20220930212530.7BA97C433C1@smtp.kernel.org>
Precedence: bulk

Quoting Serge Semin (2022-09-29 15:53:57)
> Baikal-T1 CCU reference manual says that both xGMAC reference and xGMAC
> PTP clocks are generated by two different wrappers with the same constant
> divider thus each producing a 156.25 MHz signal. But for some reason both
> of these clock sources are gated by a single switch-flag in the CCU
> registers space - CCU_SYS_XGMAC_BASE.BIT(0). In order to make the clocks
> handled independently we need to define a shared parental gate so the base
> clock signal would be switched off only if both of the child-clocks are
> disabled.
>=20
> Note the ID is intentionally set to -2 since we are going to add a one
> more internal clock identifier in the next commit.
>=20
> Fixes: 353afa3a8d2e ("clk: Add Baikal-T1 CCU Dividers driver")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>=20
> ---

Applied to clk-next