Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iac594737:Fastmail
Date:   Fri, 30 Sep 2022 18:22:48 -0400
From:   Demi Marie Obenour <demi@invisiblethingslab.com>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Kees Cook <keescook@chromium.org>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0
Message-ID: <Yzdsc0FeGNk6h/me@itl-email>
References: <cover.1664298147.git.demi@invisiblethingslab.com>
 <5649176eacda434267f68676f1733d06c572d19e.1664298147.git.demi@invisiblethingslab.com>
 <CAMj1kXEs-o8jvNqRiW+Ue2i52RBgg4iktg8UONCACk8-Gx4XXA@mail.gmail.com>
 <YzczpIYop5olD4hj@itl-email>
 <CAMj1kXHGPzy9T1LcE8LX+woGtUGTzrDgbjDBJabJ+bwDVPbTag@mail.gmail.com>
 <YzdPv4+fYX3SG9P0@itl-email>
 <CAMj1kXGTZZmW=QZOL1FvrsBLsvFzN1GkvZCotuZ-C-gBVGY6CQ@mail.gmail.com>
 <CAMj1kXFJa4sSDEkRwTXTntJcJrtshNofU6LaZOWtzMbp56cXXQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="O0m4X08RcO4y0b4+"
Content-Disposition: inline
In-Reply-To: <CAMj1kXFJa4sSDEkRwTXTntJcJrtshNofU6LaZOWtzMbp56cXXQ@mail.gmail.com>
Precedence: bulk


--O0m4X08RcO4y0b4+
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 30 Sep 2022 18:22:48 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-efi@vger.kernel.org
Subject: Re: [PATCH v4 2/2] Support ESRT in Xen dom0

On Fri, Sep 30, 2022 at 11:24:37PM +0200, Ard Biesheuvel wrote:
> On Fri, 30 Sept 2022 at 22:59, Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Fri, 30 Sept 2022 at 22:21, Demi Marie Obenour
> > <demi@invisiblethingslab.com> wrote:
> > >
> > > On Fri, Sep 30, 2022 at 09:11:19PM +0200, Ard Biesheuvel wrote:
> > > > On Fri, 30 Sept 2022 at 20:21, Demi Marie Obenour
> > > > <demi@invisiblethingslab.com> wrote:
> > > > >
> > > > > On Fri, Sep 30, 2022 at 06:36:11PM +0200, Ard Biesheuvel wrote:
> > > > > > On Fri, 30 Sept 2022 at 01:02, Demi Marie Obenour
> > > > > > <demi@invisiblethingslab.com> wrote:
> > > > > > >
> > > > > > > fwupd requires access to the EFI System Resource Table (ESRT)=
 to
> > > > > > > discover which firmware can be updated by the OS.  Currently,=
 Linux does
> > > > > > > not expose the ESRT when running as a Xen dom0.  Therefore, i=
t is not
> > > > > > > possible to use fwupd in a Xen dom0, which is a serious probl=
em for e.g.
> > > > > > > Qubes OS.
> > > > > > >
> > > > > > > Before Xen 4.17, this was not fixable due to hypervisor limit=
ations.
> > > > > > > The UEFI specification requires the ESRT to be in EfiBootServ=
icesData
> > > > > > > memory, which Xen will use for whatever purposes it likes.  T=
herefore,
> > > > > > > Linux cannot safely access the ESRT, as Xen may have overwrit=
ten it.
> > > > > > >
> > > > > > > Starting with Xen 4.17, Xen checks if the ESRT is in EfiBootS=
ervicesData
> > > > > > > or EfiRuntimeServicesData memory.  If the ESRT is in EfiBootS=
ervicesData
> > > > > > > memory, Xen replaces the ESRT with a copy in memory that it h=
as
> > > > > > > reserved.  Such memory is currently of type EFI_RUNTIME_SERVI=
CES_DATA,
> > > > > > > but in the future it will be of type EFI_ACPI_RECLAIM_MEMORY.=
  This
> > > > > > > ensures that the ESRT can safely be accessed by the OS.
> > > > > > >
> > > > > > > When running as a Xen dom0, use the new
> > > > > > > xen_config_table_memory_region_max() function to determine if=
 Xen has
> > > > > > > reserved the ESRT and, if so, find the end of the memory regi=
on
> > > > > > > containing it.  This allows programs such as fwupd which requ=
ire the
> > > > > > > ESRT to run under Xen, and so makes fwupd support in Qubes OS=
 possible.
> > > > > > >
> > > > > > > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.co=
m>
> > > > > >
> > > > > > Why do we need this patch? I'd expect esrt_table_exists() to re=
turn
> > > > > > false when patch 1/2 is applied.
> > > > >
> > > > > efi_enabled(EFI_MEMMAP) is false under Xen, so there needs to be =
an
> > > > > alternative way to get the end of the memory region containing th=
e ESRT.
> > > > > That is what this patch provides.
> > > >
> > > > OK. I don't think we need that to be honest. When running under Xen,
> > > > we should be able to assume that the ESRT does not span multiple
> > > > memory regions arbitrarily, so we can just omit this check if
> > > > !efi_enabled(EFI_MEMMAP)
> > > >
> > > > IIRC (and Peter would know), we are trying to filter out descriptors
> > > > that are completely bogus here: zero lenght, zero address, etc etc.=
 I
> > > > don't think we need that for Xen.
> > >
> > > Xen doesn=E2=80=99t uninstall bogus ESRTs, so there is no less reason=
 to worry
> > > under Xen than on bare hardware.
> >
> > That may be true. But if Xen needs dom0 to be able to cross reference
> > the EFI memory map, it should provide one (and set EFI_MEMMAP to
> > enabled).
>=20
> Btw the efi_mem_reserve() for the ESRT is also redundant if it is
> guaranteed to be in RT services data or ACPI reclaim memory.

It=E2=80=99s needed on bare hardware.  On Xen it=E2=80=99s unreachable code.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--O0m4X08RcO4y0b4+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3bHMACgkQsoi1X/+c
IsELVxAArRvWRhFqD/HZjNwD8miJSVhkUC762UgZ3NMbiQ0XEB+cjEpOxs6cEGWg
zyclHhXXkl2SUxuOC/PyIDj5WngwTIHGmGxvWEnq4zr4PAJWYptR1MeAo4zYWU1k
dBcBH/GZ8+ofW3hjfQdS9B8mnJQanp4BubEN0wY9mQOPetx8Fh0my7Pz36xVuUhf
Nl1QgdrB8+Akmya4m7KN0ZxdMTm+e/QNSWogtsCpNls+nNDo6Rz7rjsKZJVpULQW
3GyptvapCv/tneLk7XgevsTP2FqWIIkV9DHag8HOrMCdv26xkyH2BrRXAYOvMzae
N5H6dJYuZsdAnRptOzD74OeRRHo7Jgeb6oiqRSmmVG4VdfSVMrnJ5k4ZoN3tb0bx
lBgWDLVQRwoqdYDP6i0d5sf5ZPe+iopD2L1U2+doE8MfNETOxF9BRXolzYS1qwzS
w9ypAkP0NymMO2yCpDxm5mpNwyK/fr40SPBx+E0HgqezKAB5JimPuNI2B54Gb7P7
pbn24u3NyLDnEKSMOaDUmaExTVQqfv4vHmhLYnxya0+bWSqzQ1ia/VAI7SfHZqR7
xwOkstQ1VDwSnZsVoZJebsGDEg5G3B3G21MPFuQd2I6G2KPJRQlQG+kqlLn0vV4J
rJWlWzvlSQZNtoh0h3HL8+KfiT8ztRBJmDfKnCfxB14LWGOVBHw=
=FSrg
-----END PGP SIGNATURE-----

--O0m4X08RcO4y0b4+--