Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp55682rwb; Fri, 30 Sep 2022 17:16:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Azgex1NQWWX18sykVNBAcLaPL9g8Erp5cs1/QFzTDj7MEpTIq12UXCGFZAnmtB7cyXyqs X-Received: by 2002:a17:906:58cb:b0:787:8485:8555 with SMTP id e11-20020a17090658cb00b0078784858555mr8013554ejs.252.1664583365063; Fri, 30 Sep 2022 17:16:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664583365; cv=none; d=google.com; s=arc-20160816; b=MAAWsha4hq7NN/igdbVKk5IWLk1z7b/3U+mwDOTFhVkHxQsaAYAURBsZ0UdwQjMFpi OamFoiIV9o2XbfYYPA+QO/54R6BeCYDoTOoQ65yuPwuydEc/uvs+XQHPBKnF4fRFrZ9H OXphtLtV/lnuieszqfM5V8rgOGSMtu83a2IBdHcvUngaeDIerpT0jWGc/36Noar1hBYY k4EUo6E6quSWZ5plTP8xeToQwmv8pDrAx1iMwqKfE8QVejmh7XAYThV16GD45qhGD4PV S6cdCAQvD3O8qUHQCo9PfPmomY1HKatKsYMGuqXb5dgPEEG81R1aZXgBI5oJ89evUqmk gx/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=Z2+zNHYiiIkWCAkYKhNJGpAi25tc19KhEHaBUIEP4to=; b=i1w2Ry4OA4vCCz95YEOV3yj7QpmJKDGTQYO80MjY1qP+2IJeI/jMpelWpaeV60MuEe nL38VVFhbYCbiPtVZjk/zeEZFgCEZk8kL+FaR8V3NpISrvKeoQKqhAUrp8bsyOMO7leI iY65nhtMuWP4L9OzkbBBVH9ZIat/xUjvn9Mfh3KNUg0Ca/c1kl0tqA43z7X+C6u1kOOk XYiP5ytgnW+gjMzUOttebqcliPU/ym6IB062AW1cZhsrFE9k8bYEpsqlSN2Tl2f4rWgs utiZqwa16/kR3DEkvWN1mchsjoirYukfBIF5e82lzmcBRk56aDTNiEOgX+JG3Do44hH1 pUpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WlPT43bZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd16-20020a170907629000b00787b9cd2fe3si2660534ejc.844.2022.09.30.17.15.34; Fri, 30 Sep 2022 17:16:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WlPT43bZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232103AbiJAAHN (ORCPT + 99 others); Fri, 30 Sep 2022 20:07:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231592AbiJAAHL (ORCPT ); Fri, 30 Sep 2022 20:07:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BFECAFB0; Fri, 30 Sep 2022 17:07:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A619F61CB4; Sat, 1 Oct 2022 00:07:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2603C433C1; Sat, 1 Oct 2022 00:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664582830; bh=Z2+zNHYiiIkWCAkYKhNJGpAi25tc19KhEHaBUIEP4to=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=WlPT43bZju4hny7sxxb4UV5mSV4+U2/ZYcFdaDxDI+SsZPpyMpznsktbXFGtcdal+ PUcS+T64XQVdP2oARoNC6hyNHK91hyOw/YAQVPVCNufDpyZ0j1vb7RFFGW4ECyUUEm Uzhe5tQlqHC95b6OmBSso3DUJtF4vizW3TD8WlP46nE8rFX/uQYceK/Ds0jWAb9gnv Lkh9izIXTegMI2NnvUaDP3bmQ8xf2yTlzGpvdgEqFzvHGDvaF4K94MK+BL7GslN2MN GiWFNh8FIzwPaFEq3mtY+N7sD94vjRgkxfsrCf36rXOOiM8lr1H3q6p4SyhZsBUO34 ZP+oCPleaGemA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220914033206.98046-1-linyujun809@huawei.com> References: <20220914033206.98046-1-linyujun809@huawei.com> Subject: Re: [PATCH -next] clk: imx: scu: fix memleak on platform_device_add() fails From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Lin Yujun , abelvesa@kernel.org, aisheng.dong@nxp.com, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, mturquette@baylibre.com, s.hauer@pengutronix.de, shawnguo@kernel.org Date: Fri, 30 Sep 2022 17:07:08 -0700 User-Agent: alot/0.10 Message-Id: <20221001000709.F2603C433C1@smtp.kernel.org> X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Lin Yujun (2022-09-13 20:32:06) > No error handling is performed when platform_device_add() > fails. Add error processing before return, and modified > the return value. >=20 > Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") > Signed-off-by: Lin Yujun > --- Applied to clk-next