Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Sep 2022 17:20:22 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 net-next 12/14] dt-bindings: net: dsa: ocelot: add
 ocelot-ext documentation
Message-ID: <YzeHxmYMjMoDqIHe@euler>
References: <20220926002928.2744638-1-colin.foster@in-advantage.com>
 <20220926002928.2744638-13-colin.foster@in-advantage.com>
 <20220927202600.hy5dr2s6j4jnmfpg@skbuf>
 <Yzdcjh4OTI90wWyt@euler>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yzdcjh4OTI90wWyt@euler>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j5FyacRw5Fl9VdR6wdlBISljHrphLFQpxoYlWBrlqCn8CDo1Wc8+X61JY2tr?=
 =?us-ascii?Q?/fi4ClfEJJ6LERc+xkiJtRboKNcUvAy4/YFJcx+1Ll/BF5wZ/eJR8+yjXq3H?=
 =?us-ascii?Q?n8rYABWTaqc5RMh/gkIW/W2UDPRq86MMrlf1xoHLHpWnUPTVolx5p09abwHC?=
 =?us-ascii?Q?XEmu4QUs4A8oO4gj0kGHQ+b3B9bsI6PDiNQKJrFHUJPt6yc6C2OUPOZfixQk?=
 =?us-ascii?Q?Me6UiQzLHGhf41D5bk+vpS2efK8Laj0seLwIcDSKfdd4hGfHOohGTg2TRjb1?=
 =?us-ascii?Q?gzfnHfkW97ozYcAywD39aat1kYItZ3zsqWoA3/OMRGUYQ5pdFBa0wjC9ipi+?=
 =?us-ascii?Q?Fk+OYlRzzbTvn6sRM789bQyE7nSI5qJvYehNNpHwKqR3nv1JVPfvi1cT9kjp?=
 =?us-ascii?Q?WZMMmVVMggsUpaNHIAXAWT4khlpWgC5ofbuJgI+zwdOsTPs5oAavIPtB60od?=
 =?us-ascii?Q?MXjtbZPkS3ic7CQMM41rxRqc4BAWT/lfpVALb3TSyN08xptJEKOeXFDNpdCB?=
 =?us-ascii?Q?NvcypORplQJIC0PRtqIX4R+XL7jx7hmjSb6a3N1AvNb6GI3E+GereTB6wdn4?=
 =?us-ascii?Q?SwrQE6kTu1fPYYT++DEav4fkt/4KfxqkG6w5QMC8FTTxbeqZYlF740FgTrOS?=
 =?us-ascii?Q?RgiSY1EPwdwpqkKTtW9UAP9CZMXbtiVpk8n7n8HE93CuLLMDF41WSdgIw6Md?=
 =?us-ascii?Q?N1frj2Hp0gYZQsYRi0iXVJvGZhDFpfhJEWIJhfyii8ouT08fz+DPOHTWqgFp?=
 =?us-ascii?Q?EHfWcqDOHstYFYPI3Wkby+jlM5+WvB1bLi3zG+HWDNEtj3d74Y0qxfXENLTa?=
 =?us-ascii?Q?lS7a7P4YjzyEx7glc0sO+hlHopaKhixd/L2s3JabdTbdlWTyREUnlmiItPSe?=
 =?us-ascii?Q?xfitq9WS6FjSztNj1R69zxCY2Btymq3aPQpz5h24hYSmwfx6qhkG27gnZ8Rs?=
 =?us-ascii?Q?KRQ7ScAwr86dv+N6njXjUBK78sv8gguC/3P/H34x6JUWTPUABdo5bg5vz7bN?=
 =?us-ascii?Q?/qIN8IKWfoLDJvOFEW0BOfhyrSBbJ+xvfw1GNzV3c7/1lo4lPNeT+jJieZSo?=
 =?us-ascii?Q?AHKjuRJ7DxCsniVBRMomqPp8Xw8cHQCswytbwcIbl588lq0vt5jfbzxGG0ow?=
 =?us-ascii?Q?PnDQ5OP3XuOoA7oYDG7sqJ6HnWelYUqeCNi1ljzkgFLzoqVbRkK2h8aeCGE4?=
 =?us-ascii?Q?VPTEBKhc3vKYGJPzcfkI2VOojuar60lrxjHvaKOczmS41Cuqn4+TOm1/11qT?=
 =?us-ascii?Q?iG4UoXc80fglJhEsxc4M5P3otGkmvzX/xn6YSyO9NF05II4lJT4n1PxLXdUV?=
 =?us-ascii?Q?/F2srZbLgFDoHBi5A4FODAvbgb81WMF3WePZOQiT+x1YQL3cI5J/uFC1Xi+/?=
 =?us-ascii?Q?O6UPzuJ8sUY+A395MezB7g8Z8GJkic3OndjAl70duoZgZsfIlyP2FlP6iAfr?=
 =?us-ascii?Q?5i4ZCGPkzrd9BINzxZxXPq7qUtj3DkN59Uwua+V52fj9M9q9gorIHEiNOafd?=
 =?us-ascii?Q?X5suGmJkN4fFtv4OBLaLHFdlg6inKUQb3nffx2vM664tLqjAoAJCMcjFc6hU?=
 =?us-ascii?Q?zNWCNJizOs4o/stOzbpiY5yFrs/mi2cNLm5cw0CPmtbByStFfw13ftDQAjhL?=
 =?us-ascii?Q?eA=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d519742-79c4-4d16-e68f-08daa342bd41
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1001MB2345.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2022 00:20:26.8009
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4VSYZbsMy8YTBYgnXWlUCs+ECPidnasJhme9jSREsPDKA0DxPWlUwcfuV/iQbLkARyfyLmp/YWzHjL49vxmL0sqYU/LeP6eGCZ4EZQW4PRo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5805
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 30, 2022 at 02:15:58PM -0700, Colin Foster wrote:
> On Tue, Sep 27, 2022 at 11:26:00PM +0300, Vladimir Oltean wrote:
> > On Sun, Sep 25, 2022 at 05:29:26PM -0700, Colin Foster wrote:
> > > ---
> > > +      - phy-mode = "internal": on ports 0, 1, 2, 3
> > 
> > More PHY interface types are supported. Please document them all.
> > It doesn't matter what the driver supports. Drivers and device tree
> > blobs should be able to have different lifetimes. A driver which doesn't
> > support the SERDES ports should work with a device tree that defines
> > them, and a driver that supports the SERDES ports should work with a
> > device tree that doesn't.
> 
> This will change my patch a little bit then. I didn't undersand this
> requirement.
> 
> My current device tree has all 8 ethernet ports populated. ocelot_ext
> believes "all these port modes are accepted" by way of a fully-populated
> vsc7512_port_modes[] array.
> 
> As a result, when I'm testing, swp4 through swp7 all enumerate as
> devices, though they don't actually function. It isn't until serdes /
> phylink / pcs / pll5 come along that they become functional ports.
> 
> I doubt this is desired. Though if I'm using the a new macro
> OCELOT_PORT_MODE_NONE, felix.c stops after felix_validate_phy_mode.
> 
> I think the only thing I can do is to allow felix to ignore invalid phy
> modes on some ports (which might be desired) and continue on with the
> most it can do. That seems like a potential improvement to the felix
> driver...
> 
> The other option is to allow the ports to enumerate, but leave them
> non-functional. This is how my system currently acts, but as I said, I
> bet it would be confusing to any user.
> 
> Thoughts?
> 

Also, for what its worth, I tried this just now by making this change:

err = felix_validate_phy_mode(felix, port, phy_mode);
if (err < 0) {
        dev_err(dev, "Unsupported PHY mode %s on port %d\n",
                phy_modes(phy_mode), port);
        of_node_put(child);
 -      return err;
 +      continue;
}

This functions in that I only see swp1-swp3, but I don't think it
should - it is just leaving phy_mode set to 0 (PHY_INTERFACE_MODE_NA).
My guess is it'll need more logic to say "don't add these DSA ports because
the driver doesn't support those PHY interfaces"


[    3.555367] ocelot-switch ocelot-switch.4.auto: Unsupported PHY mode qsgmii on port 4
[    3.563551] ocelot-switch ocelot-switch.4.auto: Unsupported PHY mode qsgmii on port 5
[    3.571570] ocelot-switch ocelot-switch.4.auto: Unsupported PHY mode qsgmii on port 6
[    3.579459] ocelot-switch ocelot-switch.4.auto: Unsupported PHY mode qsgmii on port 7
[    4.271832] ocelot-switch ocelot-switch.4.auto: PHY [ocelot-miim0.2.auto-mii:00] driver [Generic PHY] (irq=POLL)
[    4.282715] ocelot-switch ocelot-switch.4.auto: configuring for phy/internal link mode
[    4.296478] ocelot-switch ocelot-switch.4.auto swp1 (uninitialized): PHY [ocelot-miim0.2.auto-mii:01] driver [Generic PHY] (irq=POLL)
[    4.312876] ocelot-switch ocelot-switch.4.auto swp2 (uninitialized): PHY [ocelot-miim0.2.auto-mii:02] driver [Generic PHY] (irq=POLL)
[    4.328897] ocelot-switch ocelot-switch.4.auto swp3 (uninitialized): PHY [ocelot-miim0.2.auto-mii:03] driver [Generic PHY] (irq=POLL)
[    5.032849] ocelot-switch ocelot-switch.4.auto swp4 (uninitiailized): validation of qsgmii with support 00000000,00000000,000062ff and advertisement 00000000,00000000,000062ff failed: -EINVAL
[    5.051265] ocelot-switch ocelot-switch.4.auto swp4 (uninitialized): failed to connect to PHY: -EINVAL
[    5.060670] ocelot-switch ocelot-switch.4.auto swp4 (uninitialized): error -22 setting up PHY for tree 0, switch 0, port 4
(repeated for swp5-7)