Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Sep 2022 21:13:08 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Jarkko Sakkinen <jarkko@kernel.org>
Cc:     Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe
Message-ID: <Yze+VDJ2u03zg2HC@google.com>
References: <20220926053958.1541912-1-dmitry.torokhov@gmail.com>
 <20220926053958.1541912-3-dmitry.torokhov@gmail.com>
 <YzdVJYuzYzBTELI0@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YzdVJYuzYzBTELI0@kernel.org>
Precedence: bulk

On Fri, Sep 30, 2022 at 11:44:21PM +0300, Jarkko Sakkinen wrote:
> On Sun, Sep 25, 2022 at 10:39:58PM -0700, Dmitry Torokhov wrote:
> > Driver core will never call driver's probe method without appropriate
> > device structure, so testing them for NULL is pointless.
> > 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Missing a description what the patch does.
> 
> Also instead of "driver's probe method" you could just use
> "st33zp24_i2c_probe()". It's even shorter.

There are 2 interfaces: I2C and SPI, thus 2 separate probe methods.

Thanks.

-- 
Dmitry